From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 570714819E for ; Thu, 11 Jan 2024 12:02:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DD2BB68CFCB; Thu, 11 Jan 2024 14:01:58 +0200 (EET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1DE0A68CC0F for ; Thu, 11 Jan 2024 14:01:53 +0200 (EET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d4a2526a7eso30252815ad.3 for ; Thu, 11 Jan 2024 04:01:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704974510; x=1705579310; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=v9Q+ZuOsccYoeRJT2BwDFpHVHnDOyZTZIM9drBmBuzM=; b=e7Lh4v1y67MP4fgS1ZttcKELC80fdrsrUdpoF8/+bvIVVkieVefRAHBuwqXpaD9Mas 8y+MjtyAU2ULmriZ5hH+H8nbw0cIafn9vfw17KGBU4Ngv48t5ib83nurBPS4ng71IdyB bUZGumKj406EDDKES4YkiNUEm8Pav4UGCRSqaGgF/59LVrAjjB7kaBYFNhYfvxInRRCz HMiNiH+JWTfE+9LJ05JiB4dlEiBkV8xpVdejQRz01JwrmjoA+Lxl1aaO57Cl/+JgWzrf QMMi6Ipc/CZEOQiT6TBuMWH2EP9M5BNSbbCFSpbpl7AWVcC+XtkyQ4IcPZpkRJkCqnWf 4Axg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704974510; x=1705579310; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v9Q+ZuOsccYoeRJT2BwDFpHVHnDOyZTZIM9drBmBuzM=; b=cwjtV1ty6U214RAz3Lf/SNHqgMXlMo4URa7/5NQcfsunBekBehZeBl3eWT06RxNxg2 5eaz+L4xroPvnjyZlgNzQ6ioIQchvmaX5vxnkEU1ObeDOC6rwU5QKN4sunIcG+gjcx89 77yjIJ/LuefX6sdPWu0xhBsMKrlijpb+XnIVqCmfZIpobSSFqGMTN9p5t6jYT+bR8aNB XdPzSvAoJaHSxEmTofcycrUzamJfaoDrMpuVUTN+1EY59lf8UQhRBF07fWYNQsBD66Ms UOu7o8A1mUBpOufHgAwXZSUEdDj1nRRqp4yWk7E8MIIIXVTn+s5CMslFGR12Jy8+bjdY DFow== X-Gm-Message-State: AOJu0Ywwmu89mcCYij9xKz6e+xEhWRHdcjPuTQAZdWLvOK+zAaixBmKY ES6Q0G7AzVDPqlAA41z4dPjRxJjVmls= X-Google-Smtp-Source: AGHT+IF78AF1/P2EwVLhmdIaCQ3qk3bsG6DLDMiTIa0p/Clby0w0zrvsFIbGOARZzmMhYj1W3Qo67A== X-Received: by 2002:a17:903:2c7:b0:1d5:844:da22 with SMTP id s7-20020a17090302c700b001d50844da22mr1118581plk.15.1704974510182; Thu, 11 Jan 2024 04:01:50 -0800 (PST) Received: from [192.168.0.13] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id p16-20020a170902b09000b001d3b258e036sm1015075plr.176.2024.01.11.04.01.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 04:01:49 -0800 (PST) Message-ID: Date: Thu, 11 Jan 2024 09:02:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240107213100.16205-1-jamrial@gmail.com> <20240107213100.16205-4-jamrial@gmail.com> <20240110030518.GS6420@pb2> <26382cca-3bb1-4b5e-96b6-ce9cdd857466@gmail.com> <20240111031717.GW6420@pb2> Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <20240111031717.GW6420@pb2> Subject: Re: [FFmpeg-devel] [PATCH 4/4] fate: add raw IAMF tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/11/2024 12:17 AM, Michael Niedermayer wrote: > On Wed, Jan 10, 2024 at 09:52:28AM -0300, James Almer wrote: >> On 1/10/2024 12:05 AM, Michael Niedermayer wrote: >>> On Sun, Jan 07, 2024 at 06:31:00PM -0300, James Almer wrote: >>>> Covers muxing from raw pcm audio input into FLAC, using several scalable layouts, >>>> and demuxing the result. >>>> >>>> Signed-off-by: James Almer >>>> --- >>>> tests/Makefile | 7 +- >>>> tests/fate/iamf.mak | 31 ++++++ >>>> tests/filtergraphs/iamf_5_1 | 4 + >>>> tests/filtergraphs/iamf_5_1_2 | 5 + >>>> tests/filtergraphs/iamf_5_1_4 | 6 ++ >>>> tests/filtergraphs/iamf_7_1_4 | 7 ++ >>>> tests/ref/fate/iamf-5_1_4 | 98 ++++++++++++++++++ >>>> tests/ref/fate/iamf-7_1_4 | 114 +++++++++++++++++++++ >>>> tests/ref/fate/iamf-stereo | 18 ++++ >>>> tests/streamgroups/audio_element-5_1_4 | 7 ++ >>>> tests/streamgroups/audio_element-7_1_4 | 6 ++ >>>> tests/streamgroups/audio_element-stereo | 3 + >>>> tests/streamgroups/mix_presentation-5_1_4 | 2 + >>>> tests/streamgroups/mix_presentation-7_1_4 | 2 + >>>> tests/streamgroups/mix_presentation-stereo | 3 + >>>> 15 files changed, 312 insertions(+), 1 deletion(-) >>>> create mode 100644 tests/fate/iamf.mak >>>> create mode 100644 tests/filtergraphs/iamf_5_1 >>>> create mode 100644 tests/filtergraphs/iamf_5_1_2 >>>> create mode 100644 tests/filtergraphs/iamf_5_1_4 >>>> create mode 100644 tests/filtergraphs/iamf_7_1_4 >>>> create mode 100644 tests/ref/fate/iamf-5_1_4 >>>> create mode 100644 tests/ref/fate/iamf-7_1_4 >>>> create mode 100644 tests/ref/fate/iamf-stereo >>>> create mode 100644 tests/streamgroups/audio_element-5_1_4 >>>> create mode 100644 tests/streamgroups/audio_element-7_1_4 >>>> create mode 100644 tests/streamgroups/audio_element-stereo >>>> create mode 100644 tests/streamgroups/mix_presentation-5_1_4 >>>> create mode 100644 tests/streamgroups/mix_presentation-7_1_4 >>>> create mode 100644 tests/streamgroups/mix_presentation-stereo >>> >>> Iam probably missing some dependancies but, reporting anyway >>> this fails fate: >>> >>> [aist#0:0/pcm_s16le @ 0x5645f5820680] Guessed Channel Layout: stereo >>> Input #0, wav, from 'ffmpeg/tests/data/asynth-44100-2.wav': >>> Duration: 00:00:06.00, bitrate: 1411 kb/s >>> Stream #0:0: Audio: pcm_s16le ([1][0][0][0] / 0x0001), 44100 Hz, 2 channels, s16, 1411 kb/s >>> [in#0/wav @ 0x5645f5812400] Codec AVOption idct (select IDCT implementation) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some decoder which was not actually used for any stream. >>> [out#0/iamf @ 0x5645f585af80] Codec AVOption dct (DCT algorithm) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some encoder which was not actually used for any stream. >>> [out#0/iamf @ 0x5645f585af80] Codec AVOption idct (select IDCT implementation) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some encoder which was not actually used for any stream. >>> [out#0/iamf @ 0x5645f585af80] Invalid or missing stream group index in submix element specification "stg=0:parameter_id=100:headphones_rendering_mode=stereo:annotations=en-us=Scalable_Submix" >>> Error opening output file ffmpeg/tests/data/fate/iamf-stereo.iamf. >>> Error opening output files: Invalid argument >>> threads=1 >>> tests/Makefile:317: recipe for target 'fate-iamf-stereo' failed >>> make: *** [fate-iamf-stereo] Error 234 >>> >>> thx >> >> I can't reproduce this. Tried with these four patches using current master >> and it works. >> Could it be strtoll misbehaving? Can you check what values are in idx, >> oc->nb_stream_groups, and endptr? > > didnt had time to look its 4am i need to eat and go to bed :) > but a quick test with this: > diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c > index 1b42ac9a1d7..224e9e8268e 100644 > --- a/fftools/ffmpeg_mux_init.c > +++ b/fftools/ffmpeg_mux_init.c > @@ -2113,8 +2113,10 @@ static int of_parse_iamf_submixes(Muxer *mux, AVStreamGroup *stg, char *ptr) > char *endptr = NULL; > int64_t idx = -1; > > - if (e = av_dict_get(dict, "stg", NULL, 0)) > + if (e = av_dict_get(dict, "stg", NULL, 0)) { > idx = strtoll(e->value, &endptr, 0); > + av_log(0,0, "B idx:%"PRId64" NSG:%d endptr: %p endptr:%s value:%s\n", idx, oc->nb_stream_groups, endptr, endptr, e->value); > + } > av_dict_set(&dict, "stg", NULL, 0); I guess this called before the checks is what's wrong. > if (!endptr || *endptr || idx < 0 || idx >= oc->nb_stream_groups - 1 || > oc->stream_groups[idx]->type != AV_STREAM_GROUP_PARAMS_IAMF_AUDIO_ELEMENT) { > @@ -2245,6 +2247,7 @@ static int of_parse_group_token(Muxer *mux, const char *token, char *ptr) > while (e = av_dict_get(dict, "stg", e, 0)) { > char *endptr; > int64_t idx = strtoll(e->value, &endptr, 0); > + av_log(0,0, "idx:%"PRId64" NSG:%d endptr:%s\n", idx, oc->nb_stream_groups, endptr); > if (*endptr || idx < 0 || idx >= oc->nb_stream_groups - 1) { > av_log(mux, AV_LOG_ERROR, "Invalid stream group index %"PRId64"\n", idx); > ret = AVERROR(EINVAL); > > > i get: > [aist#0:0/pcm_s16le @ 0x55ae216e6680] Guessed Channel Layout: stereo > Input #0, wav, from 'ffmpeg/tests/data/asynth-44100-2.wav': > Duration: 00:00:06.00, bitrate: 1411 kb/s > Stream #0:0: Audio: pcm_s16le ([1][0][0][0] / 0x0001), 44100 Hz, 2 channels, s16, 1411 kb/s > [in#0/wav @ 0x55ae216d8400] Codec AVOption idct (select IDCT implementation) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some decoder which was not actually used for any stream. > [out#0/iamf @ 0x55ae21720f80] Codec AVOption dct (DCT algorithm) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some encoder which was not actually used for any stream. > [out#0/iamf @ 0x55ae21720f80] Codec AVOption idct (select IDCT implementation) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some encoder which was not actually used for any stream. > idx:0 NSG:2 endptr: > B idx:0 NSG:2 endptr: 0x55ae21728b81 endptr: value:0 > [out#0/iamf @ 0x55ae21720f80] Invalid or missing stream group index in submix element specification "stg=0:parameter_id=100:headphones_rendering_mode=stereo:annotations=en-us=Scalable_Submix" > Error opening output file ffmpeg/tests/data/fate/iamf-stereo.iamf. > Error opening output files: Invalid argument > threads=1 > tests/Makefile:317: recipe for target 'fate-iamf-stereo' failed > make: *** [fate-iamf-stereo] Error 234 > > i also see other failures: > make: *** [fate-iamf-stereo] Error 234 > make: *** [fate-iamf-5_1_4] Error 234 > make: *** [fate-iamf-7_1_4] Error 234 > > thx > > [...] > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".