From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id D900243CD0
	for <ffmpegdev@gitmailbox.com>; Wed,  5 Apr 2023 12:45:42 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 16ACA68BA76;
	Wed,  5 Apr 2023 15:45:40 +0300 (EEST)
Received: from mail.frobbit.se (mail.frobbit.se [85.30.129.176])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 638CB68A33A
 for <ffmpeg-devel@ffmpeg.org>; Wed,  5 Apr 2023 15:45:33 +0300 (EEST)
Received: from debian.lan (h-79-136-39-105.A258.priv.bahnhof.se
 [79.136.39.105])
 by mail.frobbit.se (Postfix) with ESMTPSA id E57AF1FD9F
 for <ffmpeg-devel@ffmpeg.org>; Wed,  5 Apr 2023 14:45:32 +0200 (CEST)
Message-ID: <d39cbc361ea4878f4c90d6eb1c28b3e60fbf29a2.camel@haerdin.se>
From: Tomas =?ISO-8859-1?Q?H=E4rdin?= <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Date: Wed, 05 Apr 2023 14:45:32 +0200
In-Reply-To: <fc5d5dfe-af62-3d9f-58c8-18906036bd82@ektacom.com>
References: <24e1274d-db0c-da87-60a1-50a9e9f63f13@ektacom.com>
 <fc5d5dfe-af62-3d9f-58c8-18906036bd82@ektacom.com>
User-Agent: Evolution 3.38.3-1+deb11u1 
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] Add track name information when track is
 written. - Sponsored by INA
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/d39cbc361ea4878f4c90d6eb1c28b3e60fbf29a2.camel@haerdin.se/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

> +    if (st->codecpar) {
> +        static const char * pcTrackName_Video = "Picture" ;
> +        static const char * pcTrackName_Audio = "Sound" ;
> +        static const char * pcTrackName_Anc = "Ancillary" ;
> +        if ( st->codecpar->codec_type == AVMEDIA_TYPE_VIDEO )
> +        {
> +            //TrackName Video
> +            klv_encode_ber_length(pb, 80 +
> mxf_utf16_local_tag_length(pcTrackName_Video));
> +            mxf_write_local_tag_utf16(s, 0x4802 ,
> pcTrackName_Video);
> +        } else if ( st->codecpar->codec_type == AVMEDIA_TYPE_AUDIO )
> {
> +            //TrackName Audio
> +            klv_encode_ber_length(pb, 80 +
> mxf_utf16_local_tag_length(pcTrackName_Audio));
> +            mxf_write_local_tag_utf16(s, 0x4802, pcTrackName_Audio);
> +        } else {
> +            //TrackName Ancillary
> +            klv_encode_ber_length(pb, 80 +
> mxf_utf16_local_tag_length(pcTrackName_Anc));
> +            mxf_write_local_tag_utf16(s, 0x4802, pcTrackName_Anc);

Is calling timecode, subtitle etc tracks "Ancillary" really
appropriate?

Also you need to update the FATE references like Michael says

/Tomas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".