From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F1C374024E for ; Mon, 20 Jun 2022 19:05:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2C76368B3F9; Mon, 20 Jun 2022 22:05:29 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DA49468B3F9 for ; Mon, 20 Jun 2022 22:05:22 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 25KJ5L9c015025-25KJ5L9d015025 for ; Mon, 20 Jun 2022 22:05:21 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id B1DB8A142E for ; Mon, 20 Jun 2022 22:05:21 +0300 (EEST) Date: Mon, 20 Jun 2022 22:05:18 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20220620103001.15035-1-nil-admirari@mailo.com> Message-ID: References: <20220620103001.15035-1-nil-admirari@mailo.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v20 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi(), getenv_utf8(), freeenv_utf8() and getenv_dup() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 20 Jun 2022, Nil Admirari wrote: > wchartoutf8() converts strings returned by WinAPI into UTF-8, > which is FFmpeg's preffered encoding. > > Some external dependencies, such as AviSynth, are still > not Unicode-enabled. utf8toansi() converts UTF-8 strings > into ANSI in two steps: UTF-8 -> wchar_t -> ANSI. > wchartoansi() is responsible for the second step of the conversion. > Conversion in just one step is not supported by WinAPI. > > Since these character converting functions allocate the buffer > of necessary size, they also facilitate the removal of MAX_PATH limit > in places where fixed-size ANSI/WCHAR strings were used > as filename buffers. > > On Windows, getenv_utf8() wraps _wgetenv() converting its input from > and its output to UTF-8. Strings returned by getenv_utf8() > must be freed by freeenv_utf8(). > > On all other platforms getenv_utf8() is a wrapper around getenv(), > and freeenv_utf8() is a no-op. > > The value returned by plain getenv() cannot be modified; > av_strdup() is usually used when modifications are required. > However, on Windows, av_strdup() after getenv_utf8() leads to > unnecessary allocation. getenv_dup() is introduced to avoid > such an allocation. Value returned by getenv_dup() must be freed > by av_free(). > > Because of cleanup complexities, in places that only test the existence > of an environment variable or compare its value with a string > consisting entirely of ASCII characters, the use of plain getenv() > is still preferred. (libavutil/log.c check_color_terminal() > is an example of such a place.) > > Plain getenv() is also preffered in UNIX-only code, > such as bktr.c, fbdev_common.c, oss.c in libavdevice > or af_ladspa.c in libavfilter. > --- > configure | 1 + > libavutil/getenv_utf8.h | 86 ++++++++++++++++++++++++++++++++++++++ > libavutil/wchar_filename.h | 53 +++++++++++++++++++++++ > 3 files changed, 140 insertions(+) > create mode 100644 libavutil/getenv_utf8.h This set looks good to me, thanks! Will push tomorrow if there's nothing more to add on it. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".