From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3EF2E4784D for ; Tue, 26 Sep 2023 11:08:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 53A1E68CA00; Tue, 26 Sep 2023 14:08:37 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 46FB468C9E5 for ; Tue, 26 Sep 2023 14:08:31 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 38QB8TCE014153-38QB8TCF014153; Tue, 26 Sep 2023 14:08:29 +0300 Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144]) by mail9.parnet.fi (Postfix) with ESMTPS id A2ECAA1450; Tue, 26 Sep 2023 14:08:29 +0300 (EEST) Date: Tue, 26 Sep 2023 14:08:28 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches , James Almer , Andreas Rheinhardt In-Reply-To: <169572538872.30795.16177316508895674736@lain.khirnov.net> Message-ID: References: <169572538872.30795.16177316508895674736@lain.khirnov.net> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/avformat: Deprecate AVFMT_ALLOW_FLUSH X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 26 Sep 2023, Anton Khirnov wrote: > Quoting Andreas Rheinhardt (2023-09-26 01:54:30) >> It is of no value to the user, because every muxer can always >> be flushed with a NULL packet. As its documentation shows >> ("If not set, the muxer will not receive a NULL packet in >> the write_packet function") it is actually an internal flag >> that has been publically exposed because there was no internal >> flags field for output formats for a long time. But now there is >> and so use it by replacing the public flag with a private one. > > Is there any value for the callers in knowing whether flushing is a > no-op or actually does something? Hypthetically, in theory, I guess one could make a case for that. But most of the codepaths where one use this anyway, one is pretty closely tied to the specific muxer one is using (usually mov/mp4 or maybe mkv), so in practice I don't think that's needed. I don't remember there being a specific demand for that back when this was added, it was only a case of us not having internal flags at the time. Conversely, I guess we could google for AVFMT_ALLOW_FLUSH and see if there's any public third party code that shows uses of the flag. A quick googling didn't find any uses outside of ffmpeg itself, except for one example on stackoverflow where the flag seems to be used in an invalid way. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".