From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0E5E54252A for ; Fri, 18 Mar 2022 11:38:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8730368B109; Fri, 18 Mar 2022 13:38:36 +0200 (EET) Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DCC8468AE9E for ; Fri, 18 Mar 2022 13:38:30 +0200 (EET) Received: by mail-oo1-f52.google.com with SMTP id y27-20020a4a9c1b000000b0032129651bb0so9815956ooj.2 for ; Fri, 18 Mar 2022 04:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=ZFWEap3VORNchRuyUJAEAx6zh4xGG9Kj5c6f8ZQ7xIg=; b=W4ah9icnv2Rerr0oUZmUemJ1rRvVg47cGkGGC4bEhLYpOuA4SpijnlHz6iSqweqRZm FGZAlWjibeoZh2iFb1kKjQorQsTt5V3rD4hbpu+RPg1TVV8IDSpgDFMBE6z4SwNMkove t3gqmr5Mtm1f/E88vv+5n14xMTJ0wt8iRufZM81xjxXlRpQoan7jNFyQUADJ1zjhcbaD Jy1ePFv7qVRWBTwNrCB19Tkps0IARaTbrODTlzRntW7GhoqelA/No/yJXoup5WweTkDR RP04QIC9Q4m+bmJ+pXr1yf6nIeF2DNWdKiuejAJwWYQfLhxcC7mdXiZlIjClzi/Nc+bp nJOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ZFWEap3VORNchRuyUJAEAx6zh4xGG9Kj5c6f8ZQ7xIg=; b=DUcAtzEAr/MyvzuRw5B4lu0/z2h4abV8JMYjfEDcm4gmWmBTRnVWsR3s3FAeeDcA9E aGJ99WBns4wKFQhKGF9Xo9YEn5Min2gc/Mjf2EluXxaSFQlm2SkSuLmv5wmhhq/kYPHo wRomDq9WPZcWxOTmqFPOMdcH7aYVvN6HROQZnitVjsQFXE9KX+kZoi9f8Sug9Nr85Rh/ hghAYOjKIHclCN4Ud9WfV2yhlR/csWxxKuBhmxJtI5cEP9wM5TgzU90PRP5HzQ9CLStF znOwNVLW65UhbxAOWiNWVqnTtzPTQ7AuQL/edq7kz0PjMXTkYg4XrGvKDgBFCVuKXyn/ JwrA== X-Gm-Message-State: AOAM531q1kO49yMyN3a8RWasY2nvtCuY1U831EeOTDcZcJK1HE925dp9 0qD2sFkqCZ8OEIMs1ULDvlKsn4mMZcD97Q== X-Google-Smtp-Source: ABdhPJz5YxYjFPT+rnSyL/0zxr7kbzTu4glFtTObfmfFeUdkBdZTkgT22woftK9kMmaAfBMQjGE1gQ== X-Received: by 2002:a05:6870:b390:b0:da:cf0c:17ae with SMTP id w16-20020a056870b39000b000dacf0c17aemr3389898oap.94.1647603508826; Fri, 18 Mar 2022 04:38:28 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id 25-20020a056870115900b000dda3a0cb91sm3351438oag.54.2022.03.18.04.38.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Mar 2022 04:38:28 -0700 (PDT) Message-ID: Date: Fri, 18 Mar 2022 08:38:28 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220317233019.12049-1-michael@niedermayer.cc> <20220317233019.12049-2-michael@niedermayer.cc> <74943f9e-b07a-7fe4-fa83-09a9cbda21a0@gmail.com> <20220318112758.GR2829255@pb2> From: James Almer In-Reply-To: <20220318112758.GR2829255@pb2> Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/wmalosslessdec: Check channel mask against num channels X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: CgpPbiAzLzE4LzIwMjIgODoyNyBBTSwgTWljaGFlbCBOaWVkZXJtYXllciB3cm90ZToKPiBPbiBU aHUsIE1hciAxNywgMjAyMiBhdCAxMDowMDoxOFBNIC0wMzAwLCBKYW1lcyBBbG1lciB3cm90ZToK Pj4KPj4KPj4gT24gMy8xNy8yMDIyIDk6MDcgUE0sIEphbWVzIEFsbWVyIHdyb3RlOgo+Pj4KPj4+ Cj4+PiBPbiAzLzE3LzIwMjIgODo1MiBQTSwgSmFtZXMgQWxtZXIgd3JvdGU6Cj4+Pj4gT24gMy8x Ny8yMDIyIDg6MzAgUE0sIE1pY2hhZWwgTmllZGVybWF5ZXIgd3JvdGU6Cj4+Pj4+IEZpeGVzOiBP dXQgb2YgYXJyYXkgd3JpdGUKPj4+Pj4gRml4ZXM6IDQ1NjEzL2NsdXN0ZXJmdXp6LXRlc3RjYXNl LW1pbmltaXplZC1mZm1wZWdfQVZfQ09ERUNfSURfV01BTE9TU0xFU1NfZnV6emVyLTQ1MzkwNzM2 MDYzMjAxMjgKPj4+Pj4KPj4+Pj4KPj4+Pj4gRm91bmQtYnk6IGNvbnRpbnVvdXMgZnV6emluZyBw cm9jZXNzCj4+Pj4+IGh0dHBzOi8vZ2l0aHViLmNvbS9nb29nbGUvb3NzLWZ1enovdHJlZS9tYXN0 ZXIvcHJvamVjdHMvZmZtcGVnCj4+Pj4+IFNpZ25lZC1vZmYtYnk6IE1pY2hhZWwgTmllZGVybWF5 ZXIgPG1pY2hhZWxAbmllZGVybWF5ZXIuY2M+Cj4+Pj4+IC0tLQo+Pj4+PiAgwqAgbGliYXZjb2Rl Yy93bWFsb3NzbGVzc2RlYy5jIHwgMyArKysKPj4+Pj4gIMKgIDEgZmlsZSBjaGFuZ2VkLCAzIGlu c2VydGlvbnMoKykKPj4+Pj4KPj4+Pj4gZGlmZiAtLWdpdCBhL2xpYmF2Y29kZWMvd21hbG9zc2xl c3NkZWMuYyBiL2xpYmF2Y29kZWMvd21hbG9zc2xlc3NkZWMuYwo+Pj4+PiBpbmRleCBjZDA1YjIy Njg5Li4xNzI4OTIwNzI5IDEwMDY0NAo+Pj4+PiAtLS0gYS9saWJhdmNvZGVjL3dtYWxvc3NsZXNz ZGVjLmMKPj4+Pj4gKysrIGIvbGliYXZjb2RlYy93bWFsb3NzbGVzc2RlYy5jCj4+Pj4+IEBAIC0y ODEsNiArMjgxLDkgQEAgc3RhdGljIGF2X2NvbGQgaW50Cj4+Pj4+IGRlY29kZV9pbml0KEFWQ29k ZWNDb250ZXh0ICphdmN0eCkKPj4+Pj4gIMKgwqDCoMKgwqAgYXZfY2hhbm5lbF9sYXlvdXRfdW5p bml0KCZhdmN0eC0+Y2hfbGF5b3V0KTsKPj4+Pj4gIMKgwqDCoMKgwqAgYXZfY2hhbm5lbF9sYXlv dXRfZnJvbV9tYXNrKCZhdmN0eC0+Y2hfbGF5b3V0LCBjaGFubmVsX21hc2spOwo+Pj4+PiArwqDC oMKgIGlmIChzLT5udW1fY2hhbm5lbHMgIT0gYXZjdHgtPmNoX2xheW91dC5uYl9jaGFubmVscykK Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiBBVkVSUk9SX1BBVENIV0VMQ09NRTsgLy9hcmUg dGhlcmUgbm9uIGZ1enplZAo+Pj4+PiBmaWxlcyB3aXRoIHRoaXMgb3IgaXMgaXQgYW4gZXJyb3Ig Pwo+Pj4+Cj4+Pj4gcy0+bnVtX2NoYW5uZWxzIGF0IHRoaXMgcG9pbnQgaXMgc2V0IHRvIHRoZSBj aGFubmVscyBjb3VudCB0aGUgdXNlcgo+Pj4+IHNldCBiZWZvcmUgY2FsbGluZyBhdmNvZGVjX29w ZW4yKCkgKE5vcm1hbGx5IGZyb20gbGF2ZiksIGJ1dCBpdAo+Pj4+IGNvdWxkIGJlIGFueXRoaW5n Lgo+Pj4+IElmIGNoYW5uZWxfbWFzayBpcyB0YWtlbiBmcm9tIGV4dHJhZGF0YSwgbWF5YmUgaXQg c2hvdWxkIGJlIHVzZWQgdG8KPj4+PiBzZXQgcy0+bnVtX2NoYW5uZWxzIGluc3RlYWQgb2YgYWJv cnRpbmcgYmVjYXVzZSB0aGUgdXNlciBzZXQgdmFsdWUKPj4+PiBhbmQgZXh0cmFkYXRhIGRpc2Fn cmVlZC4KPj4+Pgo+Pj4+IEFsc28sIGNhbiB5b3UgcmVwcm9kdWNlIHRoaXMgY3Jhc2ggYmVmb3Jl IDNjOTMzYWY0OTM/Cj4+Pj4gcy0+bnVtX2NoYW5uZWxzIHdhcyBiZWluZyBzZXQgdG8gdGhlIHVz ZXIgc2V0IGNoYW5uZWwgY291bnQgdG9vLAo+Pj4+IHNhbWUgYXMgbm93Lgo+Pj4KPj4+IFJpZ2h0 LCBiZWZvcmUgdGhhdCBjb21taXQgcy0+bnVtX2NoYW5uZWxzIGFuZCBhdmN0eC0+Y2hhbm5lbHMg d2VyZQo+Pj4gYWx3YXlzIHRoZSBzYW1lLCBidXQgYXZjdHgtPmNoYW5uZWxfbGF5b3V0IHdhcyB3 aGF0ZXZlciBjYW1lIGZyb20KPj4+IGV4dHJhZGF0YSwgYW5kIGl0cyBwb3BjbnQgY291bGQgYmUg IT0gYXZjdHgtPmNoYW5uZWxzLgo+Pj4gQWZ0ZXIgaXQsIGF2Y3R4LT5jaF9sYXlvdXQubmJfY2hh bm5lbHMgaXMgYWx3YXlzIHRoZSBzYW1lIGFzCj4+PiBwb3BjbnQoYXZjdHgtPmNoX2xheW91dC51 Lm1hc2spLCB3aGljaCBjYW4gYmUgZGlmZmVyZW50IHRoYW4KPj4+IHMtPm51bV9jaGFubmVscy4K Pj4+Cj4+PiBJIHRoaW5rIG15IHN1Z2dlc3Rpb24gYWJvdmUgdG8gdXNlIHRoZSBleHRyYWRhdGEg Y2hhbm5lbCBtYXNrIGFuZAo+Pj4gaWdub3JpbmcgdGhlIHVzZXIgc2V0IGNoYW5uZWwgY291bnQg aXMgdGhlIGJlc3QgYXBwcm9hY2ggZm9yIHRoaXMuCj4+Cj4+IExpa2UgdGhpcyBtYXliZSAoY2hh bm5lbF9tYXNrIGNvdWxkIGluIHRoZW9yeSBiZSB6ZXJvLCBzbyBpbiB0aGF0IGNhc2UgdGhlCj4+ IHVzZXIgc2V0IHZhbHVlIHNob3VsZCBiZSB1c2VkKS4KPj4KPj4+IGRpZmYgLS1naXQgYS9saWJh dmNvZGVjL3dtYWxvc3NsZXNzZGVjLmMgYi9saWJhdmNvZGVjL3dtYWxvc3NsZXNzZGVjLmMKPj4+ IGluZGV4IGNkMDViMjI2ODkuLjkxNWFkZDE5NjIgMTAwNjQ0Cj4+PiAtLS0gYS9saWJhdmNvZGVj L3dtYWxvc3NsZXNzZGVjLmMKPj4+ICsrKyBiL2xpYmF2Y29kZWMvd21hbG9zc2xlc3NkZWMuYwo+ Pj4gQEAgLTE5NywxNSArMTk3LDYgQEAgc3RhdGljIGF2X2NvbGQgaW50IGRlY29kZV9pbml0KEFW Q29kZWNDb250ZXh0ICphdmN0eCkKPj4+ICAgICAgICAgICByZXR1cm4gQVZFUlJPUl9QQVRDSFdF TENPTUU7Cj4+PiAgICAgICB9Cj4+Pgo+Pj4gLSAgICBzLT5tYXhfZnJhbWVfc2l6ZSA9IE1BWF9G UkFNRVNJWkUgKiBhdmN0eC0+Y2hfbGF5b3V0Lm5iX2NoYW5uZWxzOwo+Pj4gLSAgICBzLT5mcmFt ZV9kYXRhID0gYXZfbWFsbG9jeihzLT5tYXhfZnJhbWVfc2l6ZSArIEFWX0lOUFVUX0JVRkZFUl9Q QURESU5HX1NJWkUpOwo+Pj4gLSAgICBpZiAoIXMtPmZyYW1lX2RhdGEpCj4+PiAtICAgICAgICBy ZXR1cm4gQVZFUlJPUihFTk9NRU0pOwo+Pj4gLQo+Pj4gLSAgICBzLT5hdmN0eCA9IGF2Y3R4Owo+ Pj4gLSAgICBmZl9sbGF1ZGRzcF9pbml0KCZzLT5kc3ApOwo+Pj4gLSAgICBpbml0X3B1dF9iaXRz KCZzLT5wYiwgcy0+ZnJhbWVfZGF0YSwgcy0+bWF4X2ZyYW1lX3NpemUpOwo+Pj4gLQo+Pj4gICAg ICAgaWYgKGF2Y3R4LT5leHRyYWRhdGFfc2l6ZSA+PSAxOCkgewo+Pj4gICAgICAgICAgIHMtPmRl Y29kZV9mbGFncyAgICA9IEFWX1JMMTYoZWRhdGFfcHRyICsgMTQpOwo+Pj4gICAgICAgICAgIGNo YW5uZWxfbWFzayAgICAgICA9IEFWX1JMMzIoZWRhdGFfcHRyICsgIDIpOwo+Pj4gQEAgLTIzMCw2 ICsyMjEsMzMgQEAgc3RhdGljIGF2X2NvbGQgaW50IGRlY29kZV9pbml0KEFWQ29kZWNDb250ZXh0 ICphdmN0eCkKPj4+ICAgICAgICAgICByZXR1cm4gQVZFUlJPUl9QQVRDSFdFTENPTUU7Cj4+PiAg ICAgICB9Cj4+Pgo+Pj4gKyAgICBpZiAoY2hhbm5lbF9tYXNrKSB7Cj4+PiArICAgICAgICBhdl9j aGFubmVsX2xheW91dF91bmluaXQoJmF2Y3R4LT5jaF9sYXlvdXQpOwo+Pj4gKyAgICAgICAgYXZf Y2hhbm5lbF9sYXlvdXRfZnJvbV9tYXNrKCZhdmN0eC0+Y2hfbGF5b3V0LCBjaGFubmVsX21hc2sp Owo+Pj4gKyAgICB9IGVsc2UKPj4+ICsgICAgICAgIGF2Y3R4LT5jaF9sYXlvdXQub3JkZXIgPSBB Vl9DSEFOTkVMX09SREVSX1VOU1BFQzsKPj4+ICsKPj4+ICsgICAgcy0+bnVtX2NoYW5uZWxzID0g YXZjdHgtPmNoX2xheW91dC5uYl9jaGFubmVsczsKPj4+ICsKPj4+ICsgICAgLyogZXh0cmFjdCBs ZmUgY2hhbm5lbCBwb3NpdGlvbiAqLwo+Pj4gKyAgICBzLT5sZmVfY2hhbm5lbCA9IC0xOwo+Pj4g Kwo+Pj4gKyAgICBpZiAoY2hhbm5lbF9tYXNrICYgOCkgewo+Pj4gKyAgICAgICAgdW5zaWduZWQg aW50IG1hc2s7Cj4+PiArICAgICAgICBmb3IgKG1hc2sgPSAxOyBtYXNrIDwgMTY7IG1hc2sgPDw9 IDEpCj4+PiArICAgICAgICAgICAgaWYgKGNoYW5uZWxfbWFzayAmIG1hc2spCj4+PiArICAgICAg ICAgICAgICAgICsrcy0+bGZlX2NoYW5uZWw7Cj4+PiArICAgIH0KPj4+ICsKPj4+ICsgICAgcy0+ bWF4X2ZyYW1lX3NpemUgPSBNQVhfRlJBTUVTSVpFICogYXZjdHgtPmNoX2xheW91dC5uYl9jaGFu bmVsczsKPj4+ICsgICAgcy0+ZnJhbWVfZGF0YSA9IGF2X21hbGxvY3oocy0+bWF4X2ZyYW1lX3Np emUgKyBBVl9JTlBVVF9CVUZGRVJfUEFERElOR19TSVpFKTsKPj4+ICsgICAgaWYgKCFzLT5mcmFt ZV9kYXRhKQo+Pj4gKyAgICAgICAgcmV0dXJuIEFWRVJST1IoRU5PTUVNKTsKPj4+ICsKPj4+ICsg ICAgcy0+YXZjdHggPSBhdmN0eDsKPj4+ICsgICAgZmZfbGxhdWRkc3BfaW5pdCgmcy0+ZHNwKTsK Pj4+ICsgICAgaW5pdF9wdXRfYml0cygmcy0+cGIsIHMtPmZyYW1lX2RhdGEsIHMtPm1heF9mcmFt ZV9zaXplKTsKPj4+ICsKPj4+ICAgICAgIC8qIGdlbmVyaWMgaW5pdCAqLwo+Pj4gICAgICAgcy0+ bG9nMl9mcmFtZV9zaXplID0gYXZfbG9nMihhdmN0eC0+YmxvY2tfYWxpZ24pICsgNDsKPj4+Cj4+ PiBAQCAtMjYzLDI0ICsyODEsMTAgQEAgc3RhdGljIGF2X2NvbGQgaW50IGRlY29kZV9pbml0KEFW Q29kZWNDb250ZXh0ICphdmN0eCkKPj4+ICAgICAgICAgICByZXR1cm4gQVZFUlJPUl9JTlZBTElE REFUQTsKPj4+ICAgICAgIH0KPj4+Cj4+PiAtICAgIHMtPm51bV9jaGFubmVscyA9IGF2Y3R4LT5j aF9sYXlvdXQubmJfY2hhbm5lbHM7Cj4+PiAtCj4+PiAtICAgIC8qIGV4dHJhY3QgbGZlIGNoYW5u ZWwgcG9zaXRpb24gKi8KPj4+IC0gICAgcy0+bGZlX2NoYW5uZWwgPSAtMTsKPj4+IC0KPj4+IC0g ICAgaWYgKGNoYW5uZWxfbWFzayAmIDgpIHsKPj4+IC0gICAgICAgIHVuc2lnbmVkIGludCBtYXNr Owo+Pj4gLSAgICAgICAgZm9yIChtYXNrID0gMTsgbWFzayA8IDE2OyBtYXNrIDw8PSAxKQo+Pj4g LSAgICAgICAgICAgIGlmIChjaGFubmVsX21hc2sgJiBtYXNrKQo+Pj4gLSAgICAgICAgICAgICAg ICArK3MtPmxmZV9jaGFubmVsOwo+Pj4gLSAgICB9Cj4+PiAtCj4+PiAgICAgICBzLT5mcmFtZSA9 IGF2X2ZyYW1lX2FsbG9jKCk7Cj4+PiAgICAgICBpZiAoIXMtPmZyYW1lKQo+Pj4gICAgICAgICAg IHJldHVybiBBVkVSUk9SKEVOT01FTSk7Cj4+Pgo+Pj4gLSAgICBhdl9jaGFubmVsX2xheW91dF91 bmluaXQoJmF2Y3R4LT5jaF9sYXlvdXQpOwo+Pj4gLSAgICBhdl9jaGFubmVsX2xheW91dF9mcm9t X21hc2soJmF2Y3R4LT5jaF9sYXlvdXQsIGNoYW5uZWxfbWFzayk7Cj4+PiAgICAgICByZXR1cm4g MDsKPj4+ICAgfQo+IAo+IHRoaXMgd2lsbCBjaGFuZ2UgdGhlIG91dHB1dCBvZiB0aGUgImxvc3Ns ZXNzIiBkZWNvZGVyIGlmIHRoaXMgY2FzZSBldmVyCj4gb2NjdXJzIGJlc2lkZXMgdGhpcwoKQXMg aSBpbnRlcnByZXQgaXQsIHlvdSBjb3VsZCBpbml0aWFsaXplIHRoZSBkZWNvZGVyIHVzaW5nIGFu eSBhcmJpdHJhcnkgCm51bWJlciBvZiBjaGFubmVscyBpbiBhdmN0eC4gQW5kIGlmIGNoYW5uZWxf bWFzayBpbiBleHRyYWRhdGEgaXMgbm90IAp6ZXJvLCB0aGVuIGl0IG11c3QgYmUgY29uc2lkZXJl ZCB0byBiZSB0aGUgdmFsaWQgY2hhbm5lbCBjb3VudCBmb3IgdGhlIApzdHJlYW0sIGFuZCB0aGUg dmFsdWUgcGFzc2VkIGluIGF2Y3R4IHNob3VsZCBiZSBpZ25vcmVkLgoKPiAKPiBMR1RNCj4gCj4g dGh4CgpXaWxsIGFwcGx5LgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpmZm1wZWctZGV2ZWwgbWFpbGluZyBsaXN0CmZmbXBlZy1kZXZlbEBmZm1wZWcub3Jn Cmh0dHBzOi8vZmZtcGVnLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZmbXBlZy1kZXZlbAoKVG8gdW5z dWJzY3JpYmUsIHZpc2l0IGxpbmsgYWJvdmUsIG9yIGVtYWlsCmZmbXBlZy1kZXZlbC1yZXF1ZXN0 QGZmbXBlZy5vcmcgd2l0aCBzdWJqZWN0ICJ1bnN1YnNjcmliZSIuCg==