From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 766934436F for ; Tue, 6 Sep 2022 13:45:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 84F3A68BB50; Tue, 6 Sep 2022 16:45:28 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 63FC368BB35 for ; Tue, 6 Sep 2022 16:45:22 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 286DjLje026993-286DjLjf026993 for ; Tue, 6 Sep 2022 16:45:21 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 3B8D0A1407 for ; Tue, 6 Sep 2022 16:45:20 +0300 (EEST) Date: Tue, 6 Sep 2022 16:45:19 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: References: MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 1/2] x86/tx_float: add support for calling assembly functions from assembly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 6 Sep 2022, Mattias Wadman wrote: > On Sat, Sep 3, 2022 at 3:41 AM Lynne wrote: > >> Needed for the next patch. >> We get this for the extremely small cost of a branch on _ns functions, >> which wouldn't be used anyway with assembly. >> >> Patch attached. >> > > Hi, I have issues building on macOS (12.5.1) with this patch. Maybe I'm > missing something? old nasm version? That patch needed manually adding the symbol prefix in a few places, for platforms that do use symbol prefixes. See the patch that I just posted, which should fix this. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".