From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D75454CAF3 for ; Tue, 27 May 2025 13:19:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 47E3F68D74C; Tue, 27 May 2025 16:19:08 +0300 (EEST) Received: from btbn.de (btbn.de [144.76.60.213]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1A6E868C6C8 for ; Tue, 27 May 2025 16:19:02 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 8A26E2819FCDF for ; Tue, 27 May 2025 15:18:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1748351939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r7tYlEwxb/5TSxbvzqVjflymGfYA0291LobQKFKxtYc=; b=kV6CzPmm0OuUZga70cYOG4r+qSu0y+gb/+YB+Miwj2s+zP7x9jojqAfbwhNBOnkosD7JNG cM0QlBDGRAg9AwyzLP3Ws+HEnhlAxJ+bG1IC/bGMZhGjfyC5ZP+B/D/EP9IjSmlUQEaA8Q 5KRz266e/XLyyh+i9LH66En30UpNa6Yq21oxBc4lFOvjj7UoelwjfpeP6rW67NGQmBLs8R hvLQ1Nb2x6K/kd/JhAL0H0TqDXpanFbkICxdSi5gZ3NtFEiD4zht0ZCkFWPixKZmAw8yn+ sGB46n8DhZ35ReSy5M65CwErwwYHXso6kf4pzHFl78b03VV0o/YqnPFMBkwNow== Message-ID: Date: Tue, 27 May 2025 15:18:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250527013328.308477-1-ramiro.polla@gmail.com> Content-Language: en-US From: Timo Rothenpieler In-Reply-To: <20250527013328.308477-1-ramiro.polla@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 1/5] configure: remove build-time check for gzip support in zlib X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 27.05.2025 03:33, Ramiro Polla wrote: > We currently test at build-time whether zlib supports decoding gzip. > This is not needed for the build to succeed, since only the gzip > command is necessary to perform compression at build-time. > > Presumably this check will help the user by not enabling compression at > build-time if their system won't be able to decompress at runtime. > > But there are no guarantees that the system where the build is made is > the same system where it will run. The build system could support gzip > in zlib, but not the system at runtime, or the other way around. > > Realistically, the chances of there being a system where zlib does not > support gzip are very slim. It is safe to assume that zlib will support > gzip. > > This commit changes the dependency for support of compressed resources > and ptx files to normal zlib support, and the existence of the gzip > command. > --- > configure | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/configure b/configure > index 3730b0524c..79c4fcf327 100755 > --- a/configure > +++ b/configure > @@ -2548,7 +2548,6 @@ HAVE_LIST=" > posix_ioctl > texi2html > xmllint > - zlib_gzip > openvino2 > " > > @@ -6895,19 +6894,11 @@ enabled zlib && { check_pkg_config zlib zlib "zlib.h" zlibVersion || > enabled bzlib && check_lib bzlib bzlib.h BZ2_bzlibVersion -lbz2 > enabled lzma && check_lib lzma lzma.h lzma_version_number -llzma > > -enabled zlib && test_exec $zlib_extralibs < -#include > -int main(void) { > - if (zlibCompileFlags() & (1 << 17)) return 1; > - return 0; > -} > -EOF > - > [ -x "$(command -v gzip)" ] && enable gzip > > -enabled zlib_gzip && enabled gzip || disable ptx_compression > +enabled zlib && enabled gzip || disable ptx_compression > > -enabled zlib_gzip && enabled gzip || disable resource_compression > +enabled zlib && enabled gzip || disable resource_compression > > # On some systems dynamic loading requires no extra linker flags > check_lib libdl dlfcn.h "dlopen dlsym" || check_lib libdl dlfcn.h "dlopen dlsym" -ldl I don't see why this should be removed. It does not hurt in any way, and can prevent bad surprises for people building in odd environments where zlib for some reason does not support this. Chances are high that if the build env doesn't support it, neither will the intended runtime env. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".