From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0DAA044F1F for ; Mon, 9 Jan 2023 10:41:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 26C5568BCA6; Mon, 9 Jan 2023 12:41:22 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2107.outbound.protection.outlook.com [40.107.22.107]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9C76268B883 for ; Mon, 9 Jan 2023 12:41:15 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LqyuFeEYvw2H+8Bac0gqyKQQmTiV8GEaSkR2uKOjzmYtk2naed9/nBCXwlCfDlIp97EVyib9k0Pl4DiXuyuqNCi/u5xjjAz6cbVJr6sttuQznD/bw4W1VyvutCb7yEqeB1FAY6Z7nM1tcRWSxszm+SvIoHU2nCYWn9tw10mt9FdVmphxOWwIKIc6zbXEvMfqkpF3bC/SPuJyk4OSEXEYYkWSoZGAzV72/6pGsV7LFDRvfNG60BEwcTCpWSUlaP5EqT/OTB+KZCzCoyZuIvid2n4hF55MS6wdb+fv7aQGmJ6V1jKu30vre/8IEwnHr2BY8lh4n6iLMiNPBg86FCeBNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oE9P80UY7sW3b7AvEPz03Si4IPL2wlQoWMqei/qVqkc=; b=VOFoGJBE9hqibpaxJpBniRjFcJ44OpcGvW298Q2eAmul1O9X+WGhOqoim0+HvQiGUYXwhfy2z848bD1a+q3It9z2Wi/tuW5pN188GOW34wmA1HrT5Eh2lkQGxk++iemj/ZUshTPdRXWOgfxjLFRCH3Juet7lMNoQnjEMMMG/Y58LJ1OgtGdOW1NRsfIaph1PJExPnKz1MhMrfWcnFodxifOy6rGZp3q28TTRXOzbIL/vaUJ/WoAGVWCofWaln3XJBmcu8Ji4BGYHEN9QIdVBARB+VfVk1+wHAZ5qhkqSB7qTqY+bK7nFf1Gplv1XaYKNzujDskNGcvoXjBd0LClFCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=noa-archive.com; dmarc=pass action=none header.from=noa-archive.com; dkim=pass header.d=noa-archive.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=noa-archive.com; Received: from DB4PR09MB5847.eurprd09.prod.outlook.com (2603:10a6:10:38d::8) by AS8PR09MB4776.eurprd09.prod.outlook.com (2603:10a6:20b:297::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 10:41:13 +0000 Received: from DB4PR09MB5847.eurprd09.prod.outlook.com ([fe80::520c:6bd4:410d:a2bc]) by DB4PR09MB5847.eurprd09.prod.outlook.com ([fe80::520c:6bd4:410d:a2bc%8]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 10:41:13 +0000 Message-ID: Date: Mon, 9 Jan 2023 11:41:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230105205342.GE4028235@pb2> <20230106172506.GG4028235@pb2> <20230108144532.GC35806@pb2> From: Tobias Rapp In-Reply-To: <20230108144532.GC35806@pb2> X-ClientProxiedBy: FR2P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::9) To DB4PR09MB5847.eurprd09.prod.outlook.com (2603:10a6:10:38d::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB4PR09MB5847:EE_|AS8PR09MB4776:EE_ X-MS-Office365-Filtering-Correlation-Id: b504470c-b15d-42b1-6b12-08daf22e077f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kkBwjO9/a7473PHDUwg6yNF7cyx3BtksB9TyZ4ZbU8KzbdEnLIk1+cbYW9pf2j/JAdYXZ1EMoCmocueVIS0mN+P0POn+VZ2m+0+1tcaWylyvWot0tSVeKANKtjUdb7MuzplUCj4G6tDvVGb8T+IfxB+SGvophibHH8hQyM0D9LMf7fcz6YIvKpfvm5iS+hERGGSI6bCe0XOA2Ju1RoMqYMIKEAU6nnj3SeoYg1auEC5ivaMCHRpxpAbFvKdDYtbtLUd6X6C3nQRY9R4kX+t6WL2ITH3yKwFQmjVyITu6QK/SH6R1yCNVnPewaO+PVMntLXTLrq6JE4/DRi1PwGl5zURJWTER0YbKqPG9oOCYgbezvWgKTiI4yn2CaEUEUDBTwxC5wYvANCRf5yLsI0L7gv8hHUeVACmTHjFzD2C1q0g0XfJjA9g6xxjjHPsCzG0PUSVYbUTElaXpBli0kO3eN+oD4f08VYJ4ldME46rPTt3ExAydVGvFs3wyfD0js4wv0rU9NEOQCi22XGCSxOqBBzurUzyKZuWXHl/aeWUjYvgWs+zY8r7F65tCaD7ipqzk4h5QEYbg8LTSKut4rc3W0Xu4g9QWvdJc2pxN4xn+Zaa6Yxc9UehsY0CO4+J42GDpCM87TJSPhsfyuxCG5HnACfaOr9nwD/3wLNFSFm8mQIJMtv/g/ObnA6eANABXCK9Ajq9pjZEIVKci7UUZBXPsrT4KErYu+y4K+40Kj+c9RRAhJrD2MamESXuHtHRs/BJi X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB4PR09MB5847.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(396003)(366004)(136003)(376002)(39830400003)(451199015)(36756003)(8936002)(5660300002)(2906002)(66574015)(41300700001)(316002)(66556008)(66476007)(66946007)(8676002)(6916009)(186003)(6512007)(2616005)(38100700002)(26005)(31686004)(83380400001)(31696002)(86362001)(478600001)(966005)(6506007)(53546011)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEZFajQzRGhxeEIwRzkvWUtaa2tZUnZoV0NmMnA0REVjRWlPUnpKMkVHcC9O?= =?utf-8?B?SXB2UUdOeTdwVEFrTUVOcnJabFNqOU1VU2xIalhBSjhrOGZFRU5sQjhKaStZ?= =?utf-8?B?ZzY5a25jbnhUWDlYcEFQTzlKNWpKU2tLWkQwVG5TeTdvT2FHS1Y4Rlhwc1VH?= =?utf-8?B?TFMwM3h5ZDRHeDlDTXQ3eWhYVDI5VnZkZUlCQkg5K2FFK3BRZHZYUURnTUNq?= =?utf-8?B?QStzT3lHWk0wc2VVSFlQL25UUmtjY3JiTFBzS1N4bUNQQjAxVEJDQlpsaEtY?= =?utf-8?B?OUhxamoyWUFvRndjMEVLZGx4S0hKVjNmQis1VWxyYzVzYkVXVFprclYxV1V3?= =?utf-8?B?ZVRHN0p1bGpnc0k3QVcra2ZtcXIvMCtFUWc2cDVXaldoK0ZJbkNjWnlFNlQw?= =?utf-8?B?aFFucE00WDVhcytFVmJoR0p2dGNEa3JlMVYyQkJjaGh6UFM0NTMyWFViVFZB?= =?utf-8?B?ekVYWHFJUFBmclpleDFXQ2ZkNFE1MEpTcmJ1K1RHNWJsQ1JqUjYwd002TFFX?= =?utf-8?B?bXBQNnllb1ZOLytJbm1jYmhOL3RUTjBtdlNqOEo5M1ljOEJKNFU4Q09sZk5N?= =?utf-8?B?WjdOMzcvTm1XZ1BCSTdxT2prck5xL25uTUFjeVBTSXFVMkVPYnRVdkxyMWpq?= =?utf-8?B?cW5rK2p1aXA1U3dUeG9TRVhkeXI4VlA2YjBuYVROaktkVjd1VXQ1RW1kZVVp?= =?utf-8?B?VmFXMnVVbFZWQ2lKZGhGdHpiWlpPYThVNWozWGVOWExlTlUwUHRYakpUU0NP?= =?utf-8?B?QVRFbVRiYVJUZ0ExQm5SZWNmNTNNa3lXcG5veWNOdFJuR0l2ZlVWWEVEMXlJ?= =?utf-8?B?d0x2OXpOdnJITzdUUkxzeUx5NGkvOGRwemNSYTBpMlladHdVRmtGQ1grdXda?= =?utf-8?B?elBtZzJEQm9EUUlVWDZHdzFMQWowMUlxc216ekRoTHV5bmFMZHhOYTBvOFZI?= =?utf-8?B?MGVXb3Z1Rk1yYUpqTVNtNHRzWnFxWHcxNnZiVnZaRWtLamd4anF3SlRDcnVx?= =?utf-8?B?ZGFTQlJDcC8xTUh3WE40VXpjNmRnTXpYS1pKUDRzNGFIRlBJRlRRUVF5NDJw?= =?utf-8?B?ZWFrdzlQUHY2ZUtuL1VXcllGMURnL21NUDZWaEtIZmVaWXRDWndtWDZtbGMw?= =?utf-8?B?dllGdk1KN1h2cStTM05mZDB0WGh4SnNWU2VTUS95Q2F3dHFXUFF6TmFYS3pJ?= =?utf-8?B?Y2lrbXAxT0grSXVCcDVkR1VoRzlZL2dHM3kzbzJHalhRbSsxeWE4T1FNMW0x?= =?utf-8?B?SC9CcW8yZGxnWjhHeEcwdnRIUUdBMEdFRktIU3lpanlJaGM3L2NBNHFuSHky?= =?utf-8?B?cUZHaGJabVl1QjZmWk9hK3ovZklNUjlDM0RreUlqV1VMUEdXOW5MSmJ4MUFi?= =?utf-8?B?emZsanlDQUtyQ1ZkWjc2ZEx6OUhUNXp6MXZEdHZGdDd4UUlJNVR5cCt3NVdr?= =?utf-8?B?TUpibHRyVXVmZ29HcGl1VU1sWGdCOHFZL0JLZjYvSTRWUUdRQ1VFWWVrZnlq?= =?utf-8?B?SVFJbVl4N3lxc1VHVjNsNiszcnRlcW1jTVh6NnlsL3d4OCtTUXNjVFQ4Vk5i?= =?utf-8?B?Mk1iYmJEUnUyN2gvN3JzbGg4WnNuWUFzMERqNHpMaWFaOEtGMUJjbm85NHli?= =?utf-8?B?eE50VEFhZGR4dEZ5bXFPcHptL1N3ckVPQkYzMGVaZDdiSXhPaUV2cmdxSnFY?= =?utf-8?B?OVBRMnV2Lzh2OGRCU2JlT3YyT1Z1RFA4NGJXUjRDY1BjRElxYThZcVN3ZmVv?= =?utf-8?B?cVJHTVFFWENSNDlzbDhHU0JKQ0FDajFCMW5LSW81bTJKclJmb3JzMy9KeWNh?= =?utf-8?B?SUJXOXNiRnBFazR0bldJbFJIZ0NaOXBFTFl2ZitrdEs2NER3bFRuWW1sTmpZ?= =?utf-8?B?a20weG41dnRQL0NiRHd5VWQvNnBPZURkYXNaUzBvU2RpQ1Q0MGpScHhvZ29i?= =?utf-8?B?OFlwL0tFTlNDZzVQMVMrYVIwcVVwUXBRc2IyK2E5N1hUMjRsb1h3bEFtZTZs?= =?utf-8?B?ekJDYlpIM1llTEI5ckFyZUhZczgvYU9Nb2VFaWwxRGc1U0ExNUZmak1OaFJK?= =?utf-8?B?UVZBalk1OE16MW5ieFhvOE5ubjlIMDNadDRBeGJKNWh4elVPZUN6N2VkMHFj?= =?utf-8?B?RXpxazFVdFBla0lKeXFObkxvWG5PQVE2ejk4ZWtlVDNVc2xFdVhQc1N0b2NI?= =?utf-8?B?Vmc9PQ==?= X-OriginatorOrg: noa-archive.com X-MS-Exchange-CrossTenant-Network-Message-Id: b504470c-b15d-42b1-6b12-08daf22e077f X-MS-Exchange-CrossTenant-AuthSource: DB4PR09MB5847.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 10:41:13.5960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a676c8d7-7f39-4c99-a306-48abb76a98e9 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TXMvaRPZBQsk9BrPBZX6ztFFfmeo3oo/5vxTpA9q5REIhPiyXKAYlkTtL80xrJnZU6+Wbx9NEUAdCcdlLR6V5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR09MB4776 Subject: Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 08/01/2023 15:45, Michael Niedermayer wrote: > On Fri, Jan 06, 2023 at 07:01:06PM +0100, Paul B Mahol wrote: >> On Fri, Jan 6, 2023 at 6:25 PM Michael Niedermayer >> wrote: >> >>> On Thu, Jan 05, 2023 at 11:08:25PM +0100, Paul B Mahol wrote: >>>> On Thu, Jan 5, 2023 at 9:53 PM Michael Niedermayer < >>> michael@niedermayer.cc> >>>> wrote: >>>> >>>>> On Thu, Jan 05, 2023 at 01:44:10PM +0100, Paul B Mahol wrote: >>>>>> Patch attached. >>>>>> swresample.c | 3 ++- >>>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>>> eee7a0685b44aa867562138a2e2437ecb8844612 >>>>> 0001-libswresample-swresample-avoid-s16p-internal-transfe.patch >>>>>> From 9c4cd60e2dd41cf98d693c8251f4cfade0807073 Mon Sep 17 00:00:00 >>> 2001 >>>>>> From: Paul B Mahol >>>>>> Date: Thu, 5 Jan 2023 13:40:12 +0100 >>>>>> Subject: [PATCH] libswresample/swresample: avoid s16p internal >>> transfer >>>>> format >>>>>> Instead use float one by default for sample rate conversions. >>>>>> The s16p internal transfer format produces visible and hearable >>>>>> quantization artifacts. >>>>> When does this occur and why? >>>>> >>>> It occurs always. Just compare output with 16bit and int32/float/double. >>>> Look at other people report on internet. >>>> Look at src.infinitewave.ca >>> src.infinitewave.ca uses 32bit none of what it shows should touch the >>> codepath >>> you change. >>> >>> if we look at src.infinitewave.ca for swr we see 2 types of artifacts >>> 1. Aliassing which is at maybe -120db with the actual signal at 0db >>> i would like to see some evidence that a human can hear this >>> >> For s16p<->s16p it is much lower, around -78dB thus this patch. > ok but you pointed to the website that apparently uses >=32bit if i trust > what they write. > And even if they test this i cannot use that website to replicate the issue > and the fix > > I just wanted to know how i can test this. You are testing it too ... > so i can see what you see > Id like to make sure this is the correct fix for the problem and > Id like to make sure its used when it makes sense and not when not. IIRC a similar sweep graph can be created with "Spek" from http://spek.cc/ but haven't used that application for a while. The SRC comparison website apparently provides the input files for testing, see the instructions at http://src.infinitewave.ca/faq.html. Regards, Tobias _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".