From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3846D40893 for ; Tue, 1 Feb 2022 11:32:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 26CEB68B26A; Tue, 1 Feb 2022 13:32:41 +0200 (EET) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34A3068B06F for ; Tue, 1 Feb 2022 13:32:33 +0200 (EET) Received: by mail-ot1-f43.google.com with SMTP id j38-20020a9d1926000000b0059fa6de6c71so15868803ota.10 for ; Tue, 01 Feb 2022 03:32:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=ROMc7OdedzO1vLHqNrUBq9PaaLO4755qGOgXKMGHhhM=; b=X/nIh31tv4tclv/bmLHvyxHbHGRWSK/TYe+N5IFfYFmC22NwIVrT9BtBgI6qWSYF4s evK/LOcqqQ8JVSfAf1yCscAtR6bx95pZt3geCwG//5tem77LFWfFqKXr84HXSaNG5fHE P3hRNsI/DhMW+uYi+AWIy5nCVTwUdafRtedN0I1Vhx3nearrNaqTesLjqDxqff/vbHHU UPwo5+OavWWPiUH/fyDfyl1Wbf+NGAT6OFTFQk9/J6dxXFV/q4F+Z7J8IyJnTDa/VT3W 6AprHAYFUIq3v+BJxv69pMYy2SkIz2cKn4mYj6pjslAT285fT37HMRYG2zikGW4pv+qW 3SQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ROMc7OdedzO1vLHqNrUBq9PaaLO4755qGOgXKMGHhhM=; b=iXQOENR5IViOFs0zs5u2YcztaldE6YRCCxCZEhEDXoSD0zvQS2tDIiwIJtSE8oZM8r Kt7VkYZgBviKijhIvZ/q4qT8kUxFH9aWDNVllTn62eKXXDXutSaJj8axdj/qCJPSzBRc K6AQqg1uDzObAD9etLrVe91aY0moT3YuBIoqPL5m6rXOP3xDxomxMDKadyffaqCcjloY sff77M5OVfygINMScwrw7Kc4aYosINW1CdqUndZNzMSJs+eF+JUsfyaL0/AqCbVVcWKq sCzWfHr3o99Wbfy9+4/1PcwiziCGIvcdRs/WNApzRl7HelE2BUnQUAtMRt/QqQWmr09y ZSyQ== X-Gm-Message-State: AOAM531Z2BCFRjmJdiBGqinNrrTUdfGC9mN65yPGALpH7hcQ1XyrJRSk GOW1xE/PwFlx8UbI88DYNTKQxWyoTAM= X-Google-Smtp-Source: ABdhPJx9ioXI9m39tfz48rhASRtouW4a8kjLU4DoIl8aeaYLN9v6S/2gYaxUoNL8xma/nzQZ3u7q2Q== X-Received: by 2002:a9d:c44:: with SMTP id 62mr1766135otr.226.1643715150915; Tue, 01 Feb 2022 03:32:30 -0800 (PST) Received: from [192.168.0.10] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id j11sm16924592otj.30.2022.02.01.03.32.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Feb 2022 03:32:30 -0800 (PST) Message-ID: Date: Tue, 1 Feb 2022 08:32:28 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220201100227.18928-1-anton@khirnov.net> <20220201100227.18928-4-anton@khirnov.net> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 4/4] lavc: deprecate FF_IDCT_NONE X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/1/2022 8:16 AM, Lynne wrote: > 1 Feb 2022, 11:02 by anton@khirnov.net: > >> It was only used by XvMC. >> --- >> libavcodec/avcodec.h | 5 ++++- >> libavcodec/idctdsp.c | 1 - >> libavcodec/version.h | 1 + >> 3 files changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >> index acb7ae0e14..5362446092 100644 >> --- a/libavcodec/avcodec.h >> +++ b/libavcodec/avcodec.h >> @@ -1407,7 +1407,10 @@ typedef struct AVCodecContext { >> #define FF_IDCT_SIMPLEARMV6 17 >> #define FF_IDCT_FAAN 20 >> #define FF_IDCT_SIMPLENEON 22 >> -#define FF_IDCT_NONE 24 /* Used by XvMC to extract IDCT coefficients with FF_IDCT_PERM_NONE */ >> +#if FF_API_IDCT_NONE >> +// formerly used by xvmc >> +#define FF_IDCT_NONE 24 >> +#endif >> #define FF_IDCT_SIMPLEAUTO 128 >> > > Isn't this a private define that clients weren't meant to use? Nowhere it says that. All FF_IDCT_ defines are documented as being able to be used in AVCodecContext.idct_algo > If so, may as well drop it with patch #1 > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".