From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2F5F044FEA for ; Tue, 12 Mar 2024 21:14:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DEC7168CDD9; Tue, 12 Mar 2024 23:14:31 +0200 (EET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3546B68CC0A for ; Tue, 12 Mar 2024 23:14:25 +0200 (EET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1d944e8f367so3263725ad.0 for ; Tue, 12 Mar 2024 14:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710278062; x=1710882862; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PKE2dQAQb8T4K/ti5NnD2JVvOMVEJyS53Idp+MB+/k0=; b=e+IQjKlS6GK7xNani63U2KTq1tcHs0gm2L0IWwWTau/YGXfCEuZPCzoyHL1CJEqQnX BPEel3zbKtYb6ifALCEx3hAy4fyo15X9Hx4m/U8clwX7QwljNrKew6jt26Eh9L1b2ImJ zJxKQsWpikzTqzfHuqgWvhDGPajvGx/4BypfLQdL7qWmD0UaWTojEzH/vrfuPZzRx1As 7tJxvw/rNsKlIaPrQiC27w1Gr3HjUsRwOnqby1FO/nhQFijzOh+2TqiMtjAl0/ACkrfD r8pKdZVOShupt95q9BgtOq2M2DbmwLrILbhcxmFt+wEo51JCrY8TY7aYIX8isj/TG80V ILeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710278062; x=1710882862; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PKE2dQAQb8T4K/ti5NnD2JVvOMVEJyS53Idp+MB+/k0=; b=fPf/JRIHLS91M8Wg7xMwVTjISyvEYv0U8Daski949YDuQWF0KtQs9CuFWLQPIDYt+n 4bO1/KYuFMZ7WBCqZtGffFG564R3WdMyqK001oTVqvPokTUxkVvVJL/sHJdu4Jpi2WY1 9dahC/yGMI90bl8GuMtHUpTlF+uXyRa1lBcNxGbnYeN3ZAXJ7lT0Ld0Drzm7+QURWWv5 ZK9qU8NBx3OOn0+aL8c9Ybu7+/gwFOhS/RC6Fcf1TEpS1dh+VTNTZL0chKf340V7fnqO k2rS8IQT8W4ivu3RjgyNHsJDpopYBfVLTJML+EcB9srOtNaYDYQ/yzQojR1cqvw/5b+b n6LA== X-Gm-Message-State: AOJu0Yxrmbd20HA8sLIXD8SquOylKiOvm1FG/GQjKPNeb2marZvdBCXS O9MUOPXI/yayoFC70UbVevw/SYUDjAb/rLmO9YrcIvQsR8372KQ/52czD29K X-Google-Smtp-Source: AGHT+IEytKhnOcHhhjg2Rt1hYjyQhUoZbsYbPTB6VkoX4Uxyi2LsUrQdwfOLJqNqHnDutUgqc4becg== X-Received: by 2002:a17:902:f68b:b0:1dc:6152:7c24 with SMTP id l11-20020a170902f68b00b001dc61527c24mr1713526plg.43.1710278062152; Tue, 12 Mar 2024 14:14:22 -0700 (PDT) Received: from [192.168.0.10] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id l12-20020a170903120c00b001dc1ef0d42bsm7187905plh.25.2024.03.12.14.14.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Mar 2024 14:14:20 -0700 (PDT) Message-ID: Date: Tue, 12 Mar 2024 18:14:24 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240311205844.3569895-1-jeebjp@gmail.com> <20240311205844.3569895-8-jeebjp@gmail.com> From: James Almer In-Reply-To: <20240311205844.3569895-8-jeebjp@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v8 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: T24gMy8xMS8yMDI0IDU6NTggUE0sIEphbiBFa3N0csO2bSB3cm90ZToKPiBUaGlzIHdhcyByZXF1 ZXN0ZWQgdG8gYmUgYWRkZWQgaW4gcmV2aWV3Lgo+IC0tLQo+ICAgbGliYXZ1dGlsL2ZyYW1lLmMg fCA0MyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gICBsaWJh dnV0aWwvZnJhbWUuaCB8IDIxICsrKysrKysrKysrKysrKysrKysrKwo+ICAgMiBmaWxlcyBjaGFu Z2VkLCA1MSBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv bGliYXZ1dGlsL2ZyYW1lLmMgYi9saWJhdnV0aWwvZnJhbWUuYwo+IGluZGV4IDQ2Zjk3NmEzZWQu LjMwZGI4M2E1ZTUgMTAwNjQ0Cj4gLS0tIGEvbGliYXZ1dGlsL2ZyYW1lLmMKPiArKysgYi9saWJh dnV0aWwvZnJhbWUuYwo+IEBAIC03ODEsMjkgKzc4MSw0NiBAQCBBVkZyYW1lU2lkZURhdGEgKmF2 X2ZyYW1lX3NpZGVfZGF0YV9uZXcoQVZGcmFtZVNpZGVEYXRhICoqKnNkLCBpbnQgKm5iX3NkLAo+ ICAgICAgIHJldHVybiByZXQ7Cj4gICB9Cj4gICAKPiAtaW50IGF2X2ZyYW1lX3NpZGVfZGF0YV9j bG9uZShBVkZyYW1lU2lkZURhdGEgKioqc2QsIGludCAqbmJfc2QsCj4gLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY29uc3QgQVZGcmFtZVNpZGVEYXRhICpzcmMsIHVuc2lnbmVkIGludCBm bGFncykKPiArQVZGcmFtZVNpZGVEYXRhICphdl9mcmFtZV9zaWRlX2RhdGFfYWRkKEFWRnJhbWVT aWRlRGF0YSAqKipzZCwgaW50ICpuYl9zZCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGVudW0gQVZGcmFtZVNpZGVEYXRhVHlwZSB0eXBlLAo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgQVZCdWZmZXJSZWYgKmJ1ZiwKPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmbGFn cykKPiAgIHsKPiAtICAgIEFWQnVmZmVyUmVmICAgICAqYnVmICAgID0gTlVMTDsKPiAtICAgIEFW RnJhbWVTaWRlRGF0YSAqc2RfZHN0ID0gTlVMTDsKPiAtICAgIGludCAgICAgICAgICAgICAgcmV0 ICAgID0gQVZFUlJPUl9CVUc7Cj4gKyAgICBBVkJ1ZmZlclJlZiAgICAgKm5ld19idWYgPSBOVUxM Owo+ICsgICAgQVZGcmFtZVNpZGVEYXRhICpzZF9kc3QgID0gTlVMTDsKPiAgIAo+IC0gICAgaWYg KCFzZCB8fCAhc3JjIHx8ICFuYl9zZCB8fCAoKm5iX3NkICYmICEqc2QpKQo+IC0gICAgICAgIHJl dHVybiBBVkVSUk9SKEVJTlZBTCk7Cj4gKyAgICBpZiAoIXNkIHx8ICFidWYgfHwgIW5iX3NkIHx8 ICgqbmJfc2QgJiYgISpzZCkpCj4gKyAgICAgICAgcmV0dXJuIE5VTEw7Cj4gICAKPiAtICAgIGJ1 ZiA9IGF2X2J1ZmZlcl9yZWYoc3JjLT5idWYpOwo+ICsgICAgbmV3X2J1ZiA9IGF2X2J1ZmZlcl9y ZWYoYnVmKTsKPiAgICAgICBpZiAoIWJ1ZikKPiAtICAgICAgICByZXR1cm4gQVZFUlJPUihFTk9N RU0pOwo+ICsgICAgICAgIHJldHVybiBOVUxMOwo+ICAgCj4gICAgICAgaWYgKGZsYWdzICYgQVZf RlJBTUVfU0lERV9EQVRBX0ZMQUdfVU5JUVVFKQo+IC0gICAgICAgIHJlbW92ZV9zaWRlX2RhdGEo c2QsIG5iX3NkLCBzcmMtPnR5cGUpOwo+ICsgICAgICAgIHJlbW92ZV9zaWRlX2RhdGEoc2QsIG5i X3NkLCB0eXBlKTsKPiAgIAo+IC0gICAgc2RfZHN0ID0gYWRkX3NpZGVfZGF0YV90b19zZXRfZnJv bV9idWYoc2QsIG5iX3NkLCBzcmMtPnR5cGUsIGJ1Zik7Cj4gKyAgICBzZF9kc3QgPSBhZGRfc2lk ZV9kYXRhX3RvX3NldF9mcm9tX2J1ZihzZCwgbmJfc2QsIHR5cGUsIG5ld19idWYpOwo+ICAgICAg IGlmICghc2RfZHN0KSB7Cj4gLSAgICAgICAgYXZfYnVmZmVyX3VucmVmKCZidWYpOwo+IC0gICAg ICAgIHJldHVybiBBVkVSUk9SKEVOT01FTSk7Cj4gKyAgICAgICAgYXZfYnVmZmVyX3VucmVmKCZu ZXdfYnVmKTsKPiArICAgICAgICByZXR1cm4gTlVMTDsKPiAgICAgICB9Cj4gICAKPiArICAgIHJl dHVybiBzZF9kc3Q7Cj4gK30KPiArCj4gK2ludCBhdl9mcmFtZV9zaWRlX2RhdGFfY2xvbmUoQVZG cmFtZVNpZGVEYXRhICoqKnNkLCBpbnQgKm5iX3NkLAo+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnN0IEFWRnJhbWVTaWRlRGF0YSAqc3JjLCB1bnNpZ25lZCBpbnQgZmxhZ3MpCj4g K3sKPiArICAgIEFWRnJhbWVTaWRlRGF0YSAqc2RfZHN0ID0gTlVMTDsKPiArICAgIGludCAgICAg ICAgICAgICAgcmV0ICAgID0gQVZFUlJPUl9CVUc7Cj4gKwo+ICsgICAgaWYgKCFzcmMpCj4gKyAg ICAgICAgcmV0dXJuIEFWRVJST1IoRUlOVkFMKTsKPiArCj4gKyAgICBzZF9kc3QgPSBhdl9mcmFt ZV9zaWRlX2RhdGFfYWRkKHNkLCBuYl9zZCwgc3JjLT50eXBlLCBzcmMtPmJ1ZiwgZmxhZ3MpOwo+ ICsgICAgaWYgKCFzZF9kc3QpCj4gKyAgICAgICAgcmV0dXJuIEFWRVJST1IoRU5PTUVNKTsKPiAr Cj4gICAgICAgcmV0ID0gYXZfZGljdF9jb3B5KCZzZF9kc3QtPm1ldGFkYXRhLCBzcmMtPm1ldGFk YXRhLCAwKTsKPiAgICAgICBpZiAocmV0IDwgMCkgewo+ICAgICAgICAgICByZW1vdmVfc2lkZV9k YXRhX2J5X2VudHJ5KHNkLCBuYl9zZCwgc2RfZHN0KTsKPiBkaWZmIC0tZ2l0IGEvbGliYXZ1dGls L2ZyYW1lLmggYi9saWJhdnV0aWwvZnJhbWUuaAo+IGluZGV4IGNlOTM0MjFkNjAuLmE3ZTYyZGVk MTUgMTAwNjQ0Cj4gLS0tIGEvbGliYXZ1dGlsL2ZyYW1lLmgKPiArKysgYi9saWJhdnV0aWwvZnJh bWUuaAo+IEBAIC0xMDIxLDYgKzEwMjEsMjcgQEAgQVZGcmFtZVNpZGVEYXRhICphdl9mcmFtZV9z aWRlX2RhdGFfbmV3KEFWRnJhbWVTaWRlRGF0YSAqKipzZCwgaW50ICpuYl9zZCwKPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbnVtIEFWRnJhbWVTaWRlRGF0YVR5 cGUgdHlwZSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzaXpl X3Qgc2l6ZSwgdW5zaWduZWQgaW50IGZsYWdzKTsKPiAgIAo+ICsvKioKPiArICogQWRkIGEgbmV3 IHNpZGUgZGF0YSBlbnRyeSB0byBhbiBhcnJheSBmcm9tIGFuIGV4aXN0aW5nIEFWQnVmZmVyUmVm Lgo+ICsgKgo+ICsgKiBAcGFyYW0gc2QgICAgcG9pbnRlciB0byBhcnJheSBvZiBzaWRlIGRhdGEg dG8gd2hpY2ggdG8gYWRkIGFub3RoZXIgZW50cnksCj4gKyAqICAgICAgICAgICAgICBvciB0byBO VUxMIGluIG9yZGVyIHRvIHN0YXJ0IGEgbmV3IGFycmF5Lgo+ICsgKiBAcGFyYW0gbmJfc2QgcG9p bnRlciB0byBhbiBpbnRlZ2VyIGNvbnRhaW5pbmcgdGhlIG51bWJlciBvZiBlbnRyaWVzIGluCj4g KyAqICAgICAgICAgICAgICB0aGUgYXJyYXkuCj4gKyAqIEBwYXJhbSB0eXBlICB0eXBlIG9mIHRo ZSBhZGRlZCBzaWRlIGRhdGEKPiArICogQHBhcmFtIGJ1ZiAgIEFWQnVmZmVyUmVmIGZvciB3aGlj aCBhIG5ldyByZWZlcmVuY2Ugd2lsbCBiZSBtYWRlCj4gKyAqIEBwYXJhbSBmbGFncyBTb21lIGNv bWJpbmF0aW9uIG9mIEFWX0ZSQU1FX1NJREVfREFUQV9GTEFHXyogZmxhZ3MsIG9yIDAuCj4gKyAq Cj4gKyAqIEByZXR1cm4gbmV3bHkgYWRkZWQgc2lkZSBkYXRhIG9uIHN1Y2Nlc3MsIE5VTEwgb24g ZXJyb3IuIEluIGNhc2Ugb2YKPiArICogICAgICAgICBBVl9GUkFNRV9TSURFX0RBVEFfRkxBR19V TklRVUUgYmVpbmcgc2V0LCBlbnRyaWVzIG9mIG1hdGNoaW5nCj4gKyAqICAgICAgICAgQVZGcmFt ZVNpZGVEYXRhVHlwZSB3aWxsIGJlIHJlbW92ZWQgYmVmb3JlIHRoZSBhZGRpdGlvbiBpcwo+ICsg KiAgICAgICAgIGF0dGVtcHRlZC4KPiArICovCj4gK0FWRnJhbWVTaWRlRGF0YSAqYXZfZnJhbWVf c2lkZV9kYXRhX2FkZChBVkZyYW1lU2lkZURhdGEgKioqc2QsIGludCAqbmJfc2QsCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbnVtIEFWRnJhbWVTaWRlRGF0YVR5 cGUgdHlwZSwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IEFWQnVmZmVyUmVmICpidWYsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBpbnQgZmxhZ3MpOwo+ICsKPiAgIC8qKgo+ICAgICogQWRkIGEgbmV3IHNp ZGUgZGF0YSBlbnRyeSB0byBhbiBhcnJheSBiYXNlZCBvbiBleGlzdGluZyBzaWRlIGRhdGEsIHRh a2luZwo+ICAgICogYSByZWZlcmVuY2UgdG93YXJkcyB0aGUgY29udGFpbmVkIEFWQnVmZmVyUmVm LgoKVGhpcyBhbHNvIExHVE0sIGJ1dCBBbnRvbiBoYXMgZXhwcmVzc2VkIGEgZGlzbGlrZSBmb3Ig dGhlIGZ1bmN0aW9uIApzaWduYXR1cmUsIHByZWZlcnJpbmcgaW5zdGVhZCBvbmUgdGhhdCB0YWtl cyBvd25lcnNoaXAgb2YgdGhlIGJ1ZmZlciBieSAKdGFraW5nIGEgcG9pbnRlciB0byBwb2ludGVy LCBhbmQgY2xlYXJpbmcgaXQgb24gc3VjY2Vzcy4KVGhlIGFyZ3VtZW50IHdhcyB0aGF0IHRoZSB1 c2VyIG1heSBub3QgY2FyZSBhYm91dCBrZWVwaW5nIGEgcmVmZXJlbmNlIHRvIAp0aGUgYnVmZmVy IGFmdGVyIGl0J3MgYWRkZWQgdG8gdGhlIHNpZGUgZGF0YSBhcnJheSwgYnV0IHNlZWluZyBob3cg dGhlIAp2ZXJ5IGZpcnN0IHVzZXIgaW4gdGhpcyBwYXRjaCBkb2VzLCBJIHBlcnNvbmFsbHkgdGhp bmsgdGhpcyBtb3JlIAphcHByb3ByaWF0ZS4KCklmIG90aGVycyBhZ3JlZSB3aXRoIGhpbSB0aGVu IEknbGwgbm90IG9wcG9zZSB0byBpdC4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZmZtcGVnLWRldmVsIG1haWxpbmcgbGlzdApmZm1wZWctZGV2ZWxAZmZt cGVnLm9yZwpodHRwczovL2ZmbXBlZy5vcmcvbWFpbG1hbi9saXN0aW5mby9mZm1wZWctZGV2ZWwK ClRvIHVuc3Vic2NyaWJlLCB2aXNpdCBsaW5rIGFib3ZlLCBvciBlbWFpbApmZm1wZWctZGV2ZWwt cmVxdWVzdEBmZm1wZWcub3JnIHdpdGggc3ViamVjdCAidW5zdWJzY3JpYmUiLgo=