From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0081F49815 for ; Mon, 19 Feb 2024 22:22:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 438CA68D42A; Tue, 20 Feb 2024 00:22:12 +0200 (EET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7412568D2E7 for ; Tue, 20 Feb 2024 00:22:06 +0200 (EET) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6e45c92a199so1021919b3a.2 for ; Mon, 19 Feb 2024 14:22:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708381324; x=1708986124; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/otenvXGqHWK+YNkdSKqO+DnSMdL8FZlJHFMpI/8vJA=; b=coHIcLlc+00NG+A+45BS2VWv/fq5IMB74KqU0p4YOKKOVB3v2wM3bOJ9YxLNw/3yIx OmlLrzz5Y5VL9dwAqvKsvTF+bxCAP1JEQhxk5JiEdZ35y7685QYizxKNfQVVg5kG3Bnu AH6YvkIVhuS4zFlPnD6+LHhXXEBul4PEWHShQHzUI3pULCVlPMutyxug2AxdW6NPmiUX 96U9CgviHvUablY8MsqgowBcLdOydOHf0jQ8Gje9hEBfaQG0jSxnaEo7amBV/tukaUZL R916+6YyWnGtYPPXtrfXVplGyQPJiibsTvblavWYWy70TwRyo8FOWxe3NGZ0zXXCHhki mkGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708381324; x=1708986124; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/otenvXGqHWK+YNkdSKqO+DnSMdL8FZlJHFMpI/8vJA=; b=BMOpPofeOH86NjoCRR8Cte6mZ3qNuY4Fr4SRZsfTtXPom8zKcDu68/yJTBwWI/Apos HfBESmbHjdiFXS3IPgaWfVYEovtsaF2NprqsumXfqm3dIbSOLoVPAWkdidbhQveBNGFj UcLef3eDgv5hVsodzDx787XanBFWxfoCCgxjqBtapdMWZe41H2ijHQo7ZVeefxmNmUs0 uI//ZyldVGdXD+EP1fBmFIjOUlW8y7HvYz5ZV/YOt9FF3vyPpexMLBox7srlcuCOpi7O 9qB52IgjeJ4lRauIRrDaFxcgVDIuT01pecHCT71j4A0aO1K9kkuXb88Q4C0vs4CkVTTF uJOg== X-Gm-Message-State: AOJu0Yyn/QQjGKzctNMILrSOqJ4OZjOuMMeI5NNm4RLLb5p2zemwM15c tcxTCFjeTKLLqlwBdzfwOHcQWa+RYoBxHzn5Dn0Rgsd+f8QNRZ5+soHf4n9T X-Google-Smtp-Source: AGHT+IHSk8wpwFAmbTOWH/QrVnUAgBucEVKOgVpUI65t/ucfpvLpGKSL1otL7NbszJlB1WVgyy5vgw== X-Received: by 2002:a05:6a20:b29e:b0:19c:64a5:2162 with SMTP id ei30-20020a056a20b29e00b0019c64a52162mr11868649pzb.20.1708381323888; Mon, 19 Feb 2024 14:22:03 -0800 (PST) Received: from [192.168.0.16] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id n28-20020a056a000d5c00b006e477b4a16csm388476pfv.44.2024.02.19.14.22.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Feb 2024 14:22:03 -0800 (PST) Message-ID: Date: Mon, 19 Feb 2024 19:22:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <6819fbe8-7239-4890-bb9f-a40e35520613@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2 5/6] avformat/iamf_writer: Return proper error codes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/19/2024 7:17 PM, Andreas Rheinhardt wrote: > Surprisingly the return value of add_param_definition() > (a pointer) has only been used to check for success > and not to actually access the pointee; nonsuccess > was equated with ENOMEM, although there is a non-enomem > error path in this function. > > Change this by returning an int. > > Signed-off-by: Andreas Rheinhardt > --- > Maybe one should avoid the param_definition variables entirely > by using if (!ff_iamf_get_param_definition(...))? Sure, either way (this patch or this suggestion) is fine. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".