From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E67764A065 for ; Sun, 16 Jun 2024 23:16:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8707968D71D; Mon, 17 Jun 2024 02:15:58 +0300 (EEST) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CFDB168D71D for ; Mon, 17 Jun 2024 02:15:51 +0300 (EEST) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-60585faa69fso2723415a12.1 for ; Sun, 16 Jun 2024 16:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718579748; x=1719184548; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=rncQB/kGBST8aMMTJpLXYj7VfzKUdkVNd8ENr7TVNMk=; b=GanteciPf1X0SrNtdJxSrfXpAq0wEVOM2c3+ODsdZod0z+f0VjD4T/JSe0om7xh7MN V2DNqy6Psy25jSJhSTUb/MGH55F84EUIAz7DTiJ2kELcDZP4+jFxszwaqml9BH56T6x5 RptaKuB2a8+tZOHuo2mf4CpwWUQDhhz4v5oCJ7tyWjvvBmmfpqpy6ENJtpwgXb6S5EIx BEFi4QIDmx2vpkuUb4TmAbK/TfC61htBJcnx8Ejq45sJ9qX32AyHo5Z6AMcA/PuEpIQk 11ISTkotOmsNgurLD/MWBysiz7f6srbB4aGfnSXKrVdIB09MipqSnWjxDVaskitGCS+4 ybfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718579748; x=1719184548; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rncQB/kGBST8aMMTJpLXYj7VfzKUdkVNd8ENr7TVNMk=; b=PYUs+CPr4jSx0YSD/hh7S7VzkIKRBNXRgKMOR470hjKCYtCS9x8k4TQf6GOjVNBZP7 Q7sFQ6n5sRPYE7PqB6y+VxftLRbVtKjiO57kcbS48r1EwQ5AMBEfysC5QmFsbC3Ai7gJ ygqFCFp8+8YxIZvZ2SwhIAuA6VlTtYPUMKfa3jkbiw4DqaPQXuCUWuFHjiXf2X4zin72 yrZ4DAXsa7ULz3iVCcGUyCPYPKqsn6ibE5IE7Irr0MDFUNmrIUMjK95bi71ZZCz50sio YheCF+6DgXEFvTQpe5WneNFJ1uYWCM97aDs/qaOPrJsqXXocdr3IK3Vyo6ln8mlOhgTC +Zug== X-Gm-Message-State: AOJu0Yz/vPViJgElQJ1eueqeP9vQ8egf96HpBGFTGlyo8UhXdic00Ek8 Z0vyG4xcJw6tbNvhZDQJSXWj2/sd+s4fp2CwzGQEoZS+UG2x0wQTf7T+eg== X-Google-Smtp-Source: AGHT+IEAx8ANSFnp3Gbb6bngaBlkDD1gJdgbbqtV0JweCIB5YOzj7h4xOHiQytO0BT9UhDYFIwog1A== X-Received: by 2002:a17:90a:4412:b0:2c2:f0a7:f8be with SMTP id 98e67ed59e1d1-2c4da542652mr12941029a91.9.1718579747835; Sun, 16 Jun 2024 16:15:47 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c4c45ac600sm7888824a91.5.2024.06.16.16.15.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jun 2024 16:15:47 -0700 (PDT) Message-ID: Date: Sun, 16 Jun 2024 20:15:47 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240616222849.420361-1-ramiro.polla@gmail.com> <20240616222849.420361-6-ramiro.polla@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: <20240616222849.420361-6-ramiro.polla@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 6/6] swscale/yuv2rgb/x86: remove mmx/mmxext yuv2rgb functions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/16/2024 7:28 PM, Ramiro Polla wrote: > These functions are either slower or barely faster than the C LUT > yuv2rgb code. > --- > libswscale/x86/yuv2rgb.c | 51 ----------------- > libswscale/x86/yuv2rgb_template.c | 4 -- > libswscale/x86/yuv_2_rgb.asm | 93 +------------------------------ > 3 files changed, 3 insertions(+), 145 deletions(-) > > diff --git a/libswscale/x86/yuv2rgb.c b/libswscale/x86/yuv2rgb.c > index 6754062245..41dfa80f33 100644 > --- a/libswscale/x86/yuv2rgb.c > +++ b/libswscale/x86/yuv2rgb.c > @@ -41,25 +41,8 @@ > > #define DITHER1XBPP // only for MMX Shouldn't this be removed too? > > -//MMX versions > -#if HAVE_MMX > -#undef RENAME > -#define COMPILE_TEMPLATE_MMX > -#define RENAME(a) a ## _mmx > -#include "yuv2rgb_template.c" > -#undef COMPILE_TEMPLATE_MMX > -#endif /* HAVE_MMX */ > - > -// MMXEXT versions > -#undef RENAME > -#define COMPILE_TEMPLATE_MMXEXT > -#define RENAME(a) a ## _mmxext > -#include "yuv2rgb_template.c" > -#undef COMPILE_TEMPLATE_MMXEXT > - > //SSSE3 versions > #undef RENAME > -#define COMPILE_TEMPLATE_SSSE3 > #define RENAME(a) a ## _ssse3 > #include "yuv2rgb_template.c" You could write a seventh patch that moves the template stuff back to this file, now that SSSE3 is the only version. See commit 8b62fb231a78. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".