From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D08B043B0E for ; Thu, 7 Dec 2023 14:03:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1E3CF68CCFE; Thu, 7 Dec 2023 16:03:44 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D91D168C97B for ; Thu, 7 Dec 2023 16:03:37 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 3B7E3bwd027770-3B7E3bwe027770; Thu, 7 Dec 2023 16:03:37 +0200 Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144]) by mail9.parnet.fi (Postfix) with ESMTPS id 0DE6EA1428; Thu, 7 Dec 2023 16:03:37 +0200 (EET) Date: Thu, 7 Dec 2023 16:03:36 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Mikhail Nitenko In-Reply-To: <20231204100035.157285-1-mnitenko@gmail.com> Message-ID: References: <20231204100035.157285-1-mnitenko@gmail.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH] lavc/aarch64: h264qpel, add lowpass_8 based functions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: ffmpeg-devel@ffmpeg.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Mon, 4 Dec 2023, Mikhail Nitenko wrote: > --- I think the patch subject is missing to tell that this adds 10 bit functions? > I remodeled the patch (as Martin once suggested), it doesn't > go to 32bits in lowpass_8_10 and is also using the much > faster lowpass_8_10_v. > > libavcodec/aarch64/h264qpel_init_aarch64.c | 91 +++- > libavcodec/aarch64/h264qpel_neon.S | 532 +++++++++++++++++++++ > 2 files changed, 621 insertions(+), 2 deletions(-) I think the patch overall looks good to me, thanks! I can try to push it a bit later. > diff --git a/libavcodec/aarch64/h264qpel_neon.S b/libavcodec/aarch64/h264qpel_neon.S > index f4475d96f9..31130a57fd 100644 > --- a/libavcodec/aarch64/h264qpel_neon.S > +++ b/libavcodec/aarch64/h264qpel_neon.S > @@ -933,3 +933,535 @@ endfunc > > h264_qpel16 put > h264_qpel16 avg > + > +//trashes v0-v5 > +.macro lowpass_8_10 r0, r1, r2, r3, d0, d1 > + ext v2.16B, \r0\().16B, \r1\().16B, #4 This patch uses upper case element specifiers like .16B here; we reformatted our assembly to consistenty use lower case element specifiers in 184103b3105f02f1189fa0047af4269e027dfbd6 (also see 7f905f3672da4f1fa28d7cccf1fef7f9984e0480); I can apply this change mechanically on this patch before pushing it. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".