Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Log 'EXIT' on exit

[Marton Balint <cus@passwd.hu>]

On Sat, 19 Apr 2025, softworkz wrote:

> From: softworkz <softworkz@hotmail.com>
>
> When viewing logs, there are situations where it is not entirely
> clear whether ffmpeg CLI has exited gracefully. The two primary cases
> are
>
> - A crash/segfault has occured
>  Windows for example doesn't output any message to the calling shell
> - The process has been terminated (e.g. killed externally)

Relying on logs alone and not checking the exit code is a bad practice, so 
I am not super convinced this feature is worth having.

>
> Printing "EXIT" on exit provides a reliable indication that the
> process has exited normally.

Something like this should not be visible on the default loglevel. So the 
loglevel should be reduced to verbose or debug.

And if we print out something, then let's make it more useful and 
readable, e.g.:

av_log(NULL, AV_LOG_VERBOSE, "Exiting with exit code %d.\n", ret);

Regards,
Marton

>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
>    fftools/ffmpeg: Log 'EXIT' on exit
>
>    When viewing logs, there are situations where it is not entirely clear
>    whether ffmpeg CLI has exited gracefully. The two primary cases are
>
>     * A crash/segfault has occured Windows for example doesn't output any
>       message to the calling shell
>     * The process has been terminated (e.g. killed externally)
>
>    Printing "EXIT" on exit provides a reliable indication that the process
>    has exited normally.
>
>    Signed-off-by: softworkz softworkz@hotmail.com
>
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-69%2Fsoftworkz%2Fsubmit_exit_message-v1
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-69/softworkz/submit_exit_message-v1
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/69
>
> fftools/ffmpeg.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index dc321fb4a2..26746699ff 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -1012,5 +1012,8 @@ finish:
>
>     sch_free(&sch);
>
> +    av_log(NULL, AV_LOG_INFO, "\n");
> +    av_log(NULL, AV_LOG_INFO, "EXIT\n");
> +
>     return ret;
> }
>
> base-commit: 7cd1edeaa410d977a9f1ff8436f480cb45b80178
> -- 
> ffmpeg-codebot
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".