From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 182F7436B5 for ; Thu, 21 Jul 2022 21:43:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1013A68B590; Fri, 22 Jul 2022 00:43:53 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E2FB368B06F for ; Fri, 22 Jul 2022 00:43:45 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 26LLhcHu013680-26LLhcHv013680; Fri, 22 Jul 2022 00:43:38 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id DB327A1447; Fri, 22 Jul 2022 00:43:37 +0300 (EEST) Date: Fri, 22 Jul 2022 00:43:36 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Hubert Mazur In-Reply-To: <20220715080228.686736-3-hum@semihalf.com> Message-ID: References: <20220715080228.686736-1-hum@semihalf.com> <20220715080228.686736-3-hum@semihalf.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 2/5] lavc/aarch64: Add neon implementation for sse4 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, ffmpeg-devel@ffmpeg.org, mw@semihalf.com, spop@amazon.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 15 Jul 2022, Hubert Mazur wrote: > Provide neon implementation for sse4 function. > > Performance comparison tests are shown below. > - sse_2_c: 74.0 > - sse_2_neon: 24.0 > > Benchmarks and tests are run with checkasm tool on AWS Graviton 3. > > Signed-off-by: Hubert Mazur > --- > libavcodec/aarch64/me_cmp_init_aarch64.c | 3 ++ > libavcodec/aarch64/me_cmp_neon.S | 65 ++++++++++++++++++++++++ > 2 files changed, 68 insertions(+) > > diff --git a/libavcodec/aarch64/me_cmp_init_aarch64.c b/libavcodec/aarch64/me_cmp_init_aarch64.c > index 3ff5767bd0..72a2062e7e 100644 > --- a/libavcodec/aarch64/me_cmp_init_aarch64.c > +++ b/libavcodec/aarch64/me_cmp_init_aarch64.c > @@ -32,6 +32,8 @@ int ff_pix_abs16_x2_neon(MpegEncContext *v, uint8_t *pix1, uint8_t *pix2, > > int sse16_neon(MpegEncContext *v, uint8_t *pix1, uint8_t *pix2, > ptrdiff_t stride, int h); > +int sse4_neon(MpegEncContext *v, uint8_t *pix1, uint8_t *pix2, > + ptrdiff_t stride, int h); > > av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) > { > @@ -44,5 +46,6 @@ av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) > > c->sad[0] = ff_pix_abs16_neon; > c->sse[0] = sse16_neon; > + c->sse[2] = sse4_neon; > } > } > diff --git a/libavcodec/aarch64/me_cmp_neon.S b/libavcodec/aarch64/me_cmp_neon.S > index 88cd335443..bacf151314 100644 > --- a/libavcodec/aarch64/me_cmp_neon.S > +++ b/libavcodec/aarch64/me_cmp_neon.S > @@ -360,3 +360,68 @@ function sse16_neon, export=1 > ret > > endfunc > + > +function sse4_neon, export=1 > + // x0 - unused > + // x1 - pix1 > + // x2 - pix2 > + // x3 - stride > + // w4 - h > + > + movi d18, #0 > + movi d17, #0 > + cmp w4, #4 > + b.le 2f > + > +// make 4 iterations at once > +1: > + > + // res = abs(pix1[0] - pix2[0]) > + // res * res > + > + ld1 {v0.4b}, [x1], x3 This fails to assemble for me with essentially all tools I have (old binutils, moderately recent binutils, current llvm, MS armasm64.exe): src/libavcodec/aarch64/me_cmp_neon.S:374: Error: operand mismatch -- `ld1 {v0.4b},[x1],x3' src/libavcodec/aarch64/me_cmp_neon.S:374: Info: did you mean this? src/libavcodec/aarch64/me_cmp_neon.S:374: Info: ld1 {v0.8b}, [x1], x3 src/libavcodec/aarch64/me_cmp_neon.S:374: Info: other valid variant(s): src/libavcodec/aarch64/me_cmp_neon.S:374: Info: ld1 {v0.16b}, [x1], x3 src/libavcodec/aarch64/me_cmp_neon.S:374: Info: ld1 {v0.4h}, [x1], x3 src/libavcodec/aarch64/me_cmp_neon.S:374: Info: ld1 {v0.8h}, [x1], x3 src/libavcodec/aarch64/me_cmp_neon.S:374: Info: ld1 {v0.2s}, [x1], x3 src/libavcodec/aarch64/me_cmp_neon.S:374: Info: ld1 {v0.4s}, [x1], x3 src/libavcodec/aarch64/me_cmp_neon.S:374: Info: ld1 {v0.1d}, [x1], x3 src/libavcodec/aarch64/me_cmp_neon.S:374: Info: ld1 {v0.2d}, [x1], x3 I'll follow up with an actual review of the patches later. I'm sorry I have a bit longer review latency than usual at the moment, as I'm on vacation. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".