Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add quirc filter
Date: Tue, 26 Dec 2023 22:33:36 -0300
Message-ID: <ce029b75-bfee-48ad-8947-8e2acfede251@gmail.com> (raw)
In-Reply-To: <ZYt9APtmjF70LDIp@mariano>

On 12/26/2023 10:25 PM, Stefano Sabatini wrote:
> On date Tuesday 2023-12-26 17:20:33 +0100, Stefano Sabatini wrote:
>> ---
>>   Changelog                |   1 +
>>   configure                |   4 +
>>   doc/filters.texi         |  35 ++++++++
>>   libavfilter/Makefile     |   1 +
>>   libavfilter/allfilters.c |   1 +
>>   libavfilter/vf_quirc.c   | 183 +++++++++++++++++++++++++++++++++++++++
>>   6 files changed, 225 insertions(+)
>>   create mode 100644 libavfilter/vf_quirc.c
> 
> V2 with a few fixes and all corners put in the metadata (e.g. in case
> the QR code is rotated).

Looking at the library, the license is very permissive and the code 
hasn't been touched in many years. It is also pretty small, so why not 
just add it as a native filter instead of requiring an external 
dependency for what seems to be a relatively simple process?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-12-27  1:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-26 16:20 Stefano Sabatini
2023-12-26 19:08 ` Andreas Rheinhardt
2023-12-27  1:20   ` Stefano Sabatini
2023-12-26 19:21 ` James Almer
2023-12-27  1:19   ` Stefano Sabatini
2023-12-27  1:25 ` Stefano Sabatini
2023-12-27  1:33   ` James Almer [this message]
2023-12-27 11:37     ` Stefano Sabatini
2023-12-27 14:49       ` Tomas Härdin
2023-12-27 17:16       ` James Almer
2023-12-27 23:20         ` Stefano Sabatini
2023-12-28  0:57           ` James Almer
2023-12-29 11:57             ` Stefano Sabatini
2024-01-02 21:13               ` Stefano Sabatini
2023-12-28 10:24           ` Tomas Härdin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce029b75-bfee-48ad-8947-8e2acfede251@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git