[FFmpeg-devel] [PATCH] avcodec/av1dec: Fix unintended fallthrough

[FFmpeg-devel] [PATCH] avcodec/av1dec: Fix unintended fallthrough

[Andreas Rheinhardt]

Fixes Coverity issue #1521982.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/av1dec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
index a80e37e33f..4d3b559b96 100644
--- a/libavcodec/av1dec.c
+++ b/libavcodec/av1dec.c
@@ -911,6 +911,7 @@ static int export_itut_t35(AVCodecContext *avctx, AVFrame *frame,
         default: // ignore unsupported identifiers
             break;
         }
+        break;
     }
     case 0x3C: { // smpte_provider_code
         AVDynamicHDRPlus *hdrplus;
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: Fix unintended fallthrough

[James Almer]

On 3/15/2023 11:09 AM, Andreas Rheinhardt wrote:
> Fixes Coverity issue #1521982.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   libavcodec/av1dec.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> index a80e37e33f..4d3b559b96 100644
> --- a/libavcodec/av1dec.c
> +++ b/libavcodec/av1dec.c
> @@ -911,6 +911,7 @@ static int export_itut_t35(AVCodecContext *avctx, AVFrame *frame,
>           default: // ignore unsupported identifiers
>               break;
>           }
> +        break;
>       }
>       case 0x3C: { // smpte_provider_code
>           AVDynamicHDRPlus *hdrplus;

Good catch. Same issue is in libdav1d. Want to fix it too, or should i?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".