* Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dnxhdenc: fix possible out of bound writes for big w/h
[not found] <20220304224331.2E33D4104B6@natalya.videolan.org>
@ 2022-03-05 7:55 ` Martin Storsjö
2022-03-05 10:16 ` Paul B Mahol
0 siblings, 1 reply; 2+ messages in thread
From: Martin Storsjö @ 2022-03-05 7:55 UTC (permalink / raw)
To: ffmpeg-devel
On Fri, 4 Mar 2022, Paul B Mahol wrote:
> ffmpeg | branch: master | Paul B Mahol <onemda@gmail.com> | Fri Mar 4 23:25:48 2022 +0100| [37480b1b85b0405563962b581dc2899b1b4bec59] | committer: Paul B Mahol
>
> avcodec/dnxhdenc: fix possible out of bound writes for big w/h
>
> It was caused by integer overflows.
>
>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=37480b1b85b0405563962b581dc2899b1b4bec59
> ---
This caused changes to the hashes in the fate-lavf-mxf_opatom test - can
you have a look?
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dnxhdenc: fix possible out of bound writes for big w/h
2022-03-05 7:55 ` [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dnxhdenc: fix possible out of bound writes for big w/h Martin Storsjö
@ 2022-03-05 10:16 ` Paul B Mahol
0 siblings, 0 replies; 2+ messages in thread
From: Paul B Mahol @ 2022-03-05 10:16 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On 3/5/22, Martin Storsjö <martin@martin.st> wrote:
> On Fri, 4 Mar 2022, Paul B Mahol wrote:
>
>> ffmpeg | branch: master | Paul B Mahol <onemda@gmail.com> | Fri Mar 4
>> 23:25:48 2022 +0100| [37480b1b85b0405563962b581dc2899b1b4bec59] |
>> committer: Paul B Mahol
>>
>> avcodec/dnxhdenc: fix possible out of bound writes for big w/h
>>
>> It was caused by integer overflows.
>>
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=37480b1b85b0405563962b581dc2899b1b4bec59
>> ---
>
> This caused changes to the hashes in the fate-lavf-mxf_opatom test - can
> you have a look?
>
It caused yet another integer overflow, and max_bits was still bigger
than allowed by few bits.
I changed code to keep increasing qscale until max_bits is lowered.
max_bits is just worst case scenario for bit allocations.
> // Martin
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-05 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220304224331.2E33D4104B6@natalya.videolan.org>
2022-03-05 7:55 ` [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dnxhdenc: fix possible out of bound writes for big w/h Martin Storsjö
2022-03-05 10:16 ` Paul B Mahol
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git