From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 792334058D for ; Wed, 26 Jan 2022 03:07:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 940E068AF5C; Wed, 26 Jan 2022 05:07:16 +0200 (EET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 96DC96881C8 for ; Wed, 26 Jan 2022 05:07:10 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643166435; x=1674702435; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=D3lrj+yOZHnSN60nU0yMt9mSS6qz6yz8yxPzLj8RiS4=; b=WfR/5zi6pdJv0TCbB6UfEtIOOnU7ULwzjbF2WhGg+WahSsnhp0851MNq glmSwCh9JhG06/jXllFyGRDwOBR8/x581RWLqrbXoXz4/QNgXxFj9LXCf QcPDlRBq2g/Qegq5CzBVzov75Ajf5ladpK2STvryGPD6o/rPFf5eIUHe+ la1NPFIilTCq87LLyUNCCkFGDacPxkK7P/tdXLkTuIdkb18c5Nvyy3zII M5JXm0yB1uyqQY/h8kCKeEjsv0ZSPq9UrqCisH8zUb35EbJuTIYcPTEnM mT6qNuXIqxtEtMy4M5S3tLYm0girQchRkhiZIz32KRzqM1Lp84vB1g5TC w==; X-IronPort-AV: E=McAfee;i="6200,9189,10238"; a="245304211" X-IronPort-AV: E=Sophos;i="5.88,316,1635231600"; d="scan'208";a="245304211" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 19:07:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,316,1635231600"; d="scan'208";a="479746921" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 25 Jan 2022 19:07:07 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 19:07:07 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 25 Jan 2022 19:07:07 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 25 Jan 2022 19:07:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nZNahCbZzFwz9GwPNKOlh8trT5TuWu8P1pzHjGzbjIb0mUc0nhFFrLOBorUtT7jyEdsHuetRz3kEMY1RgkPV1UR7oJ1HQlMUgC2t6VAoZAbgYRPzWwmfsyyiuCJWI2Tvx+o+HKbp1A8WmQPq+EoICcQ7TwwP1yYrI+YiCnSQqvgp442vA3mhkV3kaiDZucPYCGpxmqAnDtaDHozekBOnGhrVuY2LuS0EH5RRI6fJXKBVCdpKiUrPk1HjEtIweucbJt1Ba9zKl7ZCAlp46kfgWwytmjY/03rDqyLDZvwz5vq9R5o8FTQeiID8ENzCQpCInWAwsZmcpCviKIpW+cmRSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D3lrj+yOZHnSN60nU0yMt9mSS6qz6yz8yxPzLj8RiS4=; b=G4obBr4mzzn4WIuQvtcQLEbnC3XaMsFXCF4NRmNc6HPa3tTzCWDQJ1Upi9/jdZOodNfx8svkG8894JdSXWcSvomNftcrNoijXC+d01TJ6LjHhGJIToswg+8c2wPS9v6X5F/6Ul9uoGNeOaMXIOXYG3x/GX8y3eHguQid4ybbaIuQIg9oN1on54imJXNdsL4jn6O3YqK9Ebti6bZRmdyjOqG7dr5uVWJQdFHiHM7kgoQm0GFksRDux0kUXXbQZZilBjfAmTKMu37PcmnpO/j3l025gJvwPm7IO9HYU3LPqOL1KxSjDDJo0U8Zq5ehc+eltTmUnwbfUsmsFpFnZphftA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by SA2PR11MB5162.namprd11.prod.outlook.com (2603:10b6:806:114::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Wed, 26 Jan 2022 03:07:06 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%5]) with mapi id 15.20.4888.020; Wed, 26 Jan 2022 03:07:06 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH V5 1/2] libavcodec/vaapi_decode: fix the problem that init_pool_size < nb_surface Thread-Index: AQHYBriHUwXWjMUIP0KI7F4TNK4wcqx0tiUA Date: Wed, 26 Jan 2022 03:07:05 +0000 Message-ID: References: <20220111065538.750653-1-wenbin.chen@intel.com> In-Reply-To: <20220111065538.750653-1-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1fabccdd-da04-49d9-40bd-08d9e078ef05 x-ms-traffictypediagnostic: SA2PR11MB5162:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l7g1gvv9nzzYKxiSoBKzfn6hdJKJKxKbIPGncif6n5N4o9j1HpCbwI8F+YH0oVeqIZoxEmg7AYLlWiYUaqfL/n39sPYIMu/Q3QutnyZvRwH1FogxWadv9uIkcXN22R1QxHAWsNwb/0ZScUjT62gFBGK0I1e8fBKc8N7hu+KBGIodWGiKPFro1jrhJagiBZq9lvOvm4YaT/oHWn+xFWsrgdCL6JeZqvTVa5uU0B8ipN3x6OveShby2w9OIfpyBsjlUSmL4q09sTu8uiiBqdTg4HZJCohJL1FnQmN0x8vJjC3G/eOthbvqjws+o3vqKyByu8BWDGYK2qDMbEBVabrjpKUX3zfGbL060asn6djrG05qzTmx4Viy3tAy9s+lg8/Mi4O+DvejEuniiW8+qpNMLcEGp0ncGNl7pUBu8hZE0c7IOnpUpk1igtm+XBa/wr/cm6Um5oQPyUJ3xWzuJMbx80vbxEGYy6h3TxD+lYNduU2kwVCfo4pQCAQ9u2lSw1kHMbDyl/ElwojncJ6nGBfrPoJM84zZo2qxp/+RLqPwthDzx/exF9PmLXfabw/GrnqG68j2a7j77+VENIA39VtVzHJwkg/kwAms3rppYewr+usol10Poe6cjbCml/RtCqtYzaBDJtTxLyCPKJ0WiEZkdw5gS8f4If9vPO1na7LrFlMGlWTJTTqfOTH/z31Y9DdqsfIhbrJK/A+A2IaJM0LWdt/1neo1jTBXGzKusqK/2vA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2616005)(508600001)(5660300002)(76116006)(36756003)(71200400001)(186003)(66946007)(38100700002)(66446008)(38070700005)(6506007)(66556008)(83380400001)(66476007)(8936002)(6916009)(64756008)(26005)(122000001)(316002)(82960400001)(8676002)(86362001)(6486002)(6512007)(2906002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WnZVK0hKZzI2OThqSnYzUUVzK3NOL0t1a3pWeVdvOEhmSGw2aW81eWlSZ3ll?= =?utf-8?B?d1ZuU1c0V3o5RDZZWFZIRDByaUlvLzBUaVNyNmliMTBRMFM2TU8rWXo3SFR6?= =?utf-8?B?ZWZCUzV5dm4rNmpEcHFuTEVxK05TRDZIejhXamlrNHBNRkEvWHY3ZDRid1VW?= =?utf-8?B?c1dxU2oySTZTbUpISnQzT1d5cHNZQ1JiVE5Odm5mRnR3UnRoWmg4STVmTGYr?= =?utf-8?B?SWgxajRXOW9raTFWNm1OcnF1TWpsMVU3bWcyT29ENTAvbE1CNzlvNHAxRXNG?= =?utf-8?B?VkZNQlB4MG9LTTQ5RGlEcnUxZ0t2T2tLMjNBWGd2YzBsdURwZTdMTlFZQ0Mz?= =?utf-8?B?QkxLUjFFUnNWSE9qaHZBbEgrTzB4bGRscGlpSWdOazZWVGRHOWNxd2RsSXcv?= =?utf-8?B?YkphMUh2UlhvVE1RUUFzVWZubEdVM2RXalNYTE5jNmVsUkE1SU5iRTM2Z2x4?= =?utf-8?B?cGNhcWVrc21Ra29JbkRkR0c2dEhMQXN4ZXVFZ2kvTk9GdHdVUkhnU0dWVmJK?= =?utf-8?B?WTlud0JWdEZPMHFyMkNoU3ZNMUJSWUNtV1FoTzhOU3puc05sb3U0c0ZWeFhn?= =?utf-8?B?THRRczJPTktBeTNpZmFxanhuaXlrM29QcmZDNTdybnFjdkNwRWJCU3VnSHli?= =?utf-8?B?US85Ulp4MHNZNW1rWTAyWlJGaTBVbnpGa1IwV0xDNEZ4Q3F2NVEzTkM3MW5L?= =?utf-8?B?UHlCcitoMlNCMlZlM200S2lMNGtGV09ndC9oWm9UbVRsZTAvaDQzL2ZySzUv?= =?utf-8?B?UC93K05FUmtYc2RqZUV0eHFYaUpIcldzdWJrb1BXakQ1dHRlbnFoeElKZnpn?= =?utf-8?B?Mk9JMmpwRG5BVGhUdEd1WVdvMjdFWWowY05UK1JZL0VDQUh3bEtOcUo0aDBJ?= =?utf-8?B?THE4Y2hhV1BwRmZkdDNNaEdiQkxxUWtjZVpsM1N5OWQ5NmNwNm05WklaRk5a?= =?utf-8?B?VCs2VkUvR3hRSGQwWGIvTk1tOExMYzdiK3VjMGZpOWtHUU91VXMzOWZnRE9Q?= =?utf-8?B?cFdiOElheExFcnRvZ055NjkvVzBDbzlPRFlMa2J3NnhqWG9hQkQ0ZHVXQkla?= =?utf-8?B?dzR0MWtqeUNXR3IwTWkzUkJzRjdjdGltTWxOQkNZaW1SYmVVcHVsZEJYWlh4?= =?utf-8?B?ampSRnd3N2FubnhUSHQwcldKOE03blZoOVc2Ykwyamw5ODVKSHZLU3U0S1Fk?= =?utf-8?B?Q093SkN3K251bFMwZFEyN0cyaUY4WUIrdGpaWGpqSS9NUlcrMnBGblk1YVk3?= =?utf-8?B?cVMwZWtZN2xvTWxZa0xlQmxQdXZGQjJCbFRyK0NTWTN0bjNJTWpNS1dxT3lJ?= =?utf-8?B?a1Q5bHN4T1ptR1pZbWdBYkRweG5WbWlEL1NIb2NCQkhvTm9OVU9jL2hNdndy?= =?utf-8?B?ZHRXa2RNVVNPSFR3WjRLQ0RIWGFnNDVTbEdqdnkvOWEremtvTThpVS9Pa3pF?= =?utf-8?B?cmlPcFd2enJNMHJHRmh5UEFpZmxWVXNNWTZPSGJzSlh1ZGZHbFRCYktJOHg4?= =?utf-8?B?WGdDVzdEcW9wVnd1V3RKT1Q1OVgyS2VVWlIwblNoY0Z1NStDMkdWWDVpOG43?= =?utf-8?B?cWIrMk5kZ0c4aERheHZ5ZUgwQytPeWJTZk83MG5pdUd3VFZWNEV3OXlxcVpw?= =?utf-8?B?V0M0dnBXTm9FUnQ4ZWZXVVBVZmRsdEhMWHB3LzgzVDJtUWZYc0d2NWVMWDk0?= =?utf-8?B?WUNUZEJBZHlLbFpCMGpJc3l6RUdlbU1PcDM5NHBEOGpuSnV4bjNtM2tSRzU5?= =?utf-8?B?ZEpjVWNnUlVQclYxbjQ0Sll6ZnVnNk50T2U4cXRobFExUlR2aDJ1Rll0VXh5?= =?utf-8?B?ZnZFRkl1Q2IyYnh6Rm9Rc1dZMjNNcFdwZTNOQVBJQ2gxL0k0YmtIdmF4a0Ro?= =?utf-8?B?MlJmRlNTVVd4UlJPOUc3cEdRYmlWeXBPZDA2anoreGp4TThML210WDI4N0NG?= =?utf-8?B?Q29OWXp2Y3RVeGdkWGJkRzRSWkptRHB5dVZtcDNjZ2ZaK21pSTVma2swNDZE?= =?utf-8?B?ZThjSXM3NTRWVExwUko1SjVaQ0dGMUovVGdsUWwyR2poemtLUlVvdGtKaDdn?= =?utf-8?B?dXdPUTBSQ1lUbDgycnh4WTJ0TDB4YWdxOU1uVUk1NjNDajY1Q1hqRXIxSDZD?= =?utf-8?B?bjBYMDhtbHdmR0hSajFQVEpGSml1YUFXYWU4eEdpcGpvd0g2cDNMNlZpRWUw?= =?utf-8?Q?jjQflxH/6dz93cxi3Uw65kU=3D?= Content-ID: <641A1B491FE480458AA20B89570E8853@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fabccdd-da04-49d9-40bd-08d9e078ef05 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2022 03:07:05.9650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CIzcgqpHmzu55ED/y6Yys+z7mvbSjuQNFSHx6DphEcp56KkCCqnqGxI3LrDvzI3fTWSK5BrcWRrd0J19Z+Lxww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5162 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH V5 1/2] libavcodec/vaapi_decode: fix the problem that init_pool_size < nb_surface X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-01-11 at 14:55 +0800, Wenbin Chen wrote: > For vaapi if the init_pool_size is not zero, the pool size is fixed. > This means max surfaces is init_pool_size, but when mapping vaapi > frame to qsv frame, the init_pool_size < nb_surface. The cause is that > vaapi_decode_make_config() config the init_pool_size and it is called > twice. The first time is to init frame_context and the second time is to > init codec. On the second time the init_pool_size is changed to original > value so the init_pool_size is lower than the reall size because > pool_size used to initialize frame_context need to plus thread_count and > 3 (guarantee 4 base work surfaces). Now add code to make sure > init_pool_size is only set once. Now the following commandline works: > > ffmpeg -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 \ > -hwaccel_output_format vaapi -i input.264 \ > -vf "hwmap=derive_device=qsv,format=qsv" \ > -c:v h264_qsv output.264 > > Signed-off-by: Wenbin Chen > --- > libavcodec/vaapi_decode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c > index 665af370ed..da0e72b10b 100644 > --- a/libavcodec/vaapi_decode.c > +++ b/libavcodec/vaapi_decode.c > @@ -650,7 +650,7 @@ int ff_vaapi_decode_init(AVCodecContext *avctx) > ctx->hwctx = ctx->device->hwctx; > > err = vaapi_decode_make_config(avctx, ctx->frames->device_ref, > - &ctx->va_config, avctx->hw_frames_ctx); > + &ctx->va_config, NULL); > if (err) > goto fail; > LGTM, and the command works well for me now. Will aplly Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".