From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A2E9E44C9B for ; Mon, 14 Nov 2022 16:34:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 77D6668BE89; Mon, 14 Nov 2022 18:34:38 +0200 (EET) Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5A71768BDEF for ; Mon, 14 Nov 2022 18:34:32 +0200 (EET) Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-13ae8117023so13043375fac.9 for ; Mon, 14 Nov 2022 08:34:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N/9+KZhsIU2N7ph4ihV3NilIjZ1j09P2QQtC1T8JfoY=; b=GAcUB2J41QYxSshGI5Xq5eHWe6EID/zO1TqzcaE3af0yIqe0yGon4zqnjOq++R2Pa1 4NwpAfiVeDnN71AVVpZ/RHyto9u+DxnO6CPsXWMZe5oKLS2BLy5xijl1Eyj0FJGi38HK kSvauBLIkUwenKzuGsNJr30c+NsM/IDtfMnItz57mDx9AZNvfyLRohELK3xSeCvLa60o +GHmov18DF4kO8umaq/d4Qwi/KIVBeFHhTSipEabuepms5etlM9zMoBLRNFtdnjqSuVX Zxr1pbLgTSAKig31cH5lON5ApgIoExk5jO3AiI9Ozs9XhfDFmpxn0/0q/b0mbnD42oWn yg8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N/9+KZhsIU2N7ph4ihV3NilIjZ1j09P2QQtC1T8JfoY=; b=DqrKi4z+n7ZZAkoe1HuvkDCSbpGUr3Xc7cXGNqlCBq8oiMJ8M+HDhK9qNiIWoimIKA FiGgMh4WLL/9nlp6BTa7b6vKDlxqdrbXkn2a4ugL3hM2nXNfvGfIKcwjMDLgeq3c9Qs5 u2qIbOE+IkLHSeEKsw0XtmjaShIYa7HQcYbvPgtnyTGDbUOtiIWrKJenqoAvQ5bI1OO9 vP/pf//fI8RoLG5oS9ffT5/B+6Rp6uWRsnysx2I7SiSDd3FFumXgOjHT/uAQpz1uRgLb 5ylr9Ys4wrmYg0Jw0zQTEyND+WSv4xBGg/e7gQTHdXEAwj/TFw+Hjv0fkflSjRVqcmC6 kLoQ== X-Gm-Message-State: ANoB5pmehc08QwktdmZCGrEQz99UGLps+d5+Gbi5GqHdktty6Kq2UMsn Tru5w0lNEQRShR3xMZ5zQC+w5A2pPWc= X-Google-Smtp-Source: AA0mqf6qdT6NV24qsWkXSo2OLDuUuE18eNsV6df1hS/aqWTzFoa21qp/62AFrbizOcBFzWJEyFcpBQ== X-Received: by 2002:a05:6870:b60d:b0:13b:a591:d562 with SMTP id cm13-20020a056870b60d00b0013ba591d562mr7180606oab.70.1668443670771; Mon, 14 Nov 2022 08:34:30 -0800 (PST) Received: from [192.168.0.15] ([181.85.72.69]) by smtp.gmail.com with ESMTPSA id q5-20020a056870328500b0012763819bcasm5077982oac.50.2022.11.14.08.34.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 08:34:30 -0800 (PST) Message-ID: Date: Mon, 14 Nov 2022 13:34:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20221114152023.11003-1-bin.wang@intel.com> From: James Almer In-Reply-To: <20221114152023.11003-1-bin.wang@intel.com> Subject: Re: [FFmpeg-devel] [PATCH v2] libavfilter/x86/vf_convolution: fix sobel swap issue on WIN64 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/14/2022 12:20 PM, bin.wang-at-intel.com@ffmpeg.org wrote: > From: "Wang, Bin" > > Signed-off-by: Wang, Bin > --- > libavfilter/x86/vf_convolution.asm | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/libavfilter/x86/vf_convolution.asm b/libavfilter/x86/vf_convolution.asm > index c912d56752..9ac9ef5d73 100644 > --- a/libavfilter/x86/vf_convolution.asm > +++ b/libavfilter/x86/vf_convolution.asm > @@ -189,15 +189,16 @@ cglobal filter_sobel, 4, 15, 7, dst, width, matrix, ptr, c0, c1, c2, c3, c4, c5, > cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, c1, c2, c3, c4, c5, c6, c7, c8, r, x > %endif > %if WIN64 > - SWAP xmm0, xmm2 > - SWAP xmm1, xmm3 > + VBROADCASTSS m0, xmm2 > + VBROADCASTSS m1, xmm3 > mov r2q, matrixmp > mov r3q, ptrmp > DEFINE_ARGS dst, width, matrix, ptr, c0, c1, c2, c3, c4, c5, c6, c7, c8, r, x > -%endif > - movsxdifnidn widthq, widthd > +%else > VBROADCASTSS m0, xmm0 > VBROADCASTSS m1, xmm1 > +%endif > + movsxdifnidn widthq, widthd > pxor m6, m6 > mov c0q, [ptrq + 0*gprsize] > mov c1q, [ptrq + 1*gprsize] > @@ -281,7 +282,7 @@ cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, c1, c2, > fmaddss xmm4, xmm5, xmm5, xmm4 > > sqrtps xmm4, xmm4 > - fmaddss xmm4, xmm4, xmm0, xmm1 ;sum = sum * rdiv + bias > + fmaddss xmm4, xmm4, xm0, xm1 ;sum = sum * rdiv + bias > cvttps2dq xmm4, xmm4 ; trunc to integer > packssdw xmm4, xmm4 > packuswb xmm4, xmm4 Should be ok. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".