From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7AF7145CED for ; Mon, 29 Jul 2024 13:15:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7CA3F68D535; Mon, 29 Jul 2024 16:15:24 +0300 (EEST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3E79468C75C for ; Mon, 29 Jul 2024 16:15:16 +0300 (EEST) Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-52efba36802so5847993e87.2 for ; Mon, 29 Jul 2024 06:15:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1722258916; x=1722863716; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Skba65EEMiYvXvLl+BNCNZZmqzZu3r+y0dsQdJX14Ug=; b=bJCxcWR9tpdCi8tNf7k7kganwoSEmCXvATk67IDOQMZCfHw2K+yo2fDf/4y0+/HXST F4EVuu7jWx17q9WaUWK1cYSF9B6RkhNoidecjVZ5aKF6dv2JQxdHjabKj7u2jdLsvLRw +vQlGlHqVelOLZYzm2GrKlkav7plxY/6Q876WUtfVOdSpiN3R41VxRt7t5Rs6KvuASFt p5LOUF72rOz76YZE2ggEn9+6O9AiiLH32GTwuoHuWaz9HaPNj7W+Tlb4axXAGVimnVq8 DH+VHepCFkdxXAsGEX5Isoq56b/OBsOiaSDcRMOz5CaIlsss3QMAl/byBv6nha2KVVlV gLGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722258916; x=1722863716; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Skba65EEMiYvXvLl+BNCNZZmqzZu3r+y0dsQdJX14Ug=; b=FJg3RA67+OwUybUE7wGlScXg2Evvne6SITMOuTrmgiu21McYR+3z/kjp5KyUj76TeI dv4PNRSPvZOokj2egbeksvx/G3DIjhbB/Adi9C6klK9bRgqkoqOqvs/BDFF2td0eRRce XfA8CN0tC79BwD4/y3Af7gR2OZAiZ6QBj0/nR7aHWMm6n34jiy1k6SC6+YoFjgrwdNQq I8jWg6QOkLDWDyV9Rh5bJuAjM4mAYiAIEi+q45x1sfZqRBPcrjKnuf6v5J+TYcOSv1sR ZQjxMEPVZ/pTk3dt4rI0BKO3DgUL/YFuoM4TlMvQ0f7wNYmRcKi3KvqbIWA1dbiInKoU duRQ== X-Gm-Message-State: AOJu0YyLBIqHuZy0tmB6Tv6xoehU1kC1MEv3npf7JJw6dhk5RIDkGRWH Is7p0y3O2HXVHsLh9QIAApavLaefhnO4hqYqdo9Qpld+KiFJTPppVbptN2RSNsaz49TCLhhZSzy xYQ== X-Google-Smtp-Source: AGHT+IGD/CyjfBELvEbYsCtUWZsVlWj7blLDnOBRWFq6FyZfpfS17EPLyXMuWLDoT5AXl6t+qOH0IQ== X-Received: by 2002:ac2:4649:0:b0:52c:e170:9d38 with SMTP id 2adb3069b0e04-5309b27be4fmr5787878e87.31.1722258915449; Mon, 29 Jul 2024 06:15:15 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52fd5c19dcfsm1489047e87.218.2024.07.29.06.15.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 06:15:13 -0700 (PDT) Date: Mon, 29 Jul 2024 16:15:11 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20240725082504.883576-1-martin@martin.st> Message-ID: References: <20240725082504.883576-1-martin@martin.st> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [GASPP PATCH] Omit the "-c" argument from the preprocessing command X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-15"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 25 Jul 2024, Martin Storsj=F6 wrote: > A command like "cc -c -E" is tautological; the -c is ignored, when > we explicitly specify that we want to preprocess only. > > Since > https://github.com/llvm/llvm-project/commit/6461e537815f7fa68cef068425053= 53cf5600e9c > and https://github.com/llvm/llvm-project/pull/98607, Clang now > warns about the unused "-c" argument in this case. > > We already did omit the "-c" argument when preprocessing > (with cl.exe) for armasm, but do this for other cases as well. > --- > gas-preprocessor.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl > index 19b0131..aa3abc0 100755 > --- a/gas-preprocessor.pl > +++ b/gas-preprocessor.pl > @@ -155,6 +155,8 @@ while ($index < $#preprocess_c_cmd) { > $index++; > } > > +@preprocess_c_cmd =3D grep ! /^-c$/, @preprocess_c_cmd; > + > my $tempfile; > if ($as_type ne "armasm") { > @gcc_cmd =3D map { /\.[csS]$/ ? qw(-x assembler -) : $_ } @gcc_cmd; > @@ -163,7 +165,6 @@ if ($as_type ne "armasm") { > # Clang warns about unused -D parameters when invoked with "-x assemb= ler". > @gcc_cmd =3D grep ! /^-D/, @gcc_cmd; > } else { > - @preprocess_c_cmd =3D grep ! /^-c$/, @preprocess_c_cmd; > @preprocess_c_cmd =3D grep ! /^-m/, @preprocess_c_cmd; > > @preprocess_c_cmd =3D grep ! /^-G/, @preprocess_c_cmd; > -- = > 2.34.1 Will push this soon. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".