[FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup

[FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup

[Michael Niedermayer]

Fixes: abort()
Fixes: 64232/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5417957987319808

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/cbs_vp8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c
index 01d4b9cefef..065156c2485 100644
--- a/libavcodec/cbs_vp8.c
+++ b/libavcodec/cbs_vp8.c
@@ -307,7 +307,7 @@ static int cbs_vp8_read_unit(CodedBitstreamContext *ctx,
     frame = unit->content;
 
     // Create GetBitContext for uncompressed header.
-    err = init_get_bits8_le(&gbc, unit->data, 8 * unit->data_size);
+    err = init_get_bits8_le(&gbc, unit->data, unit->data_size);
     if (err < 0)
         return err;
 
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup

[James Almer]

On 12/17/2023 10:18 AM, Michael Niedermayer wrote:
> Fixes: abort()
> Fixes: 64232/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5417957987319808
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>   libavcodec/cbs_vp8.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c
> index 01d4b9cefef..065156c2485 100644
> --- a/libavcodec/cbs_vp8.c
> +++ b/libavcodec/cbs_vp8.c
> @@ -307,7 +307,7 @@ static int cbs_vp8_read_unit(CodedBitstreamContext *ctx,
>       frame = unit->content;
>   
>       // Create GetBitContext for uncompressed header.
> -    err = init_get_bits8_le(&gbc, unit->data, 8 * unit->data_size);
> +    err = init_get_bits8_le(&gbc, unit->data, unit->data_size);
>       if (err < 0)
>           return err;

LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup

[Dai, Jianhui J]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael
> Niedermayer
> Sent: Sunday, December 17, 2023 9:19 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup
> 
> Fixes: abort()
> Fixes: 64232/clusterfuzz-testcase-minimized-
> ffmpeg_BSF_TRACE_HEADERS_fuzzer-5417957987319808
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-
> fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/cbs_vp8.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c index
> 01d4b9cefef..065156c2485 100644
> --- a/libavcodec/cbs_vp8.c
> +++ b/libavcodec/cbs_vp8.c
> @@ -307,7 +307,7 @@ static int cbs_vp8_read_unit(CodedBitstreamContext
> *ctx,
>      frame = unit->content;
> 
>      // Create GetBitContext for uncompressed header.
> -    err = init_get_bits8_le(&gbc, unit->data, 8 * unit->data_size);
> +    err = init_get_bits8_le(&gbc, unit->data, unit->data_size);
>      if (err < 0)
>          return err;
> 

My bad. Thank for fixing it.

> --
> 2.17.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with
> subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".