* [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup
@ 2023-12-17 13:18 Michael Niedermayer
2023-12-17 15:18 ` James Almer
2023-12-18 11:29 ` Dai, Jianhui J
0 siblings, 2 replies; 3+ messages in thread
From: Michael Niedermayer @ 2023-12-17 13:18 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Fixes: abort()
Fixes: 64232/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5417957987319808
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavcodec/cbs_vp8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c
index 01d4b9cefef..065156c2485 100644
--- a/libavcodec/cbs_vp8.c
+++ b/libavcodec/cbs_vp8.c
@@ -307,7 +307,7 @@ static int cbs_vp8_read_unit(CodedBitstreamContext *ctx,
frame = unit->content;
// Create GetBitContext for uncompressed header.
- err = init_get_bits8_le(&gbc, unit->data, 8 * unit->data_size);
+ err = init_get_bits8_le(&gbc, unit->data, unit->data_size);
if (err < 0)
return err;
--
2.17.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup
2023-12-17 13:18 [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup Michael Niedermayer
@ 2023-12-17 15:18 ` James Almer
2023-12-18 11:29 ` Dai, Jianhui J
1 sibling, 0 replies; 3+ messages in thread
From: James Almer @ 2023-12-17 15:18 UTC (permalink / raw)
To: ffmpeg-devel
On 12/17/2023 10:18 AM, Michael Niedermayer wrote:
> Fixes: abort()
> Fixes: 64232/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5417957987319808
>
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavcodec/cbs_vp8.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c
> index 01d4b9cefef..065156c2485 100644
> --- a/libavcodec/cbs_vp8.c
> +++ b/libavcodec/cbs_vp8.c
> @@ -307,7 +307,7 @@ static int cbs_vp8_read_unit(CodedBitstreamContext *ctx,
> frame = unit->content;
>
> // Create GetBitContext for uncompressed header.
> - err = init_get_bits8_le(&gbc, unit->data, 8 * unit->data_size);
> + err = init_get_bits8_le(&gbc, unit->data, unit->data_size);
> if (err < 0)
> return err;
LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup
2023-12-17 13:18 [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup Michael Niedermayer
2023-12-17 15:18 ` James Almer
@ 2023-12-18 11:29 ` Dai, Jianhui J
1 sibling, 0 replies; 3+ messages in thread
From: Dai, Jianhui J @ 2023-12-18 11:29 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Michael
> Niedermayer
> Sent: Sunday, December 17, 2023 9:19 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup
>
> Fixes: abort()
> Fixes: 64232/clusterfuzz-testcase-minimized-
> ffmpeg_BSF_TRACE_HEADERS_fuzzer-5417957987319808
>
> Found-by: continuous fuzzing process https://github.com/google/oss-
> fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavcodec/cbs_vp8.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c index
> 01d4b9cefef..065156c2485 100644
> --- a/libavcodec/cbs_vp8.c
> +++ b/libavcodec/cbs_vp8.c
> @@ -307,7 +307,7 @@ static int cbs_vp8_read_unit(CodedBitstreamContext
> *ctx,
> frame = unit->content;
>
> // Create GetBitContext for uncompressed header.
> - err = init_get_bits8_le(&gbc, unit->data, 8 * unit->data_size);
> + err = init_get_bits8_le(&gbc, unit->data, unit->data_size);
> if (err < 0)
> return err;
>
My bad. Thank for fixing it.
> --
> 2.17.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with
> subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-18 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-17 13:18 [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup Michael Niedermayer
2023-12-17 15:18 ` James Almer
2023-12-18 11:29 ` Dai, Jianhui J
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git