From: Stephen Hutchinson <qyot27@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/4] avformat/avisynth: move avs_planes* consts into relevant function
Date: Tue, 13 Aug 2024 15:20:17 -0400
Message-ID: <cd1e2e95-41bc-4ef1-a7db-a80349b93c72@gmail.com> (raw)
In-Reply-To: <20240729044340.17459-1-qyot27@gmail.com>
On 7/29/24 12:43 AM, Stephen Hutchinson wrote:
> These consts are only used in the switch(planar) case located in
> avisynth_create_stream_video and nowhere else in the demuxer,
> so move them into that function directly.
>
> Signed-off-by: Stephen Hutchinson <qyot27@gmail.com>
> ---
> libavformat/avisynth.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c
> index b91d77b8d8..cb2be10925 100644
> --- a/libavformat/avisynth.c
> +++ b/libavformat/avisynth.c
> @@ -118,17 +118,6 @@ typedef struct AviSynthContext {
> struct AviSynthLibrary avs_library;
> } AviSynthContext;
>
> -static const int avs_planes_packed[1] = { 0 };
> -static const int avs_planes_grey[1] = { AVS_PLANAR_Y };
> -static const int avs_planes_yuv[3] = { AVS_PLANAR_Y, AVS_PLANAR_U,
> - AVS_PLANAR_V };
> -static const int avs_planes_rgb[3] = { AVS_PLANAR_G, AVS_PLANAR_B,
> - AVS_PLANAR_R };
> -static const int avs_planes_yuva[4] = { AVS_PLANAR_Y, AVS_PLANAR_U,
> - AVS_PLANAR_V, AVS_PLANAR_A };
> -static const int avs_planes_rgba[4] = { AVS_PLANAR_G, AVS_PLANAR_B,
> - AVS_PLANAR_R, AVS_PLANAR_A };
> -
> static av_cold int avisynth_load_library(AviSynthContext *avs)
> {
> avs->avs_library.library = dlopen(AVISYNTH_LIB, RTLD_NOW | RTLD_LOCAL);
> @@ -225,6 +214,17 @@ static int avisynth_create_stream_video(AVFormatContext *s, AVStream *st)
> int sar_num = 1;
> int sar_den = 1;
>
> + static const int avs_planes_packed[1] = { 0 };
> + static const int avs_planes_grey[1] = { AVS_PLANAR_Y };
> + static const int avs_planes_yuv[3] = { AVS_PLANAR_Y, AVS_PLANAR_U,
> + AVS_PLANAR_V };
> + static const int avs_planes_rgb[3] = { AVS_PLANAR_G, AVS_PLANAR_B,
> + AVS_PLANAR_R };
> + static const int avs_planes_yuva[4] = { AVS_PLANAR_Y, AVS_PLANAR_U,
> + AVS_PLANAR_V, AVS_PLANAR_A };
> + static const int avs_planes_rgba[4] = { AVS_PLANAR_G, AVS_PLANAR_B,
> + AVS_PLANAR_R, AVS_PLANAR_A };
> +
> st->codecpar->codec_type = AVMEDIA_TYPE_VIDEO;
> st->codecpar->codec_id = AV_CODEC_ID_RAWVIDEO;
> st->codecpar->width = avs->vi->width;
Pushed.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-08-13 19:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 16:56 [FFmpeg-devel] [PATCH 1/2 v2] avformat/avisynth: remove atexit() handler Stephen Hutchinson
2024-07-19 16:56 ` [FFmpeg-devel] [PATCH 2/2 v2] avformat/avisynth: remove mutex lock from avisynth_read_close Stephen Hutchinson
2024-08-13 19:19 ` Stephen Hutchinson
2024-07-28 5:37 ` [FFmpeg-devel] [PATCH 1/2 v2] avformat/avisynth: remove atexit() handler Stephen Hutchinson
2024-07-28 13:38 ` Ramiro Polla
2024-07-28 15:59 ` Stephen Hutchinson
2024-08-11 20:08 ` Stephen Hutchinson
2024-07-29 4:43 ` [FFmpeg-devel] [PATCH 3/4] avformat/avisynth: remove library allocation from global state Stephen Hutchinson
2024-08-13 19:19 ` Stephen Hutchinson
2024-07-29 4:43 ` [FFmpeg-devel] [PATCH 4/4] avformat/avisynth: move avs_planes* consts into relevant function Stephen Hutchinson
2024-08-13 19:20 ` Stephen Hutchinson [this message]
2024-08-13 19:19 ` [FFmpeg-devel] [PATCH 1/2 v2] avformat/avisynth: remove atexit() handler Stephen Hutchinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd1e2e95-41bc-4ef1-a7db-a80349b93c72@gmail.com \
--to=qyot27@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git