Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsvdec: return 0 if more data is required
Date: Mon, 4 Dec 2023 04:20:54 +0000
Message-ID: <cd1212f0c2a4d0d7f98f959ddf0bd66e9e3a9d0b.camel@intel.com> (raw)
In-Reply-To: <20231127060151.2435971-1-haihao.xiang@intel.com>

On Ma, 2023-11-27 at 14:01 +0800, Xiang, Haihao wrote:
> From: Haihao Xiang <haihao.xiang@intel.com>
> 
> The type of qsv decoders is FF_CODEC_CB_TYPE_DECODE which must not
> return AVERROR(EAGAIN). commit 42b20c9 added an assertion to check the
> returned value.
> 
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> ---
>  libavcodec/qsvdec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c
> index da700f25e9..b501964089 100644
> --- a/libavcodec/qsvdec.c
> +++ b/libavcodec/qsvdec.c
> @@ -1076,6 +1076,9 @@ static int qsv_decode_frame(AVCodecContext *avctx,
> AVFrame *frame,
>  
>          ret = qsv_process_data(avctx, &s->qsv, frame, got_frame, &s-
> >buffer_pkt);
>          if (ret < 0){
> +            if (ret == AVERROR(EAGAIN))
> +                ret = 0;
> +
>              /* Drop buffer_pkt when failed to decode the packet. Otherwise,
>                 the decoder will keep decoding the failure packet. */
>              av_packet_unref(&s->buffer_pkt);

Will apply the patchset, 

Thanks
Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      parent reply	other threads:[~2023-12-04  4:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27  6:01 Xiang, Haihao
2023-11-27  6:01 ` [FFmpeg-devel] [PATCH 2/2] lavc/qsvdec: reduce info message when " Xiang, Haihao
2023-12-04  4:20 ` Xiang, Haihao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd1212f0c2a4d0d7f98f959ddf0bd66e9e3a9d0b.camel@intel.com \
    --to=haihao.xiang-at-intel.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git