From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 91A1046CF3 for ; Sun, 9 Jul 2023 03:45:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D47568C581; Sun, 9 Jul 2023 06:45:10 +0300 (EEST) Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AAA2468C2A0 for ; Sun, 9 Jul 2023 06:45:02 +0300 (EEST) Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4QzCgv6zHGz9sb7 for ; Sun, 9 Jul 2023 05:44:59 +0200 (CEST) Message-ID: Date: Sun, 9 Jul 2023 09:14:46 +0530 MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org References: <20230708184502.66917-1-leo.izen@gmail.com> <9262e3b3-8851-de22-7980-2e8d4985f185@gmail.com> Content-Language: en-US From: Gyan Doshi In-Reply-To: <9262e3b3-8851-de22-7980-2e8d4985f185@gmail.com> X-Rspamd-Queue-Id: 4QzCgv6zHGz9sb7 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: build against libjxl 0.9 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2023-07-09 01:00 am, Leo Izen wrote: > On 7/8/23 15:25, Gyan Doshi wrote: >> >> >> On 2023-07-09 12:15 am, Leo Izen wrote: >>> Git master libjxl changed several function signatures, so this commit >>> adds some #ifdefs to handle the new signatures without breaking old >>> releases. >> >> Same objection as to the patch submitted a few days ago, pasted below: >> >> ---- >> 0.9.0 is still unreleased and unfortunately the API change wasn't >> accompanied with a version bump. >> >> The API changes were pushed on Jun 21st and the version bump to 0.9.0 >> was pushed on Jan 12th. >> So this will still break compilation with older git checkouts of >> libjxl. Ideally libjxl should bump once more to 0.9.1 >> ---- >> >> Regards, >> Gyan >> > > Oh, I missed that patch. > > In either case, why do we care about breaking old development versions > that aren't releases? Ok. Just make a note in the commit msg then. Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".