From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: build against libjxl 0.9
Date: Sun, 9 Jul 2023 09:14:46 +0530
Message-ID: <ccfe4224-f8e4-995a-d9bb-0d9d615bb5a4@gyani.pro> (raw)
In-Reply-To: <9262e3b3-8851-de22-7980-2e8d4985f185@gmail.com>
On 2023-07-09 01:00 am, Leo Izen wrote:
> On 7/8/23 15:25, Gyan Doshi wrote:
>>
>>
>> On 2023-07-09 12:15 am, Leo Izen wrote:
>>> Git master libjxl changed several function signatures, so this commit
>>> adds some #ifdefs to handle the new signatures without breaking old
>>> releases.
>>
>> Same objection as to the patch submitted a few days ago, pasted below:
>>
>> ----
>> 0.9.0 is still unreleased and unfortunately the API change wasn't
>> accompanied with a version bump.
>>
>> The API changes were pushed on Jun 21st and the version bump to 0.9.0
>> was pushed on Jan 12th.
>> So this will still break compilation with older git checkouts of
>> libjxl. Ideally libjxl should bump once more to 0.9.1
>> ----
>>
>> Regards,
>> Gyan
>>
>
> Oh, I missed that patch.
>
> In either case, why do we care about breaking old development versions
> that aren't releases?
Ok. Just make a note in the commit msg then.
Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-09 3:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 18:45 Leo Izen
2023-07-08 19:25 ` Gyan Doshi
2023-07-08 19:30 ` Leo Izen
2023-07-09 3:44 ` Gyan Doshi [this message]
2023-07-10 20:27 ` Leo Izen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccfe4224-f8e4-995a-d9bb-0d9d615bb5a4@gyani.pro \
--to=ffmpeg@gyani.pro \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git