Re: [FFmpeg-devel] [PATCH] ffmpeg: fix implementation of updated input start time

[Gyan Doshi <ffmpeg@gyani.pro>]

On 2022-10-14 06:49 pm, Jan Ekström wrote:
> On Tue, Sep 27, 2022 at 7:41 AM Gyan Doshi <ffmpeg@gyani.pro> wrote:
>> The current adjustment of input start times just adjusts the tsoffset.
>> And it does so, by resetting the tsoffset to nullify the new start time.
>> This leads to breakage of -copyts, ignoring of user_ts_offset, breaking
>> of -isync as well as breaking wrap correction.
>>
>> Fixed by taking cognizance of these parameters, and by correcting start
>> times just before sync offsets are applied.
> Out of interest and sorry for not testing this myself: does this
> improve the current state of affairs with itsoffset with discontinuous
> inputs like MPEG-TS?

I just recompute the tsoffset the same way but with the effective new 
start time.

> Until now the offset was put together with a whole bunch of other
> things, which led to logic which was supposed to only start the input
> at PTS=0 to also take out the configured itsoffset at the same time
> (since both the user defined offset as well as the format start time
> offset were both chunked into the same thing).

That's not my experience.
If the itsoffset is 5 and the first packet timestamp is 40, then only 
the 40 is negated and the packet is relayed with a ts of 5.
Isn't that what's expected?

Regards,
Gyan


>
> Cheers,
> Jan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".