From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id EDF554BFB3 for ; Mon, 28 Jul 2025 02:58:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1964568D6EA; Mon, 28 Jul 2025 05:58:29 +0300 (EEST) Received: from send173.i.mail.ru (send173.i.mail.ru [95.163.59.12]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id F2B2768D432 for ; Mon, 28 Jul 2025 05:58:22 +0300 (EEST) Received: by exim-smtp-848849d4f9-kkchq with esmtpa (envelope-from ) id 1ugE4C-000000002me-3gJs for ffmpeg-devel@ffmpeg.org; Mon, 28 Jul 2025 05:58:21 +0300 Content-Type: multipart/mixed; boundary="------------olUJdHckoRDzoac9d0V8eeOo" Message-ID: Date: Mon, 28 Jul 2025 07:58:18 +0500 MIME-Version: 1.0 User-Agent: Icedove Daily Content-Language: en-US To: ffmpeg-devel@ffmpeg.org X-Mailru-Src: smtp X-4EC0790: 1 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9C53E3E5CA923CF7CB615E2A4048F76B6584F141D38C82445182A05F53808504077D21884CDE341FB3DE06ABAFEAF6705DEBCA97B1119659A6D0215BC43ECF52A8CF6EBAD94FE6CB9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE755A2289DCA463BDAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566F080F430A3B1B6FD2346373C00B411C9A36979AD1C05B5863BB47E48C945511E8EEF46B7454FC60B9742502CCDD46D0DD6760E474F0469B4F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249A0EE70D6C4970CA7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10F618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEFAD5A440E159F97D9735652A29929C6C4AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3EEF1D49BC6E2BF4576E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A3927680F9384605B903F65A62F6C9828292C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5FF9ADD4A13B24FC35002B1117B3ED696C5F3BB75B636371FB91D2EB2DEE3878C823CB91A9FED034534781492E4B8EEAD0942DC5495D0595EC79554A2A72441328621D336A7BC284946AD531847A6065A535571D14F44ED41 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7161D15182FF9C9CFDDC8270968E61249B1004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34728AF701C68E45398CF4C21391E73A4B1D2ABC6685C03132D4B90E53D7165A4B4A97C2709B5AFF631D7E09C32AA3244C04378B3996C806DD77DD89D51EBB77422B0B5DC72A9F21C3EA455F16B58544A2C99F59F2F009F0963871D1C702CBDB0A0ADD6335840D67A2F0A6D2C91ED28CB6 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVU4HtwWQGdJGiahvtARMkrg= X-Mailru-Sender: 9E8E4BC2394856DE58015EE253C5AC10F79170D5B271670F1F93A76BF6F7B0A6796F1EE30A034A281F70F67D4A942BC4AE612CA5628006519D05D10692C02F823DDAF8CF51E8EB1316F5670CE7ACBB318BCC081D9D5610F3BE6FBB40ADBE433113D393D611A7C5823DDE9B364B0DF289AE208404248635DF X-Mras: Ok Subject: [FFmpeg-devel] [PATCH] libopenmpt: fix seeking X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: kimapr via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: kimapr Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is a multi-part message in MIME format. --------------olUJdHckoRDzoac9d0V8eeOo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch fixes strange seeking behavior i have observed in mpv when using the libopenmpt demuxer, caused by mismatch in position state between the demuxer and underlying libopenmpt library.  Not setting the presentation timestamp field of the AVPacket caused it to be guessed by libavformat, but the guess didn't take seeking into account, so after seeking libopenmpt produced packets at the new seeked position but they were then presented as if they belong to the old position!  A quick check for this behavior is to open a tracker tracker module that is, for example 2 minutes and a few seconds long in mpv, and then press "up" 2 times (which would seek 2 minutes forward): buggy demuxer causes mpv to exit immediately after seek because of an EOF,  with non-buggy demuxer mpv will play the last few seconds of the song and then exit. I found the bug when writing my own demuxer for an obscure audio format (which i'm not quite sure if i should submit too) as i was using the libopenmpt one as a reference and copied the bug too.  Testing was done on 6.1.1, but libopenmpt demuxer's code didn't really change since then so it should be relevant for the latest one too (unless the default value for pkt->pts changed to take seeking into account), and either way it makes more sense to expose information that is very much available to the demuxer rather than leave it to be guessed. --------------olUJdHckoRDzoac9d0V8eeOo Content-Type: text/x-patch; charset=UTF-8; name="0001-libopenmpt-fix-seeking.patch" Content-Disposition: attachment; filename="0001-libopenmpt-fix-seeking.patch" Content-Transfer-Encoding: base64 RnJvbSA0NTE2OTFmZWJhYzQ2NmNlZTM3ZDliODM2MjI4ZTMwYzUzODEzZDYwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLaW1hcHIgPGtpbWFwci5mckBnbWFpbC5jb20+CkRh dGU6IE1vbiwgMjggSnVsIDIwMjUgMDY6MzI6MjcgKzA1MDAKU3ViamVjdDogW1BBVENIXSBs aWJvcGVubXB0OiBmaXggc2Vla2luZwoKLS0tCiBsaWJhdmZvcm1hdC9saWJvcGVubXB0LmMg fCAzICsrKwogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L2xpYmF2Zm9ybWF0L2xpYm9wZW5tcHQuYyBiL2xpYmF2Zm9ybWF0L2xpYm9wZW5tcHQuYwpp bmRleCBjMjcwYTYwY2IyLi5kMzgzZDY1YWQ4IDEwMDY0NAotLS0gYS9saWJhdmZvcm1hdC9s aWJvcGVubXB0LmMKKysrIGIvbGliYXZmb3JtYXQvbGlib3Blbm1wdC5jCkBAIC0xNzEsNiAr MTcxLDggQEAgc3RhdGljIGludCByZWFkX3BhY2tldF9vcGVubXB0KEFWRm9ybWF0Q29udGV4 dCAqcywgQVZQYWNrZXQgKnBrdCkKICAgICBpZiAoKHJldCA9IGF2X25ld19wYWNrZXQocGt0 LCBBVURJT19QS1RfU0laRSkpIDwgMCkKICAgICAgICAgcmV0dXJuIHJldDsKIAorICAgIGRv dWJsZSBwb3MgPSBvcGVubXB0X21vZHVsZV9nZXRfcG9zaXRpb25fc2Vjb25kcyhvcGVubXB0 LT5tb2R1bGUpOworCiAgICAgc3dpdGNoIChvcGVubXB0LT5jaF9sYXlvdXQubmJfY2hhbm5l bHMpIHsKICAgICBjYXNlIDE6CiAgICAgICAgIHJldCA9IG9wZW5tcHRfbW9kdWxlX3JlYWRf ZmxvYXRfbW9ubyhvcGVubXB0LT5tb2R1bGUsIG9wZW5tcHQtPnNhbXBsZV9yYXRlLApAQCAt MTk1LDYgKzE5Nyw3IEBAIHN0YXRpYyBpbnQgcmVhZF9wYWNrZXRfb3Blbm1wdChBVkZvcm1h dENvbnRleHQgKnMsIEFWUGFja2V0ICpwa3QpCiAgICAgfQogCiAgICAgcGt0LT5zaXplID0g cmV0ICogKG9wZW5tcHQtPmNoX2xheW91dC5uYl9jaGFubmVscyAqIDQpOworICAgIHBrdC0+ cHRzID0gbGxyaW50KHBvcyAqIEFWX1RJTUVfQkFTRSk7CiAKICAgICByZXR1cm4gMDsKIH0K LS0gCjIuNDkuMAoK --------------olUJdHckoRDzoac9d0V8eeOo Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --------------olUJdHckoRDzoac9d0V8eeOo--