From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 51A744B462 for ; Wed, 5 Jun 2024 20:29:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C13BA68D68F; Wed, 5 Jun 2024 23:28:59 +0300 (EEST) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A216068D547 for ; Wed, 5 Jun 2024 23:28:53 +0300 (EEST) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-421392b8156so3178015e9.3 for ; Wed, 05 Jun 2024 13:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1717619333; x=1718224133; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3/8WNmZD/9McfKWGQ/FiP/fpHzVyskqzyug+wQ6czUk=; b=Q4gbQoM+zr753rrOlkE6jR5vOw9tCn4cT4Po3PxXZKN1kEZyqgXfFtjkYZs/Sg+FEc ZoasvZEGm/eKlizoJkcMbVyleCaI/l8JiArRvvJoaD6rQWqldWwEoBoaOgzeVj30L/Xg O9Pt9ASUBiwxbF9z0HjnNlV1LPC5JMObIPYvZ4wSUNd6x+DHPlCylgw8YY1TtZpsHwBh 4FWwIc1zgHRUarP/Am9QZetFyhzMSrZsMYUcLGA29bC+258lXDLmi+ILu5jalOXzjHZy 0qE/r1xhcNWgEXNziT5GA/O5n1TY9yyS1ESXHzbu8EPROukyynRm0zOvdithfV50exoX cxrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717619333; x=1718224133; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3/8WNmZD/9McfKWGQ/FiP/fpHzVyskqzyug+wQ6czUk=; b=XJHAvDrTHxif/eKcZaODa9zJDtv/lbUm/FUR+p0pK/8sJhDGL1n1Sm3Y87I+gjqL0C ZyEwRsTmSJ21InTjMDJJPDAsinROW9GgU+2T9YyvxRBa4hAzNr+i0TXZ1TPzTfweL+Ij W+EOETfg7dM825gDq8i2LisGCtNrWwzL0MwcskKjn8snfitJ/JMd076AIqt3SZppWurA R/uklVp5DuJoON48qY6bkak3cSiWeQ29NqNcp3Y7UvE5JSTI11TVsUJu6Zm9lfRuztub mIdx8DNPaKR2a7sbhRxeU9Zs42B4iqSL0rBtuBnRLhDIOV/azPza3CeH85MoWAx4v5QI o3pA== X-Gm-Message-State: AOJu0YzJj7qgcw5alNoAY2Ay80+6bNdQOn6wL+4lYNFgL8tFVmjJLw5Q JN2yLkFowY+HEqnErSF57YlTX8iN2wPX7ZG0FLroiuQAt9UzgF0otS0SRPm8aDQGDXK2sxbkYP9 a X-Google-Smtp-Source: AGHT+IEmDY0L0y+95QYLXzu5Sk2ji+qZ7GGztHfqIof9ByOKWYYpFXbcaoul/0hnaAnQWJZ6RHg/8w== X-Received: by 2002:a05:600c:1e02:b0:41a:e995:b915 with SMTP id 5b1f17b1804b1-421562c243emr27863015e9.1.1717619332883; Wed, 05 Jun 2024 13:28:52 -0700 (PDT) Received: from [192.168.0.15] (cpc92302-cmbg19-2-0-cust1183.5-4.cable.virginm.net. [82.1.212.160]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-421580fe3bfsm34523455e9.8.2024.06.05.13.28.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 13:28:52 -0700 (PDT) Message-ID: Date: Wed, 5 Jun 2024 21:29:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Mark Thompson In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 05/16] avutil: add common code for nvtegra X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 30/05/2024 20:43, averne wrote: > This includes a new pixel format for nvtegra hardware frames, and several objects for interaction with hardware blocks. > In particular, this contains code for channels (handles to hardware engines), maps (memory-mapped buffers shared with engines), and command buffers (abstraction for building command lists sent to the engines). > > Signed-off-by: averne > --- > configure | 2 + > libavutil/Makefile | 4 + > libavutil/nvtegra.c | 1035 ++++++++++++++++++++++++++++++++++++ > libavutil/nvtegra.h | 258 +++++++++ > libavutil/nvtegra_host1x.h | 94 ++++ > libavutil/pixdesc.c | 4 + > libavutil/pixfmt.h | 8 + > 7 files changed, 1405 insertions(+) > create mode 100644 libavutil/nvtegra.c > create mode 100644 libavutil/nvtegra.h > create mode 100644 libavutil/nvtegra_host1x.h I don't think it is reasonable for all of this to be public API surface of ffmpeg. A separate library containing the headers and exposing some set of functions like this might make more sense. If this has to be in ffmpeg then it really needs to all go in one library (libavcodec I guess) so that it's not exposing all this internal detail in the public API. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".