From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5DEB743F17 for ; Thu, 18 Aug 2022 09:18:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C26268BA09; Thu, 18 Aug 2022 12:18:17 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6754768BA06 for ; Thu, 18 Aug 2022 12:18:10 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 27I9I7Cc020203-27I9I7Cd020203; Thu, 18 Aug 2022 12:18:07 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 0F72AA144B; Thu, 18 Aug 2022 12:18:07 +0300 (EEST) Date: Thu, 18 Aug 2022 12:18:06 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Hubert Mazur In-Reply-To: <20220816122016.64929-5-hum@semihalf.com> Message-ID: References: <20220816122016.64929-1-hum@semihalf.com> <20220816122016.64929-5-hum@semihalf.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 4/5] lavc/aarch64: Add neon implementation for sse8 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, ffmpeg-devel@ffmpeg.org, mw@semihalf.com, spop@amazon.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 16 Aug 2022, Hubert Mazur wrote: > Provide optimized implementation of sse8 function for arm64. > > Performance comparison tests are shown below. > - sse_1_c: 130.7 > - sse_1_neon: 29.7 > > Benchmarks and tests run with checkasm tool on AWS Graviton 3. > > Signed-off-by: Hubert Mazur > --- > libavcodec/aarch64/me_cmp_init_aarch64.c | 4 ++ > libavcodec/aarch64/me_cmp_neon.S | 66 ++++++++++++++++++++++++ > 2 files changed, 70 insertions(+) > > diff --git a/libavcodec/aarch64/me_cmp_init_aarch64.c b/libavcodec/aarch64/me_cmp_init_aarch64.c > index 1c36d3d7cb..2f51f0497e 100644 > --- a/libavcodec/aarch64/me_cmp_init_aarch64.c > +++ b/libavcodec/aarch64/me_cmp_init_aarch64.c > @@ -34,9 +34,12 @@ int ff_pix_abs16_y2_neon(MpegEncContext *v, const uint8_t *pix1, const uint8_t * > > int sse16_neon(MpegEncContext *v, const uint8_t *pix1, const uint8_t *pix2, > ptrdiff_t stride, int h); > +int sse8_neon(MpegEncContext *v, const uint8_t *pix1, const uint8_t *pix2, > + ptrdiff_t stride, int h); > int sse4_neon(MpegEncContext *v, const uint8_t *pix1, const uint8_t *pix2, > ptrdiff_t stride, int h); Same as the others about function declaration indentation > diff --git a/libavcodec/aarch64/me_cmp_neon.S b/libavcodec/aarch64/me_cmp_neon.S > index 0ec9c0465b..3f4266d4d5 100644 > --- a/libavcodec/aarch64/me_cmp_neon.S > +++ b/libavcodec/aarch64/me_cmp_neon.S > @@ -347,6 +347,72 @@ function sse16_neon, export=1 > ret > endfunc > > +function sse8_neon, export=1 > + // x0 - unused > + // x1 - pix1 > + // x2 - pix2 > + // x3 - stride > + // w4 - h > + > + movi d18, #0 Same as the others about d18 > + movi v21.4s, #0 > + movi v20.4s, #0 > + cmp w4, #4 > + b.le 2f > + > +// make 4 iterations at once > +1: > + > + // res = abs(pix1[0] - pix2[0]) > + // res * res > + > + ld1 {v0.8b}, [x1], x3 // Load pix1 for first iteration > + ld1 {v1.8b}, [x2], x3 // Load pix2 for second iteration > + ld1 {v2.8b}, [x1], x3 // Load pix1 for second iteration > + ld1 {v3.8b}, [x2], x3 // Load pix2 for second iteration > + uabdl v30.8h, v0.8b, v1.8b // Absolute difference, first iteration > + ld1 {v4.8b}, [x1], x3 // Load pix1 for third iteration > + ld1 {v5.8b}, [x2], x3 // Load pix2 for third iteration > + uabdl v29.8h, v2.8b, v3.8b // Absolute difference, second iteration > + umlal v21.4s, v30.4h, v30.4h // Multiply lower half, first iteration > + ld1 {v6.8b}, [x1], x3 // Load pix1 for fourth iteration > + ld1 {v7.8b}, [x2], x3 // Load pix2 for fourth iteration > + uabdl v28.8h, v4.8b, v5.8b // Absolute difference, third iteration > + umlal v21.4s, v29.4h, v29.4h // Multiply lower half, second iteration > + umlal2 v20.4s, v30.8h, v30.8h // Multiply upper half, second iteration The comment was wrong here, this is about the first iteration, not the second one. > + uabdl v27.8h, v6.8b, v7.8b // Absolute difference, fourth iteration > + umlal v21.4s, v28.4h, v28.4h // Multiply lower half, third iteration > + umlal2 v20.4s, v29.8h, v29.8h // Multiply upper half, second iteration > + sub w4, w4, #4 // h -= 4 > + umlal2 v20.4s, v28.8h, v28.8h // Multiply upper half, third iteration > + umlal v21.4s, v27.4h, v27.4h // Multiply lower half, fourth iteration > + cmp w4, #4 > + umlal2 v20.4s, v27.8h, v27.8h // Multiply upper half, fourth iteration > + b.ge 1b > + > + cbz w4, 3f > + > +// iterate by one > +2: > + ld1 {v0.8b}, [x1], x3 // Load pix1 > + ld1 {v1.8b}, [x2], x3 // Load pix2 > + subs w4, w4, #1 > + uabdl v30.8h, v0.8b, v1.8b > + umlal v21.4s, v30.4h, v30.4h > + umlal2 v20.4s, v30.8h, v30.8h > + > + b.ne 2b > + > +3: > + add v21.4s, v21.4s, v20.4s // Add accumulator vectors together > + uaddlv d17, v21.4s // Add up vector > + add d18, d18, d17 > + Unnecesssary d18. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".