From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4161348CFE for ; Sun, 23 Jun 2024 11:05:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5DBDE68D47A; Sun, 23 Jun 2024 14:05:34 +0300 (EEST) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4D8EB68C2DF for ; Sun, 23 Jun 2024 14:05:27 +0300 (EEST) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4217d808034so29219455e9.3 for ; Sun, 23 Jun 2024 04:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719140725; x=1719745525; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wQUKAB2PVeJWkbiRDt9DEGNPGUmzyw/2K5zyJjSyuEA=; b=HefCIRBx7OeG64DEgdyP7XczWM8kIZNUzD/isvKNXchKLkoCgG3bsg90pOrmNX3uHz UEwrRYVdeg8CGo/vnxdQtJ5AxXNnQnxGgSrrxuRnhaf4cdRCC6s92mx/v588L5OjioTu qO6gNcu+v+xXFyZNzksOrVMKgdUmuPRso64eXXI4Dm/kZpqgMUyTJPbJLlEZjvbKFC90 envtIOt2UsjP9sSsfK0f21U6q2UgkPtv6y30z4ticdSuDUmOkTLHn5xktQi3BTvM+KpJ xwDzW7g7Ak/SlsCmQS7TFrksHXMcupRtdGEGJ5VUBPfNFm2orXDI6jfggIru/7SR6K+d dZ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719140725; x=1719745525; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wQUKAB2PVeJWkbiRDt9DEGNPGUmzyw/2K5zyJjSyuEA=; b=RvZWSBunRulJ2pClo/nPiHBs/nub3VyKcEKKDhorXcnf3FjrnCRLdwerAuNuDup4gA /UarL/JUneecJYpz46mJDh6N2IlsMv8sL08uzhIt2zmATM55iH0xPyfsZl2i48VEzAOW XniZ8qV9iCfVzbI5zr9Qtomb6+TEoj/frWdxgT63KJfswESGKUB7Qxj8F6d5pEOgOPXL 4O13PxhkRDVywUsm1DyaU+NgbJGSIvpVD1HRMtdrPWbI7Ac+uen9SuQ8gs+aLHWnwv3K AiyH0Psb6q/uvWbw7x9KkmookAVcTTTEY3S7GP6x4T2nJy51dJksdo8SY849WQp4YeXN WMdQ== X-Gm-Message-State: AOJu0YwjO2EpZlEe7kKHTSeYpjQPwTGjQWZtU2UIUA/x63XjOoUJABU/ 2X6DkYoFRW8jLp8rt7QadmoZLcdmtoJxNkKro1WTO+ErqNHMsoOAtAkzfg== X-Google-Smtp-Source: AGHT+IGYcdmBApOp0LEysN6q3vlTgvepg9FLfPpRLh+aC27PBSwbfu9LB9vWeCJbKMKTZ2/AepGcTQ== X-Received: by 2002:a05:600c:5108:b0:424:7e33:b9fa with SMTP id 5b1f17b1804b1-4248cc182bcmr13998765e9.0.1719140725065; Sun, 23 Jun 2024 04:05:25 -0700 (PDT) Received: from [192.168.1.106] (0540dce9.skybroadband.com. [5.64.220.233]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4247d0c54d9sm139560745e9.28.2024.06.23.04.05.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jun 2024 04:05:24 -0700 (PDT) Message-ID: Date: Sun, 23 Jun 2024 12:05:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: ffmpeg-devel@ffmpeg.org References: <20240622201116.403924-1-dev@lynne.ee> From: Derek Buitenhuis In-Reply-To: <20240622201116.403924-1-dev@lynne.ee> Subject: Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/22/2024 9:11 PM, Lynne via ffmpeg-devel wrote: > The API was committed 2 days ago, so changing these fields now > is within the realms of acceptable. > --- You also had weeks to comment on 3 revisions of the set, and it would have been nice to hear about this then instead of changing it after I've already pushed and integrated it in my own downstream work. If I sound grumpy, it's because I am... the set sat commentless. > diff --git a/libavutil/stereo3d.h b/libavutil/stereo3d.h > index 00a5c3900e..097f6c9455 100644 > --- a/libavutil/stereo3d.h > +++ b/libavutil/stereo3d.h > @@ -213,9 +213,9 @@ typedef struct AVStereo3D { > > /** > * The distance between the centres of the lenses of the camera system, > - * in micrometers. Zero if unset. > + * in meters. Zero if unset. > */ > - uint32_t baseline; > + AVRational baseline; Can't be AVRational for the reason James mentioned, uint32_t can't be put in an int, and can't be negative. Also, in terms of units, using meters here is silly, it's the distance between two lenses, meters is an crazy unit to measure that in, not idiomatic at all, and I would argue violates the principal of least surprise (both in terms of units, and being a distance as a rational). > /** > - * Horizontal field of view in thousanths of a degree. Zero if unset. > + * Horizontal field of view, in degrees. Zero if unset. > */ > - uint32_t horizontal_field_of_view; > + AVRational horizontal_field_of_view; > } AVStereo3D; This one is more reasonable. I am not happy about the post-push change, but if the community wants this one, I am not going to block it. > +horizontal_field_of_view=0/0 If it is changed, this should be initialized to 0/1, as that is what James last set did for the rest of all side data. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".