Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include show-graph wrapper script in build output
Date: Wed, 11 Jun 2025 21:18:05 +0200 (CEST)
Message-ID: <cbc32aab-6fa0-cde1-791d-d19eeccfedfb@passwd.hu> (raw)
In-Reply-To: <08e01d9ad96b56dac6f0f1f0912e0aa94f80e8d0.1749497028.git.ffmpegagent@gmail.com>



On Mon, 9 Jun 2025, softworkz wrote:

> From: softworkz <softworkz@hotmail.com>
>
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
> .gitignore       |  1 +
> fftools/Makefile | 14 ++++++++++++--
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index 59c89da5e0..989c702b6c 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -32,6 +32,7 @@
> /.config
> /.version
> /ffmpeg
> +/ffmpeg-sg

Please, do not copy this from tools folder to the main build dir. The rest 
of the tools are also simply kept in the tools folder, no copying is 
necessary during the build process.

Thanks,
Marton

> /ffplay
> /ffprobe
> /config.asm
> diff --git a/fftools/Makefile b/fftools/Makefile
> index b3c08ae5a0..378de79665 100644
> --- a/fftools/Makefile
> +++ b/fftools/Makefile
> @@ -5,6 +5,11 @@ AVPROGS-$(CONFIG_FFPROBE)  += ffprobe
> AVPROGS     := $(AVPROGS-yes:%=%$(PROGSSUF)$(EXESUF))
> PROGS       += $(AVPROGS)
>
> +FFMPEG_SG_SCRIPT = $(SRC_PATH)/tools/ffmpeg-sg$(if $(filter .exe,$(EXESUF)),.cmd)
> +FFMPEG_SG_TARGET = ffmpeg-sg$(EXESUF)
> +FFMPEG_SG_ENABLED = $(and $(filter $(CONFIG_FFMPEG),yes),$(or $(filter $(target_os),win32),$(if $(target_os),,yes)))
> +FFMPEG_SG_FILES = $(if $(FFMPEG_SG_ENABLED),$(FFMPEG_SG_TARGET))
> +
> AVBASENAMES  = ffmpeg ffplay ffprobe
> ALLAVPROGS   = $(AVBASENAMES:%=%$(PROGSSUF)$(EXESUF))
> ALLAVPROGS_G = $(AVBASENAMES:%=%$(PROGSSUF)_g$(EXESUF))
> @@ -67,7 +72,10 @@ endef
>
> $(foreach P,$(AVPROGS-yes),$(eval $(call DOFFTOOL,$(P))))
>
> -all: $(AVPROGS)
> +all: $(AVPROGS) $(FFMPEG_SG_FILES)
> +
> +$(FFMPEG_SG_TARGET): $(FFMPEG_SG_SCRIPT)
> +	$(Q)$(CP) -p $(FFMPEG_SG_SCRIPT) $(FFMPEG_SG_TARGET)
>
> fftools/ffprobe.o fftools/cmdutils.o: libavutil/ffversion.h | fftools
> OUTDIRS += fftools
> @@ -85,11 +93,13 @@ install-progs-$(CONFIG_SHARED): install-libs
> install-progs: install-progs-yes $(AVPROGS)
> 	$(Q)mkdir -p "$(BINDIR)"
> 	$(INSTALL) -c -m 755 $(AVPROGS) "$(BINDIR)"
> +	$(if $(FFMPEG_SG_FILES),$(INSTALL) -c -m 755 $(FFMPEG_SG_FILES) "$(BINDIR)")
>
> uninstall: uninstall-progs
>
> uninstall-progs:
> 	$(RM) $(addprefix "$(BINDIR)/", $(ALLAVPROGS))
> +	$(if $(FFMPEG_SG_FILES),$(RM) "$(BINDIR)/$(FFMPEG_SG_FILES)")
>
> clean::
> -	$(RM) $(ALLAVPROGS) $(ALLAVPROGS_G) $(CLEANSUFFIXES:%=fftools/%) $(CLEANSUFFIXES:%=fftools/graph/%) $(CLEANSUFFIXES:%=fftools/textformat/%)
> +	$(RM) $(ALLAVPROGS) $(ALLAVPROGS_G) $(CLEANSUFFIXES:%=fftools/%) $(CLEANSUFFIXES:%=fftools/graph/%) $(CLEANSUFFIXES:%=fftools/textformat/%) $(FFMPEG_SG_FILES)
> -- 
> ffmpeg-codebot
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-06-11 19:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 19:23 [FFmpeg-devel] [PATCH 0/3] tools/ffmpeg-sg: Add show-graph wrapper scripts (aka killer feature) ffmpegagent
2025-06-09 19:23 ` [FFmpeg-devel] [PATCH 1/3] tools/ffmpeg-sg: Add show-graph wrapper script for Linux softworkz
2025-06-09 19:23 ` [FFmpeg-devel] [PATCH 2/3] tools/ffmpeg-sg: Add show-graph wrapper script for Windows softworkz
2025-06-09 19:23 ` [FFmpeg-devel] [PATCH 3/3] tools/ffmpeg-sg: Include show-graph wrapper script in build output softworkz
2025-06-11 19:18   ` Marton Balint [this message]
2025-06-11 20:58     ` softworkz .
2025-06-11 21:14       ` Kieran Kunhya via ffmpeg-devel
     [not found]       ` <CABGuwEm72Ynf=anVta4rj0pOPThHeM0aweAbYVTBuvLsQSbJ4Q@mail.gmail.com>
2025-06-11 21:39         ` softworkz .
2025-06-11 22:04         ` softworkz .
2025-06-12  7:40       ` Nicolas George
2025-06-12 18:42         ` softworkz .
2025-06-12 19:06           ` Nicolas George
2025-06-12 19:20             ` softworkz .
2025-06-09 22:49 ` [FFmpeg-devel] [PATCH 0/3] tools/ffmpeg-sg: Add show-graph wrapper scripts (aka killer feature) Kieran Kunhya via ffmpeg-devel
2025-06-11 14:42   ` Nicolas George
     [not found] ` <CABGuwEnDSAKEEP6e5yUzeXM_bp5EKV2bPHaL8+wM+Pbmm5KBPQ@mail.gmail.com>
2025-06-10 13:31   ` softworkz .
2025-06-10 15:28     ` softworkz .

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbc32aab-6fa0-cde1-791d-d19eeccfedfb@passwd.hu \
    --to=cus@passwd.hu \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git