From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A751C43018 for ; Thu, 13 Jan 2022 07:32:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1D78E68B3FF; Thu, 13 Jan 2022 09:32:26 +0200 (EET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C774068B169 for ; Thu, 13 Jan 2022 09:32:19 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642059145; x=1673595145; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=EKem/g6Nn4ga7aZFSbgRaAX4IWZmaYIlg2xzV06J2bs=; b=gX9qFHcE3Et4DcN7Vid7RzGY2Dk2mm30Qv1UVBKheZd+vIFKcp6Kimc9 Txp+SKCzPtWNJe+XaHDvwGv0Oxg5AfKjphH5BTpJV65WM6DppdtaIxKrx 4X/kA/rwdsKmHRwyLOeL9dbwtl3YUhxuXPJ/NsZSrnMzX0FBiveABXju8 XtCeA5cM5/WGfIqyGNSrsxtSL47+iSAoaeDSo8m7kBO6e6lfs3hqYIVBw o45Rb6EVUvAziMWoKeOK+96tDDazwC2b3nosnMVB1jnAqfvjdIePO4DbJ AL4RxzXx+liY+cS9Yn7gON1eb6v71/hbOQOSKJQM9pwwrv4/pGKDRgUuG Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="223933222" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="223933222" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 23:32:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="491042190" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 12 Jan 2022 23:32:17 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 23:32:16 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 23:32:16 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 23:32:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mxweWKCzrTIds+OiQY+u7VlmPZ5CiJh32TkBWTz2onHiKN6oaDvdsGEBzSjsnxHx/kg0Mkso1bQeWKuwqNROAG9Mng8yBmYdPz2nGqoDiPHEAhhEsSX/O9uS2San+KXwqVsFzdQSwjW3pZz0tHLPMO3ROsEz786mW/CSv/t2/NbB4Fx6xGBobdAHevRAVrmo4ltybfH88ZjFgCgh6ph2/MqzXjHt6jJEYXthFsLLTRCyK2IkceGn3GlrgsJW6rwVAlEJqIHB702YN9ZysYmaxDCQpUTW97e70MbuIl2xX8o8Wz1dwTABaOhF8F7jNB7PRkA8HbKpL9e9/wfpRuCwlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EKem/g6Nn4ga7aZFSbgRaAX4IWZmaYIlg2xzV06J2bs=; b=REPack9WWqc0mFzthERd9RIK9XyMIwSYyafj9UM0GVexSY3kb1cslhz8A1XOKMoCNATbF+KxeryFMDX4lszqxObWmn1z3FMmTsAtBIxBI+WnkzU0yqWmk/UKDLyXeMXbqv6VMBaeVX7Y5cPb7XSuRUvophXRIpYGm2/TkLycrISg649nirhzlpCKohzHgvO5CxJzhwWNKlZXKa2N+N2dP09k+n24QQrqnDMeyQNtxSFSB25u5+YJYhelD2sUnb7f9ixtXA6Nxwi9kZhp5dcDpQkEmbvv1uMTPVguG0HjbBvbygSSjSIWBHKdIf3Olu3HFdbIc7NVdQE7q9HzwC6+bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN8PR11MB3794.namprd11.prod.outlook.com (2603:10b6:408:8f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Thu, 13 Jan 2022 07:32:15 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%6]) with mapi id 15.20.4867.012; Thu, 13 Jan 2022 07:32:15 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH V3 4/4] libavcodec/qsvenc: Add transform skip to hevc_qsv Thread-Index: AQHYCDyGts0B4wGu20a4WJawpeQ/SKxgjuIA Date: Thu, 13 Jan 2022 07:32:15 +0000 Message-ID: References: <20220113051221.66453-1-wenbin.chen@intel.com> <20220113051221.66453-4-wenbin.chen@intel.com> In-Reply-To: <20220113051221.66453-4-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9db77b73-7dbe-45b0-55f0-08d9d666d24d x-ms-traffictypediagnostic: BN8PR11MB3794:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jf2mKpa3+EhpTZTk03SYLfk4Oudyw9pUyLzBm4fdZhr7sb2Dbz2aM5xIi7MDp1TnwmZRinqOn/cKQa2LblvXFyftZljJAMR2czsI4zlBvDVCyoc0lfjED7rym77dDX2XJCp5WyQKeF/mrgLx+ZQXIztHpckJja8bPtBWzzS2rwGDRmbn7KspNqrGlMiDUl36pCtv0denirkP/no0SpvzS9nKv2ftQ2i8Y4GWVst9mmyLa2HjlSV5VP6MILiXvSMu3SNgeQNKk1iT7YWPUu6UbHZbsm45bWJDKokqmC8cxGlCm/D/rZOlqt1RFi70MfayuAPOc4nUyoeZWotQxyqzr7t/R/jubRdXUBzooucetZ68Hpd6jpGPg+pwElQTZdoT7OTL3hqfj5XBDw8w5aQNBNwx2hHkL9Qfknkb/wddlA7MsdZbDkj13F6r/bkkY6l1l9wK8mDi81R4D9I9cOn0PjF9P5fNZN5TxCKRnpVb9k2m0EWU+v5035a8+iEnOW9v7KSQPsfejAZsH4aHG59/GFEzc0ePFvB6Nj3/B/s3n2BmVlDE7fMoTac1JYp4B3dUqr2XnvlIT+h956O/dHdvS851aDzHsZld5ecpLkksGgtwTHUHagQbbWRObbY1pPaiH45mMK60wAS1I+EAOB19bnp5daBuIjdqj4odBcM0vJMOPvwwNde4gIMffE+39j2vM6ZpVS1zPvNHyQc0dTaugem6DwGh8IERzXKdwrWJ//c= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38070700005)(86362001)(82960400001)(36756003)(508600001)(2906002)(6506007)(6486002)(8676002)(2616005)(64756008)(66446008)(6916009)(66946007)(186003)(91956017)(76116006)(8936002)(26005)(38100700002)(122000001)(6512007)(316002)(5660300002)(83380400001)(71200400001)(66556008)(66476007)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YWRIazkyZXpEZkN4bVA5Q29vYXVzc3hzRjhxbkVZVDM4WXgvelpsZFpCc0pq?= =?utf-8?B?VkwyOUo4SitwZU1wY253NmJWc3VDWUxjM1JJSkM5Sm56YlZlNXVEUE5aV1lB?= =?utf-8?B?UUFnSGFFbEFNTWRVTTNYM0lGVWNBS05aM3dzUy9YZVI3dWlZdUE4RWs4OHd6?= =?utf-8?B?dUVaK3BtN250aHd5TUUvVXhJRHB1cjBNR2kvbE5tRnZ1OEVBM1EwT0U0ZlhX?= =?utf-8?B?ckhLUUFVV2pZWHdzZUpRUDh6UitKQUY3MGYzclZIMjl5MFJiTUhFd1ZXNzZj?= =?utf-8?B?SUtQaS9FUi9PcnFlQmJqcjZJcmpDM2F4S3ZQMU8xSzY2ZXdxbVQvcjRZMlEv?= =?utf-8?B?OWhzV0IwNVZnYmt3VGFWQ2VxeUxHMG9RaktuRStPTE8wSUhnVFp2WEcvMUZ0?= =?utf-8?B?WGFTVHhhMFZDQVdIa0plQTlxZTBVMDJwSUxrb0RqYXVzVHlPaEFJWG9uU2Jz?= =?utf-8?B?U1BBeVBCQjMvSHdRVDNpRGRRQzk0Q1dtWVVJbFZCRzloZHdMSTZoblI2NlZp?= =?utf-8?B?WjZTVkY4eEtRa2RVbXdDVFZiNFdYR3Q3bEt6Q0pCL3V3dXk1ekhEYmpCdFNk?= =?utf-8?B?dXlKRmJ2dWxWRklvbERTUUFqY1hBSnpGdUFBRjVVVm55aldLS2xBT0JSeE5r?= =?utf-8?B?OUdVS2hlUnRuU3YvakxHRjZyZFNUNXhaZGtCVFNsbFZ2RHlyTDYxcVVQNW9L?= =?utf-8?B?QUJEaSsxZ2FLbytsaVFQSzE4MzBCMGdMbDJFU3FpRnZmWjZ6SXVmVjc0WEE3?= =?utf-8?B?UnBsNVRxL0t1V1JjNTFaR0s0SUpaUWl6UGRlQ0RMMXhXMzhXY1VEb2JIT2Na?= =?utf-8?B?ZW00S2pVaVowaWY1Q0t6YmZKcWdRaXhscmxtUTFoUVNLNEZNTzR5dENMR0xI?= =?utf-8?B?UUsvOEVmNElxclVsUEVVbXpLWmt2RzdFdC9tY1Z3WVZvaVVyNHpXcWdXL1pW?= =?utf-8?B?TTBkZVhMS2tTRkZ3L1czcUlLUW5NS0NoWEQ5OTh4TlNtNmdLU1JxZlpOeXVS?= =?utf-8?B?S3pxZjU3dUU1VzcyNWlqUGt6c0hWMm1sZVJRYXp5OHJVZkJqT3FGaDduQXlZ?= =?utf-8?B?R2xESlVMQVdhbXBNR0FXMjVpVWI3WkZZMXpJaVMwNW9nR0tWNlNBeVFZY29s?= =?utf-8?B?MHpqcW9taFc1b0w4MUdOdklnaHMySnFTVDZJTE1kbkJWOXp3aUdKZGNtM1d0?= =?utf-8?B?RW9icGRVMUlOd000bndVaXNYNEFJTXhTRG9peTRjQzYzL3VIcVhxZHJYczhC?= =?utf-8?B?cTlhWXdhNjNuSkZ5Y0RvYWNNa1VuTFQzU3M3MVJ4YmRkNDRSaHhDZy91b1VT?= =?utf-8?B?UHZQT1I2QitFNUJIWEg1TEZVN3k5b1F4QXJIUkRmOW5QcCtodTE2aitLc0VG?= =?utf-8?B?aFRYWlVHTmVzUEQwQzFlMkd1dHNIMHFwRForYlMwejI4QzBTYUYxMTRURy96?= =?utf-8?B?Slg1cVlFcjIxK2dNWmZwNmZKbExIWldHeGxQeUUrUXNEemV4cnJrWGhuQlBD?= =?utf-8?B?bVJVdnZKS2RSNndWMUttTTRuQkdocTNZcUZwdy9CQXFmbnU0MFNvTmhvYmdq?= =?utf-8?B?SXBEVmFNbURlWjVwdktzcVB4c3VuSzU1cFp3b3VDcmMyK3lCbnBQVm5NOHFq?= =?utf-8?B?L3NuY0lneFkrL0JHZWhkeEZEdlRZdzBkclFYejdZRmNZMFp3S0NQUFRWLzQx?= =?utf-8?B?NE1vWVRmK21GbHdNakJkNWlxT0xHQzlZRnk3QmlVYXB4bW9iRWpESG9vMkJz?= =?utf-8?B?eVpyTjJvRlR1WVFHcm0wRG82ZUhWMS9LS3htaTgzTVBXNStZYzBVa04ybVZM?= =?utf-8?B?ZUNmMVJ3Qk1VczdQY3BremJqemNRMGFqUjhQUHdLdEJKR2JBVE44cnBsMHBN?= =?utf-8?B?SEJpNFF6cjRaamVhQVZFeTU2QzVYMUlLa3Y4TEpDQlJua0JVZlk1Q2pHY2VF?= =?utf-8?B?b2NoMlRiSnFMKyttdFdJRjI5R0IxdGswNkM0ejdadGhzUXkyU1llcFJ3WFhn?= =?utf-8?B?ME43Q1dPR1hVakkyZjlRelhpdUd0RzJWS1kvQUF4MVlKUEJnUUxxN2t1c0Nv?= =?utf-8?B?VnY4Mi9hU3FlMnFWUDI0a08weE93MldlNFRlQzFyR0FVZlIzS1lQWEU1VmJX?= =?utf-8?B?dFFkUmxUek1tK2NlT29ydTNGVWZtWmkwS0prUUpTRDYwRndaS2dOOFdIbEpJ?= =?utf-8?Q?x8Dt99mSF/iU07AmiBcxN9fiwhcM0ccDnFR5IBjaqi64?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9db77b73-7dbe-45b0-55f0-08d9d666d24d X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 07:32:15.2167 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: inBEcj57oTKdD67IUbkDfNuUSPIz2rEgQ7i01trtzTe2rpyHBHX3c4e9XTqe/KRTEZaFbZ5C/ILnrRH2zYOFYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3794 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH V3 4/4] libavcodec/qsvenc: Add transform skip to hevc_qsv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-01-13 at 13:12 +0800, Wenbin Chen wrote: > Add transform_skip option to hevc_qsv. By enabling this option, > the transform_skip_enabled_flag in PPS will be set to 1. > This option is supported on the platform equal or newer than CNL. > > Signed-off-by: Wenbin Chen > --- > doc/encoders.texi | 4 ++++ > libavcodec/qsvenc.c | 10 +++++++++- > libavcodec/qsvenc.h | 1 + > libavcodec/qsvenc_hevc.c | 3 +++ > 4 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 3d7c944fba..7714084864 100644 > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -3447,6 +3447,10 @@ Number of rows for tiled encoding. > > @item @var{aud} > Insert the Access Unit Delimiter NAL. > + > +@item @var{transform_skip} > +Turn this option ON to enable transformskip. It is supported on platform > equal > +or newer than CNL. > @end table > > @subsection MPEG2 Options > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index f2ba0241c6..4e5997c9ed 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -358,6 +358,9 @@ static void dump_video_param(AVCodecContext *avctx, > QSVEncContext *q, > av_log(avctx, AV_LOG_VERBOSE, "DisableDeblockingIdc: %"PRIu32" \n", co2- > >DisableDeblockingIdc); > #endif > > +#if QSV_VERSION_ATLEAST(1, 26) > + av_log(avctx, AV_LOG_VERBOSE, "TransformSkip: %s \n", > print_threestate(co3->TransformSkip)); > +#endif > } > > static void dump_video_vp9_param(AVCodecContext *avctx, QSVEncContext *q, > @@ -970,10 +973,15 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > #endif > } > > + if (avctx->codec_id == AV_CODEC_ID_HEVC) { > +#if QSV_VERSION_ATLEAST(1, 26) > + q->extco3.TransformSkip = q->transform_skip ? MFX_CODINGOPTION_ON > : > + MFX_CODINGOPTION_OF > F; q->extco3.TransformSkip is set to MFX_CODINGOPTION_ON when q->transform_skip is -1, right ? TransformSkip is tri-state flag, we may set it to MFX_CODINGOPTION_UNKNOWN when q->transform_skip is -1. Thanks Haihao > +#endif > #if QSV_HAVE_GPB > - if (avctx->codec_id == AV_CODEC_ID_HEVC) > q->extco3.GPB = q->gpb ? MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_OFF; > #endif > + } > q->extparam_internal[q->nb_extparam_internal++] = (mfxExtBuffer *)&q- > >extco3; > #endif > } > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > index 960604cb9a..5a574ada30 100644 > --- a/libavcodec/qsvenc.h > +++ b/libavcodec/qsvenc.h > @@ -200,6 +200,7 @@ typedef struct QSVEncContext { > int repeat_pps; > int low_power; > int gpb; > + int transform_skip; > > int a53_cc; > > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > index 08aba3011d..679c09c858 100644 > --- a/libavcodec/qsvenc_hevc.c > +++ b/libavcodec/qsvenc_hevc.c > @@ -251,6 +251,9 @@ static const AVOption options[] = { > { "tile_rows", "Number of rows for tiled > encoding", OFFSET(qsv.tile_rows), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, > UINT16_MAX, VE }, > { "recovery_point_sei", "Insert recovery point SEI > messages", OFFSET(qsv.recovery_point_sei), AV_OPT_TYPE_INT, { .i64 > = -1 }, -1, 1, VE }, > { "aud", "Insert the Access Unit Delimiter NAL", OFFSET(qsv.aud), > AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE}, > +#if QSV_VERSION_ATLEAST(1, 26) > + { "transform_skip", "Turn this option ON to enable > transformskip", OFFSET(qsv.transform_skip), AV_OPT_TYPE_INT, { > .i64 = -1}, -1, 1, VE}, > +#endif > > { NULL }, > }; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".