From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7ACA247CD9 for ; Wed, 14 Aug 2024 15:06:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E931B68DB68; Wed, 14 Aug 2024 18:06:54 +0300 (EEST) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1455E68DB56 for ; Wed, 14 Aug 2024 18:06:49 +0300 (EEST) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7c3e0a3c444so764552a12.1 for ; Wed, 14 Aug 2024 08:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723648006; x=1724252806; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=g+JzG0fSqwIfqNzp+Pt7X5GgLKhpyY7nB05VEdYZVwc=; b=gLy2gHr4eM/XkL26gJwOxU+SteM8F2haa9XFlUfv3puMJYS5C0snIMY8gVh7XB/2+K 5jQ1NvfkgiwhsIWUXXt7R9fB8CQGGBw4Tdg1TsD/WOz8bQWXhTkvI9ObZ3sa5Q3soy0C JGOR08zTDKlXSa4s9zOjrTob3ziGmp38AFs/vUZ6NBTUx8YvVNvIE6WF1rVuLr39Kn9p iWS79kTXHjd46Ktmakc2WiTrGZithfTPWcTmHTP+yf+uypVO/JrJllxUpEJ8sS1SjxdZ gAjfDYh7Iq/2zwFwUNFszTjQiPMaV5nz9vUnzj5u9MY2YRZXEsBUK07bHje1VmpCCuTY 1q3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723648006; x=1724252806; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g+JzG0fSqwIfqNzp+Pt7X5GgLKhpyY7nB05VEdYZVwc=; b=TwFda5yxpXYiQb85pVlpnLkk/P1j+KVkMXMWrQxK226CJVZ0GkV8Y4YSiwc3D3oQcj kPOMP23Ko8CVCXOG05UVJZoNTHF3a4sddGF0ysJDJV0SSSGqj1HjZ93GWM60STGKfpQT LrDxYzCiie5WI/exjpY2ycrWm0c+pwR5+lO+bgP1kaKk9ndooWTmvAkVz8eDmoqB7nMO /Aul3GGCw6gUiWEhuxZmDR538D5Qo/1cCdlME44wrPBob3HNgII6SIhf+8t9dMMG679u V9LhBUxNvTcRDxNHNnT69MH9xsz1yWr985t5edTJaAq6o38wCrBGClReq+R4BQ3HwcNi f4tw== X-Gm-Message-State: AOJu0YyrJVYALXatgk2/zUAn7ivgzz1hj28mMCBofUGGMId26ZRGC/s+ v0OrGfZAGQO9run2yby1NwhANe4JNaav7k8hxbpM8MlD00MtOO/2FbPA1A== X-Google-Smtp-Source: AGHT+IHlMFAEnNF0c+NOac2u1A8Cv39qEEV8xtEBPhpgSsv2/vUf8Aruw3/azTvUODhjHt9CWBXF2Q== X-Received: by 2002:a17:90a:4bc3:b0:2cf:f860:f13b with SMTP id 98e67ed59e1d1-2d3ace55339mr3978254a91.17.1723648006333; Wed, 14 Aug 2024 08:06:46 -0700 (PDT) Received: from [192.168.0.14] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d3ac856c81sm1847171a91.49.2024.08.14.08.06.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Aug 2024 08:06:45 -0700 (PDT) Message-ID: Date: Wed, 14 Aug 2024 12:07:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240814143421.3990034-1-michael@niedermayer.cc> Content-Language: en-US From: James Almer In-Reply-To: <20240814143421.3990034-1-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/iamf_parse: clear padding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/14/2024 11:34 AM, Michael Niedermayer wrote: > Fixes: use of uninitialized value > Fixes: 70929/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-5931276639469568 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/iamf_parse.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/iamf_parse.c b/libavformat/iamf_parse.c > index 296e49157b0..f2b6d4fa518 100644 > --- a/libavformat/iamf_parse.c > +++ b/libavformat/iamf_parse.c > @@ -1076,6 +1076,7 @@ int ff_iamfdec_read_descriptors(IAMFContext *c, AVIOContext *pb, > size = avio_read(pb, header, FFMIN(MAX_IAMF_OBU_HEADER_SIZE, max_size)); > if (size < 0) > return size; > + memset(header + size, 0, AV_INPUT_BUFFER_PADDING_SIZE); > > len = ff_iamf_parse_obu_header(header, size, &obu_size, &start_pos, &type, NULL, NULL); > if (len < 0 || obu_size > max_size) { I assume get_bits() reads into the padding? Should be ok. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".