From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 352DE422A5 for ; Sun, 1 May 2022 04:15:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 61B2868B2ED; Sun, 1 May 2022 07:15:15 +0300 (EEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 319A668B015 for ; Sun, 1 May 2022 07:15:08 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651378513; x=1682914513; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=76uIL+khdzawhCw5WZiuGC8/+sW44q7JNseBajJMVnY=; b=CTXmDM2kfXctcZE/4IIH1QgScVdvtLtICI3sPPyCGs08cgkRNeWJW7gO EcXZEqt8SUsUMxgTeySDU3mFuQIgrMCB6xwqpuLtuJK3UaSckUu1jcs9o SrtvxT/v3HdwdRoDVsw74pQf4v4Yj3qBJKKIOPSI6x71Z444pTFJHIBiW +VrVD0zjE4wovJJOpfJ72hQDLISB+b9GjEJyq08RuWnCUo9KmHkVLc02X d3F/J47p6ey6JLALZLrIwTCOmARn8fKkEDcXblQLKRJ/fmhK5wClOcb4b dIp1b5c/b7Kp5OJK+KFVpKot+jI1qiznFPDRHzq69SxjP1EWj6CQ9nwUi g==; X-IronPort-AV: E=McAfee;i="6400,9594,10333"; a="246871736" X-IronPort-AV: E=Sophos;i="5.91,189,1647327600"; d="scan'208";a="246871736" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2022 21:15:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,189,1647327600"; d="scan'208";a="687960746" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga004.jf.intel.com with ESMTP; 30 Apr 2022 21:15:06 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 30 Apr 2022 21:15:05 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 30 Apr 2022 21:15:05 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sat, 30 Apr 2022 21:15:05 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sat, 30 Apr 2022 21:15:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cQSd1f3bDUuY/2fN2JkbA+Z8XhCwV3C+QWEwZw9RTMedlOT66bevwk/8Tk3D85aMgg5xM0BUrm1DsRol5zxYULsjG7tjUb4pWtuZwqQSF6NtUGdOY2XwZjAmDA/yrPoHOC7BidjnE7EonWUDCeI65R4kd26hb7J+dC0O0IpSi9Rb7ZUfhRsavFpTCPJZilCGQjJZBxscqygqamvGlVVJ8xF6TPruK8BKwoPKvAKo74Q/NKGibcOlbVZCx9aY6fdhAlF7vgPkwEf3Zk9SsN7OmkM9iI7cOY2pw799gA9GjXLWDG+IkowaOu7OTJJxRW1si0TsCrCje2HNnlHrTHe0hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=76uIL+khdzawhCw5WZiuGC8/+sW44q7JNseBajJMVnY=; b=KZi/6nIIPU/Vbz4fJ+zHM/tcUor3SoM/ZCftvVEptA0ATT0PVulO9YNEpe93huu4hatOZSve52r5NIHnzx1pNXK+eEGYHlApiHDVIyh6W9mOyvcpL2hgqRe7SDaCFcg9b6BmDvIotiUpFEaV2CXiNjTzrVhu/8SYp35khB6bGVx0uVrETjzxATC06siPWAs6kNC/4+MOIGkVAeB1SaQwBowCbiGlXP40mpBe8tD022oIbKEQQgC6Hv06FAyRP7mTC6qXlaBpZm8Yi1sPeGvQI76g9zIvBWk6R1UprXcrDuRoT9PRKtLpOWx3QilM6nUlBJcpEbtD/nwYDIsPhq+bJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by CO1PR11MB5153.namprd11.prod.outlook.com (2603:10b6:303:95::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Sun, 1 May 2022 04:15:04 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::6534:444c:a75d:4bf2]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::6534:444c:a75d:4bf2%9]) with mapi id 15.20.5186.028; Sun, 1 May 2022 04:15:03 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: fix the uninitialized texture bindflag Thread-Index: AQHYW7ZQfXPJMWIIsk+AyqURYyFG+K0HcgaAgAELs4CAAO7egA== Date: Sun, 1 May 2022 04:15:03 +0000 Message-ID: References: <20220429104505.1747-1-tong1.wu@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e3fcfeb1-8aa5-485e-68a1-08da2b292adb x-ms-traffictypediagnostic: CO1PR11MB5153:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SJ1QfXDIL2IYGiVkB6O9jIVN1EUBGlMu8BAp4wRYqbqejin3WnmzFTF2Q8tTrOGOj1mKd6SY+ZaXPCs/nnOuJR0wUz/nyBmoAHhztLAkvoXDSRRlR+o35fWOgMDUtnkT2j8P72MGcnHtzBO5IhK0osEcfpW4FSSKP7IvJEO4d16A1LgcOG3RgZyeWF2GLvSC/u2RMZogeXHZbO+nMf1CMwREXPP32ffO9CTwxr69f895hxHFrYHCuwLnNhlcnazkZc98MVOTe7twQnxbdl7p/uZqBy3zYDddPs4VSTE+PQ3j55fBNH/qnM8/B1znD6he5c51NCfOwVXiJK1fpE8O+jDh1fBvnxYHM9nf+IQYUFvVFTZ+knT2DzXcMJSKfagOCyATaoF+20+nvgCgRMTzaOL+Si0turmMlHN/zK4CT18wFgywkNAb0FBvJ4BMXgRHsrcBTMcsFqm5cijD8uSH2e6zDvOOcgl4sq1p3qqMAciIKyT9Eltd3ZuGxOHX4VMcSBklvTaxxo8UfzJrqw4Vstodp1jgIT5gzZKvLY/b/g/DQPWP862syjxOe/rmmYer+HB1kS07CoWX6M05CL9aLMxkqnU2StqZ2Zr6JCJP2vl2ary6HiVl954wkOmQIZm/dyVCR3dalkJqBszi30sWGavplCiKTYytU1r2qTFjzMDsRx9NdoyywoVYzS4RoOeDHFoHoY1JFAywDcd/jM1AGBXWILFkm5e5uJLmwHwHVLs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(6512007)(26005)(2616005)(6506007)(36756003)(86362001)(122000001)(186003)(8936002)(53546011)(508600001)(5660300002)(6486002)(66946007)(82960400001)(38070700005)(38100700002)(316002)(6916009)(76116006)(83380400001)(71200400001)(91956017)(8676002)(66446008)(66556008)(64756008)(66476007)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZDZqNGVZQkdmSDFmRk1aUXljSEtGcXJnMkFmc2ZKbnNESUU2ZnpjSVNOYVB3?= =?utf-8?B?dERoN2FBOWVicTdscW5Pdk5BZ3RsMkpWL09SdHZzQVc2RlFudXU1SHJOWDlV?= =?utf-8?B?RWtYaytVZjVMeGx5bVBBSkZLTFEzWEhYc3JYUDJ0M0llaGlVdkY1QWVrYU5J?= =?utf-8?B?VmdWamxPSVd5empqRE0vcExNWlhQbGxHbWxKalRkTERibFpZa2V2QkYvMzl5?= =?utf-8?B?bThGUmFtUW9VRE94SkcreHhaYmVaS2wwbmtFNHBuK2VOZmlFV0k2VnovUitu?= =?utf-8?B?Tm5oVHpGSllSdEZCTldHaE1Ka1hzbUgzUXA0ejdHUkhHNHNTTUxMc1FxamE1?= =?utf-8?B?Y1d3c2tZVEhwQmVWbTdmeHBrOFYycDZsZWZoQ0o0Qmt1SWN2V241cFpkWURT?= =?utf-8?B?bHlmQVp3Q2lvclN5VlR4TGRnUHFDMlMwa1B5L25PZlhLdkJxYjJ4anNvdDRD?= =?utf-8?B?RjdieGhtSXJpOXlON0g5bjBTbGZuUmhQNlVyK2FSYlg1eWhtVC9BNU9wQnVP?= =?utf-8?B?S0x1OVRxQjV0aW1IaVRSRHlPT2o4WWZDMEhPSXFHUnd2QU9FWCtaKzhpcnZn?= =?utf-8?B?RXNUSjlBMVI1MEZXbUx1YitZTzUrREIzK3pkUDQ5REFCMEMvc3VhYXpHekVy?= =?utf-8?B?bGNTZXR6M1YrV05YdEw0S09hMVYyL0JYVzhxVHpsRkt6MER4ejMwSy9zM2hL?= =?utf-8?B?b0ZZQThhaC9nOGhFWGV6V2VncmRxa1JXTXpVNmFNbGVQYjF3bkRvQmFwZU8x?= =?utf-8?B?Sm5CL1JiZ1paSDI5WlFhSkt3c2VhSWlJclQwaVlnbDFHL29qSjdXMUY2RkZI?= =?utf-8?B?d3lvR3k5SFNwVGFSbWtoMitDbGptODh3b202SERrWk5laWhLQVVFNTluaWE4?= =?utf-8?B?SncvbjB0d2V5YThCQndSdFE2VE15aytzajVpOHZGQ1FSL2NsTi9qSUY3VWFU?= =?utf-8?B?dlhrVm1PRW1yR05KeXo5YkI0NHNSbEFWdms3bG9nK2ViSGtQcWgrcDVQeHQ0?= =?utf-8?B?MFpmR2ljU1VabzRiK0FJS0pocDJvQzlJWjh3REtlZVZVQmFBcTE2LysxR0sw?= =?utf-8?B?MU56dUN3dGwrOGlBWmhzUzJBWlFjaVR0b1NjYXcvSFNCWVZockMxRE9SczFa?= =?utf-8?B?QS8zWHRCNlVSaHFIcENlWlh5NHF2bDN4ZkJkbmhNRkhBOVVFRHltczJ1UWM5?= =?utf-8?B?R2ZFa0Q3akltOVdkR3dPdHlobWNKbThOK0hNYldCZ2FjNHVtRzZBU0tvM0Nu?= =?utf-8?B?TUZmd2FhL3RSdVBVaDFnM3FuaHUwbHg2cTd4cWN0V0RleGprK0UwSVNyMFkw?= =?utf-8?B?bUlhb0dhcGhma2hESVZiVUZGSyt6WXNKZVZ5VjlCNFM2WnhsYXpmazZEeEVC?= =?utf-8?B?bVMybnVoVnZQVjdNa21kNzlhTXNpa0hQczFoREdUSG9JTDBKTXBUU2pDZDFu?= =?utf-8?B?Q3JlaEpjalR1QXdwcktBWTVjWFlBMlRuNU1HMGY0L1lWNUYrQ2pFZWNod3h2?= =?utf-8?B?OTZ3RTE2c3RVckhudGlkV2h3M0d6WmgrYUVGNWl2ZVhSWU1iY20xUlhpdTVw?= =?utf-8?B?WjRPMENQU0tpQTFTRGRkQWNoanVmMVJJQnBWTGFzMjJoenMrZmc5amYyMlRk?= =?utf-8?B?SzlteFFoSk4vem1yV0JBaUVJZEsvVk04VTJrS1VTOTIyelZvcGlCa3YxMXMy?= =?utf-8?B?K1l2WWRHVDZ2VFB3dUtHSVlYaEVnVGRaTjRFdHRNQW9McmlTTVFqSUtrazVT?= =?utf-8?B?b0FLZnIxQWFBQlVWYXRZUVM1VWNXVUl2SlUxUFhrN2FYNVF3Ukh2S3lrOXJX?= =?utf-8?B?cW50UXZUNFhjcjJFbHRBVGJzUWU1NXFQdjlMbENCN3JydzQxY3g0cW5WSkRB?= =?utf-8?B?YTNmK3dKVm5EMy9wL3hXa2U2c2FhSkN6Z3NjL0k4S0txR3hCY2FCeC9vT3Iy?= =?utf-8?B?L1BtYWRVd1QvK3p3M08yU2RZRVlPa2NNcXhEeWRTbjJaMFk3YTg1L2tsWHh5?= =?utf-8?B?NlI0dDlGRFFEUjEwbFM1V0w5THdENytkQWViVG5wcWVQYkNhR29rY0JqU0pq?= =?utf-8?B?YUhicjY0R1lRSTZIMytRK295Z1QyK3huRkQ1VGxoYWFSKzN5L04zUDEzNlJS?= =?utf-8?B?dzVydWxyRWdlbXg2NTIzY3VyUlRnYUNEZjRaaEFTV3Y0RWY5T1pRalB3eGhh?= =?utf-8?B?VkVraHhnZkhiaS8vZTdydTZOaUF0UGlsb0ZQUTY2ZVQvZmp5NFVPWi8vUThQ?= =?utf-8?B?UDJJUWN2YVgzR2crVy9xUm1aVmYreWV0aGtNaHQ2TVB0SCtRWVU4V0Jic2hO?= =?utf-8?B?WFVZYk12WURjOXgzQmZkaldjU1ZXUm05VitGNmNjWnZHM0lOR3BKdFArKy9u?= =?utf-8?Q?NqtHLAJzQ7iLcGj8=3D?= Content-ID: <0F21CC9C18738445B5CF181909F7128B@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3fcfeb1-8aa5-485e-68a1-08da2b292adb X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2022 04:15:03.8553 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d4DqQj3ddkK7JYMJ2OLXa1zp029kKYs5LgVAstoN2mJEEVKNKCCUR6fh5RXAOGCMxaC8yOIX9ynH2CHlnpqmXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5153 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: fix the uninitialized texture bindflag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 2022-04-30 at 13:59 +0000, Soft Works wrote: > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Hendrik Leppkes > > Sent: Saturday, April 30, 2022 12:02 AM > > To: FFmpeg development discussions and patches > devel@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: > > fix the uninitialized texture bindflag > > > > On Fri, Apr 29, 2022 at 12:45 PM Tong Wu > > wrote: > > > > > > When uploading rawvideos using d3d11va hardware framecontext, the > > > > bindflag > > > is not initialized and will cause creating texture failure. Now fix > > > > it, > > > assign it the value of D3D11_BIND_RENDER_TARGET. > > > > > > > As with similar fixes of this nature, this implicit behavior to fix > > one particular bug does not seem fitting inside the hwcontext itself. > > There can be a large list of usages of the hwcontext that all require > > different BindFlags, but we can only define one default - why this one > > specifically? > > I agree that this change is not ideal. On one side, it is "safe" in a way > that a texture is practically unusable for video processing without having > at least one of the flags (decoder, encoder or render_target), > so this wouldn't "hurt" anybody. > > > So rather: > > > > Where is the context created? > > Looking at the command line in the commit message, this is about > standalone D3D11 context creation. > > > Why is a required flag not set there? That would be better, because > > that knows what flags it needs. > > There doesn't really exist an appropriate "there". I see two options > > 1. Add a generic internal device creation parameter to the dictionary > in ffmpeg_hw.c like "standalone=1" > (for all devices created via init_hw_device) > > Some time ago, I had another case where I thought this could be useful. > Then, this could be used in d3d11va_device_create() to set an internal > field 'default_bindflags' which would be used as condition in > d3d11va_frames_init. The situation would remain similar though, as that > when the device is used by a decoder (which sets the decoder flag) > this needs to override the default. > > 2. Use a device parameter specific to the D3D11 > hwcontextD3D11_BIND_RENDER_TARGET > > This would need to be specified in the command line. > Everything else like in #1 > > What do you think? There aren't extra parameters for other standalone hwcontext creation. May we take BindFlags=0 as the default setting and set texDesc.BindFlags to D3D11_BIND_RENDER_TARGET directly ? Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".