From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E422F4A0C8 for ; Wed, 20 Mar 2024 02:23:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E38A268D4C7; Wed, 20 Mar 2024 04:23:46 +0200 (EET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 753DC6802CD for ; Wed, 20 Mar 2024 04:23:40 +0200 (EET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1deffa23bb9so31279485ad.2 for ; Tue, 19 Mar 2024 19:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710901418; x=1711506218; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=hCCO+oO/+lDipjxwAmnYTz2La2/pIDhsvQ7eicdmZLA=; b=kBVS0uFRSifyOi4bwiBjXZxpQgRxnRsWwsjZH6o5U5uyTyznIzqEbna4rNbRsQ9JrW 7J4kMEYtYkKvJ5Xd/KjHO4RmEQZHP+IwDNBup37edRPD6SNkSgmjIn9Lq4xfqjGnemHg rFQw3x9Rkot7M4mQTJ2ZLyDNftUQ/k4tOc1u8dhhI94BCOop4w3doZ+/DbjIwXSKDE+I qfhszhUqdSO1Uhprra09SCmBI5Wt9tKlYFSCtd49yhzX4gsYv88jioqsQ4ov+CN3GfZE qnRB7YubanWhdVKgejvQ37Iu1nirc+wPviND2PvLLpeHKAj+wYyfjKAWuccQyKgDur49 ToJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710901418; x=1711506218; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hCCO+oO/+lDipjxwAmnYTz2La2/pIDhsvQ7eicdmZLA=; b=Mw1f/q8KvoaTezX/YvdtaAUTRQod+ULhSxO4Y4HzYG6EAEte9RYS/Ca448wnqpOf1q NB4eHfAKfrfKHoA06VWy5WYq1GlL8lI94dfvi3vn2reSr7E/jcdqz2GefZEnkZf5F1pB vJ7xKcWgCFItbbLkMFsyztzTjE72JRhW4zkD/NNME5UnRunw/NykyNOSnQZVrO1TRGHV yAsh5gpVCzMp8twNEoD6YMJzCtBWiqGYlVBtXMZZJhacj8Z7hVoDABvwdu4cg0qrSs3Y vaFkY13RKysFsZB091zSKTGfw5en2BwOmu1sESuZbg28z9VZ0boyh8gvg+Gz+lE0jiEC ycbw== X-Gm-Message-State: AOJu0YwVjC/ZQcSP2jN0EXgKLTRl5BUwH63LNv91pxiwSXckl5sTXWyy JgOlFoY85pHU5yrJMknfVtXxcbXcmda0jVKlvHypKD70cGx5mHnZNFUo43dS X-Google-Smtp-Source: AGHT+IFFjan1D4Y7dBl3zDkdSHT1BTSUxA1Htx540sy6Hu7zmSvfJn83Fa1hyK1riQgL4mfJiYe6yA== X-Received: by 2002:a17:902:9a03:b0:1e0:2c82:435c with SMTP id v3-20020a1709029a0300b001e02c82435cmr5876569plp.57.1710901417664; Tue, 19 Mar 2024 19:23:37 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id n18-20020a170902e55200b001dba98889a3sm12158373plf.71.2024.03.19.19.23.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Mar 2024 19:23:37 -0700 (PDT) Message-ID: Date: Tue, 19 Mar 2024 23:23:53 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/iamfenc: Remove always-false check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/19/2024 12:29 AM, Andreas Rheinhardt wrote: > This muxer does not have the AVFMT_NOSTREAMS flag; therefore > it is checked generically that there is at least a stream. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/iamfenc.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/libavformat/iamfenc.c b/libavformat/iamfenc.c > index ebf0c2fd67..bf4a268c95 100644 > --- a/libavformat/iamfenc.c > +++ b/libavformat/iamfenc.c > @@ -48,11 +48,6 @@ static int iamf_init(AVFormatContext *s) > int nb_audio_elements = 0, nb_mix_presentations = 0; > int ret; > > - if (!s->nb_streams) { > - av_log(s, AV_LOG_ERROR, "There must be at least one stream\n"); > - return AVERROR(EINVAL); > - } > - > for (int i = 0; i < s->nb_streams; i++) { > if (s->streams[i]->codecpar->codec_type != AVMEDIA_TYPE_AUDIO || > (s->streams[i]->codecpar->codec_tag != MKTAG('m','p','4','a') && Patchset LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".