Re: [FFmpeg-devel] [PATCH 1/3] avformat/iamfenc: Remove always-false check

[James Almer <jamrial@gmail.com>]

On 3/19/2024 12:29 AM, Andreas Rheinhardt wrote:
> This muxer does not have the AVFMT_NOSTREAMS flag; therefore
> it is checked generically that there is at least a stream.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   libavformat/iamfenc.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/libavformat/iamfenc.c b/libavformat/iamfenc.c
> index ebf0c2fd67..bf4a268c95 100644
> --- a/libavformat/iamfenc.c
> +++ b/libavformat/iamfenc.c
> @@ -48,11 +48,6 @@ static int iamf_init(AVFormatContext *s)
>       int nb_audio_elements = 0, nb_mix_presentations = 0;
>       int ret;
>   
> -    if (!s->nb_streams) {
> -        av_log(s, AV_LOG_ERROR, "There must be at least one stream\n");
> -        return AVERROR(EINVAL);
> -    }
> -
>       for (int i = 0; i < s->nb_streams; i++) {
>           if (s->streams[i]->codecpar->codec_type != AVMEDIA_TYPE_AUDIO ||
>               (s->streams[i]->codecpar->codec_tag != MKTAG('m','p','4','a') &&

Patchset LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".