Re: [FFmpeg-devel] [PATCH] avutil/frame: add new functions to get frame side data

[James Almer <jamrial@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 897 bytes --]

On 3/10/2025 11:57 AM, Andreas Rheinhardt wrote:
> Leandro Santiago:
>> The functions are:
>>
>> av_frame_side_data_get_nth_c()
>> av_frame_side_data_get_nth()
>> av_frame_get_nth_side_data()
>>
>> They mimic the counterparts without the `_nth` suffix/infix, with an extra
>> argument, which specifies the relative position of the entry of a given
>> type.
>>
>> Signed-off-by: Leandro Santiago <leandrosansilva@gmail.com>
>> ---
>>   libavutil/frame.c     | 10 ++++++++++
>>   libavutil/frame.h     | 43 ++++++++++++++++++++++++++++++++++++++++---
>>   libavutil/side_data.c | 14 +++++++++++---
>>   3 files changed, 61 insertions(+), 6 deletions(-)
>>
> Is this really such an important usecase that we need to add new public
> functions for this?

IMO, no. There's only one side data type with the multi prop, SEI 
Unregistered, so this function is somewhat overkill.


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".