From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B505D42897 for ; Tue, 5 Apr 2022 13:59:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AD98268B167; Tue, 5 Apr 2022 16:59:21 +0300 (EEST) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6671568A351 for ; Tue, 5 Apr 2022 16:59:15 +0300 (EEST) Received: by mail-oi1-f181.google.com with SMTP id k10so13521654oia.0 for ; Tue, 05 Apr 2022 06:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=eDUYpJgSJkKisBlompj5CcPt3p2rrBkzL0vzZeTDX0U=; b=cJgvNUY2JWuD6pDB9VBKxx1GF04OSDTJBcYHDWmXrq0trhPDkE7nHDFxGeK4YMOHS5 aZ3/bT9dCFQAFKPqCLs2MXcKMQyv555mjO1WqQ7vj1BFkFjXygwQfUHZ2WPCuytcCoeT XIDQaS8LLiMWBaTPg6QNLQSy8caHLjwo4bTEDi8jvanDfvpvKW1aYqa5voss+YmJRTfr yUp/Ej3XH+0Haw3zrOzjXu7aKe51mIcx5iQ+5UF2NsHTbzIHeGO+Sk7pnmWL7aeMxxl9 d1smWqFUG2bUb+YJVmNi6i19GrAa/g3KXPTYahLLSGC6vzI6T/txWBKdovIDftBZ976p dfPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=eDUYpJgSJkKisBlompj5CcPt3p2rrBkzL0vzZeTDX0U=; b=m6Sv0Em21JG13AzjvgfYnLbDqtCryuTHpmttrtl3dVM0BOvNQxe2UQUV/2UuQi4QSP vMkwAMwYZN+4Py1rJTX0G28MUN3mJXRVye3SwhvAQON67e41+NKOuJNBko7IhDmrvDRl QSR4CESEcdNAoTq9ng15g4kbMRHIQjB4LXY4kZUrritObgmPmc95wm3eZD1Kf+lV53JW unY/9zLiTMk/U8F4uK3LvoDMKxz+Bb2flAb7LpNP3ERW1pMnMO5P1RBE0mJiFDGqezGF aBZsKGQQs3YEBiegChZlyrjNdACsmMJ30x0eejFRpe3jqekDWeDrPrMpprYkjfZWYFKK ylVw== X-Gm-Message-State: AOAM531k/NpHc+yWsK09uqoqwhzcIYF+AOPHO79WIkE+/d8bCFy9L8IK mqExr3C/K5FvXz2Aa/ycyTdQVwjc7ZB+2A== X-Google-Smtp-Source: ABdhPJxVpAy7zpF+IxVn1IdFhloCrrcLbLdRzVx5DmTsamRaaPI5trn4s9BJvMNp9dYDLFOZ6oB44w== X-Received: by 2002:a05:6808:10c2:b0:2ec:d6d2:d0f with SMTP id s2-20020a05680810c200b002ecd6d20d0fmr1449332ois.28.1649167153702; Tue, 05 Apr 2022 06:59:13 -0700 (PDT) Received: from [192.168.0.12] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id y66-20020a9d22c8000000b005c943ff75dbsm5660483ota.7.2022.04.05.06.59.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Apr 2022 06:59:13 -0700 (PDT) Message-ID: Date: Tue, 5 Apr 2022 10:59:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <164915298959.21047.64072881760748019@lain.red.khirnov.net> <20220405121539.1773869-1-danilchap@google.com> From: James Almer In-Reply-To: <20220405121539.1773869-1-danilchap@google.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: return quantizer parameter for an encoded frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/5/2022 9:15 AM, Danil Chapovalov wrote: > --- > libavcodec/libvpxenc.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index dff1d06b0e..0705863450 100644 > --- a/libavcodec/libvpxenc.c > +++ b/libavcodec/libvpxenc.c > @@ -1250,6 +1250,8 @@ static int storeframe(AVCodecContext *avctx, struct FrameListData *cx_frame, > int ret = ff_get_encode_buffer(avctx, pkt, cx_frame->sz, 0); > uint8_t *side_data; > int pict_type; > + int quality; > + VPxContext *ctx = avctx->priv_data; > > if (ret < 0) > return ret; > @@ -1264,7 +1266,12 @@ static int storeframe(AVCodecContext *avctx, struct FrameListData *cx_frame, > pict_type = AV_PICTURE_TYPE_P; > } > > - ff_side_data_set_encoder_stats(pkt, 0, cx_frame->sse + 1, > + ret = vpx_codec_control(&ctx->encoder, VP8E_GET_LAST_QUANTIZER_64, &quality); > + if (ret != VPX_CODEC_OK) { Is the last argument guaranteed to be untouched when the return value of vpx_codec_control() is not VPX_CODEC_OK? If so, you can initialize quality to 0 above, and remove this part. > + quality = 0; > + } > + > + ff_side_data_set_encoder_stats(pkt, quality * FF_QP2LAMBDA, cx_frame->sse + 1, > cx_frame->have_sse ? 3 : 0, pict_type); > > if (cx_frame->have_sse) { _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".