From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 911F140CEB for ; Wed, 8 Jun 2022 22:06:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EB82D68B6C7; Thu, 9 Jun 2022 01:06:53 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9489168B512 for ; Thu, 9 Jun 2022 01:06:47 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id E3C76E6B69 for ; Thu, 9 Jun 2022 00:06:47 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wddEEjfWoyPf for ; Thu, 9 Jun 2022 00:06:45 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 40859E4E56 for ; Thu, 9 Jun 2022 00:06:45 +0200 (CEST) Date: Thu, 9 Jun 2022 00:06:45 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20220523232442.GW396728@pb2> Message-ID: References: <20170101232833.24472-1-michael@niedermayer.cc> <2cbd676e-ab01-741f-3233-7971414f5525@gmail.com> <20170104000650.GS4749@nb4> <20220523232442.GW396728@pb2> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/texturedspenc: Fix indexing in color distribution determination X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 24 May 2022, Michael Niedermayer wrote: > On Wed, Jan 04, 2017 at 11:52:50PM +0100, Vittorio Giovara wrote: >> On Wed, Jan 4, 2017 at 1:06 AM, Michael Niedermayer >> wrote: >>> On Tue, Jan 03, 2017 at 02:15:20PM +0100, Vittorio Giovara wrote: >>>> On Mon, Jan 2, 2017 at 2:00 AM, James Almer wrote: >>>>> On 1/1/2017 8:28 PM, Michael Niedermayer wrote: >>>>>> Fixes CID1396405 >>>> >>>> What is the CID about? >>> >>> sorry for not quoting this prviously, it isnt very interresting. >>> my patch is based on just this and guesswork, which is why it should >>> be tested. >>> >>> 257 for (y = 0; y < 4; y++) { >>> assignment: Assigning: x = 4. >>> const: At condition x < 4, the value of x must be equal to 4. >>> dead_error_condition: The condition x < 4 cannot be true. >>> 258 for (x = 4; x < 4; x += 4) { >>> CID 1396405 (#1 of 1): Logically dead code (DEADCODE)dead_error_begin: Execution cannot reach this statement: muv += bp[x * 4 + y * stride];. >> >> Ah, yes that seems wrong, probably a leftover of the code conversion >> (from https://github.com/nothings/stb/blob/master/stb_dxt.h#L293-L298) >> I believe it should be sufficient to do `for (x = 0; x < 4; x++)` but >> I won't be able to test that for a while I'm afraid > > This issue seems stil open, i just stumbled accross the CID again > when looking at coverity > anyone has means to test this ? Actually fate now covers this in vbn-dxt5 and vbn-dxt1 tests. Average MSE/PSNR is slightly improved with the patch, so I have applied it. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".