From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CC1764A603 for ; Mon, 1 Apr 2024 20:43:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1849768CDDB; Mon, 1 Apr 2024 23:43:36 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 629C968C094 for ; Mon, 1 Apr 2024 23:43:30 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id CDA6DEA32D for ; Mon, 1 Apr 2024 22:43:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R_s7HWcf33w3 for ; Mon, 1 Apr 2024 22:43:27 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 0640EEA31C for ; Mon, 1 Apr 2024 22:43:27 +0200 (CEST) Date: Mon, 1 Apr 2024 22:43:26 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <9c53d6b4-eff3-4832-a87f-7896e177e998@gmail.com> Message-ID: References: <20240401185621.15297-1-cus@passwd.hu> <20240401185621.15297-3-cus@passwd.hu> <9c53d6b4-eff3-4832-a87f-7896e177e998@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/4] avformat/mov_chan: respect channel order when parsing and creating chnl atom X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 1 Apr 2024, James Almer wrote: > On 4/1/2024 3:56 PM, Marton Balint wrote: >> Previously we always assumed that the channels are in native order, even >> if >> they were not. The new channel layout API allows us to signal the proper >> channel order, so let's do so. >> >> Signed-off-by: Marton Balint >> --- >> libavformat/mov_chan.c | 145 +++++++++++++++++++++---------------- >> libavformat/mov_chan.h | 5 +- >> tests/ref/fate/mov-mp4-pcm | 2 +- >> 3 files changed, 86 insertions(+), 66 deletions(-) > > [...] > >> diff --git a/tests/ref/fate/mov-mp4-pcm b/tests/ref/fate/mov-mp4-pcm >> index 6bae8f800b..19a978df95 100644 >> --- a/tests/ref/fate/mov-mp4-pcm >> +++ b/tests/ref/fate/mov-mp4-pcm >> @@ -1,4 +1,4 @@ >> -99ad26b4054794e84bd962a1124cdccf *tests/data/fate/mov-mp4-pcm.mp4 >> +462668dd69e7ce4fde4934d1d5978531 *tests/data/fate/mov-mp4-pcm.mp4 > > What changes in the output? The chnl atom changes for the 7.1 layout, the order of channels (being in native order) is different from the the ISO order, so defined layout 12 cannot be used. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".