Re: [FFmpeg-devel] [PATCH 3/4] avformat/mov_chan: respect channel order when parsing and creating chnl atom

[Marton Balint <cus@passwd.hu>]

On Mon, 1 Apr 2024, James Almer wrote:

> On 4/1/2024 3:56 PM, Marton Balint wrote:
>>  Previously we always assumed that the channels are in native order, even
>>  if
>>  they were not. The new channel layout API allows us to signal the proper
>>  channel order, so let's do so.
>>
>>  Signed-off-by: Marton Balint <cus@passwd.hu>
>>  ---
>>    libavformat/mov_chan.c     | 145 +++++++++++++++++++++----------------
>>    libavformat/mov_chan.h     |   5 +-
>>    tests/ref/fate/mov-mp4-pcm |   2 +-
>>    3 files changed, 86 insertions(+), 66 deletions(-)
>
> [...]
>
>>  diff --git a/tests/ref/fate/mov-mp4-pcm b/tests/ref/fate/mov-mp4-pcm
>>  index 6bae8f800b..19a978df95 100644
>>  --- a/tests/ref/fate/mov-mp4-pcm
>>  +++ b/tests/ref/fate/mov-mp4-pcm
>>  @@ -1,4 +1,4 @@
>>  -99ad26b4054794e84bd962a1124cdccf *tests/data/fate/mov-mp4-pcm.mp4
>>  +462668dd69e7ce4fde4934d1d5978531 *tests/data/fate/mov-mp4-pcm.mp4
>
> What changes in the output?

The chnl atom changes for the 7.1 layout, the order of channels (being in 
native order) is different from the the ISO order, so defined layout 12
cannot be used.

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".