From: James Almer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: James Almer <jamrial@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/mfenc: set output packet duration
Date: Thu, 14 Aug 2025 11:14:37 -0300
Message-ID: <c8a108b8-f5f1-43cb-b228-329d0839439d@gmail.com> (raw)
In-Reply-To: <CAJgjuozsgOtXk6hBVQ57Yhk+BhjTeqKgZak5JEghy-i7awrD0g@mail.gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1637 bytes --]
On 8/13/2025 8:39 PM, Pavel Koshevoy wrote:
> On Tue, Aug 12, 2025 at 7:59 AM James Almer <jamrial@gmail.com> wrote:
>
>> On 8/4/2025 4:50 PM, Pavel Koshevoy wrote:
>>> ---
>>> libavcodec/mfenc.c | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
>>> index 30531fe3e8..942c75cb9d 100644
>>> --- a/libavcodec/mfenc.c
>>> +++ b/libavcodec/mfenc.c
>>> @@ -148,6 +148,15 @@ static int64_t mf_sample_get_pts(AVCodecContext
>> *avctx, IMFSample *sample)
>>> return mf_from_mf_time(avctx, pts);
>>> }
>>>
>>> +static int64_t mf_sample_get_duration(AVCodecContext *avctx, IMFSample
>> *sample)
>>> +{
>>> + LONGLONG duration;
>>> + HRESULT hr = IMFSample_GetSampleDuration(sample, &duration);
>>> + if (FAILED(hr))
>>> + return 0;
>>> + return mf_from_mf_time(avctx, duration);
>>> +}
>>> +
>>> static int mf_enca_output_type_get(AVCodecContext *avctx, IMFMediaType
>> *type)
>>> {
>>> MFContext *c = avctx->priv_data;
>>> @@ -275,6 +284,7 @@ static int mf_sample_to_avpacket(AVCodecContext
>> *avctx, IMFSample *sample, AVPac
>>> IMFMediaBuffer_Release(buffer);
>>>
>>> avpkt->pts = avpkt->dts = mf_sample_get_pts(avctx, sample);
>>> + avpkt->duration = mf_sample_get_duration(avctx, sample);
>>>
>>> hr = IMFAttributes_GetUINT32(sample,
>> &MFSampleExtension_CleanPoint, &t32);
>>> if (c->is_audio || (!FAILED(hr) && t32 != 0))
>>
>> Will apply.
>>
>
>
> I just checked, and it's not applied. Any idea when it will be applied?
Just pushed it.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-08-14 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 19:50 Pavel Koshevoy
2025-08-07 12:14 ` Pavel Koshevoy
2025-08-12 13:56 ` Pavel Koshevoy
2025-08-12 13:58 ` James Almer
2025-08-13 23:39 ` Pavel Koshevoy
2025-08-14 14:14 ` James Almer via ffmpeg-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8a108b8-f5f1-43cb-b228-329d0839439d@gmail.com \
--to=ffmpeg-devel@ffmpeg.org \
--cc=jamrial@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git