Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Tobias Rapp <t.rapp@noa-archive.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_setparams: Fix chroma_location being cleared
Date: Wed, 7 May 2025 11:04:59 +0200
Message-ID: <c82dad1d-0d75-441e-aaee-d26c38cc8130@noa-archive.com> (raw)
In-Reply-To: <20250502200809.GB4991@pb2>

On 02/05/2025 22:08, Michael Niedermayer wrote:

> On Wed, Apr 30, 2025 at 02:56:58PM +0200, Tobias Rapp wrote:
>> On 30/04/2025 14:09, Tobias Rapp wrote:
>>
>>> Fix chroma_location being cleared by setrange and setfield filters.
>>> This was forgotten in 201f1cba150d44de6fedfeee4e8647170ed5fbca.
>>>
>>> Signed-off-by: Tobias Rapp <t.rapp@noa-archive.com>
>>> ---
>>>    libavfilter/vf_setparams.c | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/libavfilter/vf_setparams.c b/libavfilter/vf_setparams.c
>>> index 751750e..1e37876 100644
>>> --- a/libavfilter/vf_setparams.c
>>> +++ b/libavfilter/vf_setparams.c
>>> @@ -236,6 +236,7 @@ static av_cold int init_setrange(AVFilterContext *ctx)
>>>        s->color_primaries = -1;
>>>        s->color_trc       = -1;
>>>        s->colorspace      = -1;
>>> +    s->chroma_location = -1;
>>>        return 0;
>>>    }
>>> @@ -272,6 +273,7 @@ static av_cold int init_setfield(AVFilterContext *ctx)
>>>        s->color_primaries = -1;
>>>        s->color_trc       = -1;
>>>        s->colorspace      = -1;
>>> +    s->chroma_location = -1;
>>>        return 0;
>>>    }
>> If approved, I would also like to backport the fix to the release/7.1
>> branch.
> backport ok
> 201f1cba150d44de6fedfeee4e8647170ed5fbca is niklas change so, give him a
> bit time to reply but it looks like this was forgotten i agree

Pushed to master and backported to release/7.1.

Regards, Tobias

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2025-05-07  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30 12:09 Tobias Rapp
2025-04-30 12:56 ` Tobias Rapp
2025-05-02 20:08   ` Michael Niedermayer
2025-05-07  9:04     ` Tobias Rapp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c82dad1d-0d75-441e-aaee-d26c38cc8130@noa-archive.com \
    --to=t.rapp@noa-archive.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git