From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6818640D15 for ; Sat, 25 May 2024 06:10:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DF23C68D58E; Sat, 25 May 2024 09:10:32 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B602568D4F6 for ; Sat, 25 May 2024 09:10:25 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 23715EA724 for ; Sat, 25 May 2024 08:10:25 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QbsIAM75e6En for ; Sat, 25 May 2024 08:10:23 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 55F91E53DF for ; Sat, 25 May 2024 08:10:23 +0200 (CEST) Date: Sat, 25 May 2024 08:10:23 +0200 (CEST) From: Marton Balint To: Lynne via ffmpeg-devel In-Reply-To: <20240525022813.2292001-2-dev@lynne.ee> Message-ID: References: <20240525022813.2292001-1-dev@lynne.ee> <20240525022813.2292001-2-dev@lynne.ee> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 25 May 2024, Lynne via ffmpeg-devel wrote: > apichanges will be updated upon merging, as well as a version bump. > --- > libavutil/channel_layout.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h > index 8a078d1601..4e19bbbd9e 100644 > --- a/libavutil/channel_layout.h > +++ b/libavutil/channel_layout.h > @@ -79,6 +79,10 @@ enum AVChannel { > AV_CHAN_BOTTOM_FRONT_CENTER, > AV_CHAN_BOTTOM_FRONT_LEFT, > AV_CHAN_BOTTOM_FRONT_RIGHT, > + AV_CHAN_SURROUND_LEFT, > + AV_CHAN_SURROUND_RIGHT, You want to add a channel ID for Surround or Side Surround? Because based on the subsequent AAC patch you want to add it for side surround, but then the AV_CHAN_SURROUND name is confusing, since we are mapping Surround to AV_CHAN_SIDE. So I suggest using AV_CHAN_SIDE_SURROUND_LEFT/RIGHT instead. > + AV_CHAN_TOP_SURROUND_LEFT, > + AV_CHAN_TOP_SURROUND_RIGHT, You will need to extend the channel_names[] array in channel_layout.c with the newly added channel IDs. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".