From: Peter Krefting <peter@softwolves.pp.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] configure: Remove dcbzl check for e500v1 and e500v2 architectures
Date: Wed, 28 Sep 2022 16:15:57 +0100 (CET)
Message-ID: <c7f1fa54-1160-2381-29c4-73144f3558@softwolves.pp.se> (raw)
In-Reply-To: <4427824.LvFx2qVVIh@basile.remlab.net>
Rémi Denis-Courmont:
>> Our compiler (powerpc-btech-linux-gnuspe-gcc (crosstool-NG 1.24.0) 8.3.0)
>> recognizes the instruction, so the configure test succeeds, but the CPU
>> (e500v2) crashes if it tries to execute it.
> Yes?
Indeed.
>> I previously had a patch (d5733936d857ce5c7d28c0bc9e89a2e2548f8895) to
>> suppress the instruction, but it broke at some point, this patch tries to fix
>> it in a slightly better way.
> AFAICT, this old changeset had the exact same problem as this patch. If
> somebody just compiles FFmpeg with default flags as one does, it remains
> broken.
Before d5733936, ffmpeg would crash on startup on e500v2 when the
binary tried to use the unsupported instruction (when built with
default configuration). At d5733936 it works as the instruction is
disabled.
At some point between d5733936 and HEAD, a default "configure" run for
this CPU re-enabled the instruction, causing it again to crash on
startup. Since the configure script was changed to set "disable" in
the CPU selection header:
e500v2)
cpuflags="-mcpu=8548 -mhard-float -mfloat-gprs=double"
disable altivec
disable dcbzl <--- here
(which I believe came in from the avconf fork merge), my patch fixes
the ppc-specific branch to check if it was disabled in the above
stanza.
> Normally, you would expect that the default flags result in something
> that works, if perhaps not optimally, no?
Exactly, this is what I am trying to (re-)fix.
(And yes, I know that the CPU I am running on is end-of-life, but the
joy of working with embedded hardware is that you have to support it
anyway.)
--
\\// Peter - http://www.softwolves.pp.se/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-28 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 10:51 Peter Krefting
2022-09-26 11:24 ` Rémi Denis-Courmont
2022-09-28 12:52 ` Peter Krefting
2022-09-28 14:28 ` Rémi Denis-Courmont
2022-09-28 15:15 ` Peter Krefting [this message]
2024-01-05 21:35 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7f1fa54-1160-2381-29c4-73144f3558@softwolves.pp.se \
--to=peter@softwolves.pp.se \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git