From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 02E7343B60 for ; Mon, 18 Jul 2022 18:18:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6DA9568B95E; Mon, 18 Jul 2022 21:18:21 +0300 (EEST) Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D6BF368B6D1 for ; Mon, 18 Jul 2022 21:18:15 +0300 (EEST) Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-10c0052da61so25908392fac.12 for ; Mon, 18 Jul 2022 11:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=64vba50CTSI2a6nfDTI4AgKcKGIsKa5abfweSI+bXW4=; b=dSivBROOyu+4SoF70b1StvICQ7mQidbuQOeJz0+IKYLfrALwVfnmubhQHy7+U7KEaB e15aYfD8fjqQU2xiOKaeYucrPYPoWVgxrcpamE6xzvo/GwQ8/gzUmRDdBkhKkw4f7pf6 2dnv1eJVk25JHh5fMkrtBWgroRydUfuau0PK7BfeFMJ1mRjXP9w8+6GqKHys9mFGbb9k 5SN4r0Cl0/NuAq++ojXU28J6vfu+rMbwG9Ir1fjy/x80AIIKW8p8yIg+ZI6jLC5UPdZv 8MjfEOmQTCv47EAqpTFrhbHTKi5zuNnJm+42xtVIMwb0x367f3ymMcvpbqWiwQXyjCmV dTJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=64vba50CTSI2a6nfDTI4AgKcKGIsKa5abfweSI+bXW4=; b=waE75uPViQec6ijG0WODMEjQf1Ps2M/GsI5m9DqCncAkWXQeLNVPZarTtUvjfcLXvk NlXYhEVnRYngREg21VSmJdspaXJTuwo0nZOZi8qMQthu8SxuwiC/nuGHMKWmLNwDhq3B YAQnCZN/5mHiXx+4b9WgeCVSH/yPhLtevcKO2U8+3HELvK1pimHIjs6gKQfLBGJAc0ol UaqYmfH7Yh/jQ77U0oaFwe9+Xok8065Eb3DdNW/YVlzu0Jg7NwnlD4Xk4ObarzN7vHnn 8mkCNoZAQ78lM+Htys8lJ3uVqjXcsuN5YLBGUD5FRjkAAD+7J+krg1ZrxCWcDr+0jvt7 IBbg== X-Gm-Message-State: AJIora+EYlYrCcsY0OHSe6Vgou78n1mRrpqSE3sUPilhSYyHg9XzEwUz Ae+rBCV5RSfSUxVUDbQKR93vebgnrA86dQ== X-Google-Smtp-Source: AGRyM1tOXQD74Qyagg/3S8e50Xb95aELE7FFEJWYpHpqYQziVdA5tNq8DuSwLSHgFOV8n6nJUISWiQ== X-Received: by 2002:a05:6870:3399:b0:10d:5b33:566f with SMTP id w25-20020a056870339900b0010d5b33566fmr2049623oae.266.1658168293995; Mon, 18 Jul 2022 11:18:13 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.204]) by smtp.gmail.com with ESMTPSA id r12-20020a056830120c00b00616dfd2c859sm5288710otp.59.2022.07.18.11.18.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jul 2022 11:18:13 -0700 (PDT) Message-ID: Date: Mon, 18 Jul 2022 15:18:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220717220619.GO2088045@pb2> <20220718071225.4446-1-anton@khirnov.net> <8f3313ba-de91-6ea7-6bef-03ea0dfe0d33@gmail.com> <165816813316.15564.17775576086260685988@lain.khirnov.net> From: James Almer In-Reply-To: <165816813316.15564.17775576086260685988@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264: support AV_CODEC_CAP_ENCODER_RECON_FRAME X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/18/2022 3:15 PM, Anton Khirnov wrote: > Quoting James Almer (2022-07-18 14:23:58) >> On 7/18/2022 4:12 AM, Anton Khirnov wrote: >>> --- >>> libavcodec/libx264.c | 52 +++++++++++++++++++++++++++++++++++++++++++- >>> 1 file changed, 51 insertions(+), 1 deletion(-) >>> >>> diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c >>> index 98ec030865..5e360682e6 100644 >>> --- a/libavcodec/libx264.c >>> +++ b/libavcodec/libx264.c >>> @@ -311,6 +311,25 @@ static void free_picture(AVCodecContext *ctx) >>> pic->extra_sei.num_payloads = 0; >>> } >>> >>> +static enum AVPixelFormat csp_to_pixfmt(int csp) >>> +{ >>> + switch (csp) { >>> +#ifdef X264_CSP_I400 >>> + case X264_CSP_I400: return AV_PIX_FMT_GRAY8; >>> + case X264_CSP_I400 | X264_CSP_HIGH_DEPTH: return AV_PIX_FMT_GRAY10; >>> +#endif >>> + case X264_CSP_I420: return AV_PIX_FMT_YUV420P; >>> + case X264_CSP_I420 | X264_CSP_HIGH_DEPTH: return AV_PIX_FMT_YUV420P10; >>> + case X264_CSP_I422: return AV_PIX_FMT_YUV422P; >>> + case X264_CSP_I422 | X264_CSP_HIGH_DEPTH: return AV_PIX_FMT_YUV422P10; >>> + case X264_CSP_I444: return AV_PIX_FMT_YUV444P; >>> + case X264_CSP_I444 | X264_CSP_HIGH_DEPTH: return AV_PIX_FMT_YUV444P10; >> >> We're still supporting old x264 versions, so you should add some >> considerations for 9 bit pixfmts. On X264_BUILD < 153, just check the >> value of x264_bit_depth. > > Is there much point in continuing to support 5.5 year old x264? We could > drop a lot of ugliness, including the abominable X264_init_static(). Afaik we tend to support what's shipped with not yet EOL'd big distros like Debian and Ubuntu. I assume Michael's Ubuntu setup is one of those, and it has a libx264 without X264_CSP_I400, for example. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".