From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BA8D747801 for ; Wed, 22 Nov 2023 17:18:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E7EB668CCFF; Wed, 22 Nov 2023 19:18:05 +0200 (EET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8ED7268C98D for ; Wed, 22 Nov 2023 19:17:59 +0200 (EET) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6c431b91b2aso39678b3a.1 for ; Wed, 22 Nov 2023 09:17:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700673477; x=1701278277; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f4pZ9dx1cn3mQ0GnRWjaxrdFbyBhu29l1N35CCc8THM=; b=icrYqdZ2NkjU0fIPvME+ENH4VndHtxCe+DtGtO/L14AnrYgttqNAAaejGiwhEdX6Sj 02Y9ql49JDBVtji1oBSDGV89DprViUcRHnJpz2mcUWWQAwuKXg+w1DAlLT5UIH5uRjzw TL6NDjv0mlOvKYGnyL/5pUoUrA86Pz76NTJBASjsP2dQ6vuCgZbW+ZtfKTBT82SmvNXp LdBU9hD8Mf4LSLN/B+aDgvxtCk9iG+Az6R50cit+5idyNWm9xPxQWo7w1/Tn49uWIXB3 EqWHpIgIfyGPxnjaH5g6qFV8VQp7o+Wc6Y2G1Bw93XZbCyV2M794LG51MMNknLjeNSRr 6Ejg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700673477; x=1701278277; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f4pZ9dx1cn3mQ0GnRWjaxrdFbyBhu29l1N35CCc8THM=; b=gSuCUmsOLI1+d/MYz9yYO3U/37xJizmdioojCQ/Lj5/wAsvkwTS5aXhfbxnQ92O9jo XiOCTSxSaBQJEfB/rCrIo+2kcrYW+5jKhUnNRev5wiXtBTDBKU6Rpz1n4N5bHsT+iMdK 9pEKqsucziPC10cu43WdHjQ+7mScRBunO0kBvv0o1QgSenTf41dmmapdfxFfPSzSvVTp g9BSWrjYO+ms874J0mVYkIcLEX7ngWUWH2s7AH5Rnal9cdqbHOcKPIeAuKXVdxMP3SA6 5Tbl+p3nsliO8KFf3Pg056F+h3/64twT1ZxWKI1VcEuFaSLrHPUUQbMXcrh1zSdWMKx4 neVQ== X-Gm-Message-State: AOJu0YwC30CeILybmju1ruCktiLf8kxtuNdU9imcufJR9ntR7aLhDdh5 ecFdRsURyZ44Mii0l5eNrykCDTG6ffY= X-Google-Smtp-Source: AGHT+IGRF2uAzjgDWhMAq6kIZNHJKM5VxkWoNkILOJpWCDCgzalN//521wka5T350EswkkcvwsLU2g== X-Received: by 2002:a05:6a21:9982:b0:189:11e8:6237 with SMTP id ve2-20020a056a21998200b0018911e86237mr3257891pzb.51.1700673476925; Wed, 22 Nov 2023 09:17:56 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id t33-20020a056a0013a100b006cbafd6996csm5300009pfg.123.2023.11.22.09.17.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 09:17:55 -0800 (PST) Message-ID: Date: Wed, 22 Nov 2023 14:18:05 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <502DD795-A076-42CF-94EA-11B198219668@remlab.net> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] ac3dsp: RISC-V V float_to_fixed24 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/22/2023 11:30 AM, flow gg wrote: >> How did you test it? > > I wrote a test, but it was a bit rough, so I want to modify it before > submitting. I've added it to this reply. > From 08a012d86db51275fd2cda8dd7ad47cc1f1481ce Mon Sep 17 00:00:00 2001 > From: sunyuechi > Date: Wed, 22 Nov 2023 14:57:29 +0800 > Subject: [PATCH] lavc/ac3dsp: R-V V float_to_fixed24 > > --- > tests/checkasm/Makefile | 1 + > tests/checkasm/ac3dsp.c | 88 +++++++++++++++++++++++++++++++++++++++ > tests/checkasm/checkasm.c | 3 ++ > tests/checkasm/checkasm.h | 1 + > 4 files changed, 93 insertions(+) > create mode 100644 tests/checkasm/ac3dsp.c > > diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile > index 8bc241d29b..8c714c2a07 100644 > --- a/tests/checkasm/Makefile > +++ b/tests/checkasm/Makefile > @@ -5,6 +5,7 @@ AVCODECOBJS-$(CONFIG_BLOCKDSP) += blockdsp.o > AVCODECOBJS-$(CONFIG_BSWAPDSP) += bswapdsp.o > AVCODECOBJS-$(CONFIG_FMTCONVERT) += fmtconvert.o > AVCODECOBJS-$(CONFIG_G722DSP) += g722dsp.o > +AVCODECOBJS-$(CONFIG_AC3DSP) += ac3dsp.o > AVCODECOBJS-$(CONFIG_H264CHROMA) += h264chroma.o > AVCODECOBJS-$(CONFIG_H264DSP) += h264dsp.o > AVCODECOBJS-$(CONFIG_H264PRED) += h264pred.o > diff --git a/tests/checkasm/ac3dsp.c b/tests/checkasm/ac3dsp.c > new file mode 100644 > index 0000000000..ebebe06990 > --- /dev/null > +++ b/tests/checkasm/ac3dsp.c > @@ -0,0 +1,88 @@ > +#include "checkasm.h" > +#include > + > + > +#include > + > +#include "libavutil/common.h" > +#include "libavutil/intreadwrite.h" > +#include "libavutil/mem.h" > +#include "libavutil/mem_internal.h" > + > +#include "libavcodec/ac3dsp.h" > + > +/** > + * Convert an array of float in range [-1.0,1.0] to int32_t with range > + * [-(1<<24),(1<<24)] > + * > + * @param dst destination array of int32_t. > + * constraints: 16-byte aligned > + * @param src source array of float. > + * constraints: 16-byte aligned > + * @param len number of elements to convert. > + * constraints: multiple of 32 greater than zero > + */ > +// void (*float_to_fixed24)(int32_t *dst, const float *src, unsigned int len); > + > + > +#define randomize_float(buf, len) \ > + do { \ > + int i; \ > + for (i = 0; i < len; i++) { \ > + float f = (float)rnd() / (UINT_MAX >> 5) - 16.0f; \ > + buf[i] = f; \ > + } \ > + } while (0) > + > +#define randomize_int(buf, len, size, bits) \ > + do { \ > + int i; \ > + for (i = 0; i < len; i++) { \ > + uint ## size ## _t r = rnd() & ((1LL << bits) - 1); \ > + AV_WN ## size ## A(buf + i, -(1LL << (bits - 1)) + r); \ > + } \ > + } while (0) > + > +static void check_float_to_fixed24(AC3DSPContext *c) { > +#define BUF_SIZE 800 800, if this is meant to be used as len, is not a multiple of 32. > + LOCAL_ALIGNED_32(int32_t, v1, [BUF_SIZE]); > + LOCAL_ALIGNED_32(float, v2, [BUF_SIZE]); > + > + declare_func(void, int32_t *, const float *, unsigned int); > + > + randomize_int(v1, BUF_SIZE, 32, 10); This is not really used at all. The input is floats, and the output is write only. > + randomize_float(v2, BUF_SIZE); > + > + if (check_func(c->float_to_fixed24, "float_to_fixed24")) { > + LOCAL_ALIGNED_32(int32_t, dst, [BUF_SIZE]); > + LOCAL_ALIGNED_32(int32_t, dst2, [BUF_SIZE]); The requirement is 16 byte alignment. > + > + call_ref(dst, v2, 80); This should be BUF_SIZE. And 80 is also not a multiple of 32. > + call_new(dst2, v2, 80); > + > + if (memcmp(dst, dst2, sizeof(*dst) * 10) != 0){ memcmp(dst, dst2, sizeof(dst)) > + puts(">>>>>>>>>>>>>> fail --------------------"); No puts(), please. This line is also not needed. > + for(int i = 0 ; i < 10; i++){ > + printf("dst[%d] = %d, dst2[%d] = %d\n", i, dst[i], i, dst2[i]); fprintf(stderr, ...); > + } > + puts(""); > + > + fail(); > + } else { > + puts(">>>>>>>>>>>>>> ok --------------------"); Same. > + } > + > + bench_new(v1, v2, 80); bench_new(dst2, v2... > + } > + > + > + report("float_to_fixed24"); > +} > + > +void checkasm_check_ac3dsp(void) > +{ > + AC3DSPContext c; > + ff_ac3dsp_init(&c); > + > + check_float_to_fixed24(&c); > +} > diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c > index 708119e7c6..9502e372a1 100644 > --- a/tests/checkasm/checkasm.c > +++ b/tests/checkasm/checkasm.c > @@ -105,6 +105,9 @@ static const struct { > #if CONFIG_G722DSP > { "g722dsp", checkasm_check_g722dsp }, > #endif > + #if CONFIG_AC3DSP > + { "ac3dsp", checkasm_check_ac3dsp }, > + #endif > #if CONFIG_H264CHROMA > { "h264chroma", checkasm_check_h264chroma }, > #endif > diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h > index cfea868ff1..4c73589606 100644 > --- a/tests/checkasm/checkasm.h > +++ b/tests/checkasm/checkasm.h > @@ -96,6 +96,7 @@ void checkasm_check_vp8dsp(void); > void checkasm_check_vp9dsp(void); > void checkasm_check_videodsp(void); > void checkasm_check_vorbisdsp(void); > +void checkasm_check_ac3dsp(void); > > struct CheckasmPerf; > > -- > 2.43.0 > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".