From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id F2E964DAF0 for <ffmpegdev@gitmailbox.com>; Tue, 22 Apr 2025 21:56:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9C0F168A467; Wed, 23 Apr 2025 00:56:29 +0300 (EEST) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1DB9A68A0C3 for <ffmpeg-devel@ffmpeg.org>; Wed, 23 Apr 2025 00:56:08 +0300 (EEST) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-af50f56b862so4077768a12.1 for <ffmpeg-devel@ffmpeg.org>; Tue, 22 Apr 2025 14:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745358966; x=1745963766; darn=ffmpeg.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:from:to:cc:subject:date :message-id:reply-to; bh=5YWlHicprTUMXnuXj1utYyCN+4zihDqa/nqh+JhtDtM=; b=g/W29MTmNWMm+5yNv+pXarvwXl7Tt/f40l7KmhwU3Y6OSGvnULu78kQ0kkNe09hgW2 12VWsHu78Z6xPcpX1T/jNZqoIrIKdXzbuXI3fujZUGsKLFC0Pc60buenhGWFfS553roY 2KMlogD4BqaiaALHvw59S3DEPvJtH/3SyfZ+RHhQI+4xElmz4YpUphqdG/pskdZ+Iidm bfgp9PQ8CscD5/8PDIJz+PD0GBU/1RHsN4z0qVkQjfM9bKCNWkSoRRHUVNL4wu9/bmVJ 3ZeGjUMEQgQ0BC/Q1Fw6oSui78hdnDAYD3Brv0NCzR4D12WkaXVTQmK4teLiQLOZI8UM TfnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745358966; x=1745963766; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5YWlHicprTUMXnuXj1utYyCN+4zihDqa/nqh+JhtDtM=; b=V9W7VzfWGRS3TQdlJAzgMJZrl1uUnHifaM2csb+Zl1IN1jTHkXD+bhht3HyYTqqbTS YljyaY9X1zoQIbbKY4npYMls4TlQ6m4C7eGrGulaSnAdzhjWSGYUUvLCD4/K5IQ5UuF0 0jZ2AsSgEJngCDemvjY5k27ONbuUTlKH2+m2HueGHEkZeXrNe70S8ve7cfcxYEY2239U TRql7yR/r73DLX3lKf9jeAzhbIQzC3siE6FPzw2+m02EEYYFLmeGPFvA4sheNDaec2d7 gANNG123z5WRit8SY8XGxdG08ENrMchpC5VHhLeVsNG739MHySOh1rhi8EQUk8i6cK0X mgDg== X-Gm-Message-State: AOJu0Yx3+qT9PcxArbsSr/bth5JwYIBhY7yvtZMww+uof7IqgLZ6ibQt olNfIClbqxXjswbrR54Vuz8jYX+rtcAOu+cWqueZYbPQD7yRJr3nOXLZ41BY X-Gm-Gg: ASbGncvkG5V39PwWyOlgKnddJPBZfJuFUerHomygFg21Cl4ZZSkyZNPKIePP0y9XZOc K3jfM63IRtoQo43yvNfjubepiIt+OSpJ3IAWHSC474crwiSthn4Nv05OTqtAPSDpqXwlE0vccyN rXDQv1a3eFmY48sm+fp7VYIgWNrLzr0/vem7ucIB/ZmEkSsJHrlI++3pKRMu74VvpiNBYFDF4ll A6TwJibkT5VUdAFUzsm+ffrKV62643b7VSTkD+ExX/ZVyHVh6LCgs/SpuoGsC1gJYnldce3UavP fHDmAuCL25fNZiYmIAueuWn5TnSw4i0Y7dJKmiivhaeUv+9kQZZm7ryKWc7GOBnQ6xSTqA== X-Google-Smtp-Source: AGHT+IGvF1iYkmDMkdlGysQZtShQVaCNVbj8lVPAhrxdVNR057b6mTw+q47/r1KOsbwss8ri35sHbw== X-Received: by 2002:a17:902:f643:b0:21f:7880:8472 with SMTP id d9443c01a7336-22c53607720mr298359625ad.35.1745358966193; Tue, 22 Apr 2025 14:56:06 -0700 (PDT) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c50fdea5csm90464505ad.247.2025.04.22.14.56.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Apr 2025 14:56:05 -0700 (PDT) From: softworkz <ffmpegagent@gmail.com> X-Google-Original-From: softworkz <softworkz@hotmail.com> Message-Id: <c71836fce01816ef8a83e3e63745012a7acb4bce.1745358943.git.ffmpegagent@gmail.com> In-Reply-To: <pull.66.v5.ffstaging.FFmpeg.1745358943.ffmpegagent@gmail.com> References: <pull.66.v4.ffstaging.FFmpeg.1745189954.ffmpegagent@gmail.com> <pull.66.v5.ffstaging.FFmpeg.1745358943.ffmpegagent@gmail.com> Date: Tue, 22 Apr 2025 21:55:32 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v5 03/14] fftools/avtextformat: Re-use BPrint in loop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: softworkz <softworkz@hotmail.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/c71836fce01816ef8a83e3e63745012a7acb4bce.1745358943.git.ffmpegagent@gmail.com/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> From: softworkz <softworkz@hotmail.com> Instead of initializing a new BPrint in each iteration of the loop, re-use the same BPrint struct and just clear it for each iteration. Signed-off-by: softworkz <softworkz@hotmail.com> --- fftools/textformat/avtextformat.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c index 1939a1f739..0a221f4a9a 100644 --- a/fftools/textformat/avtextformat.c +++ b/fftools/textformat/avtextformat.c @@ -308,24 +308,25 @@ void avtext_print_integer(AVTextFormatContext *tctx, const char *key, int64_t va static inline int validate_string(AVTextFormatContext *tctx, char **dstp, const char *src) { - const uint8_t *p, *endp; + const uint8_t *p, *endp, *srcp = (const uint8_t *)src; AVBPrint dstbuf; + AVBPrint bp; int invalid_chars_nb = 0, ret = 0; + *dstp = NULL; av_bprint_init(&dstbuf, 0, AV_BPRINT_SIZE_UNLIMITED); + av_bprint_init(&bp, 0, AV_BPRINT_SIZE_UNLIMITED); - endp = src + strlen(src); - for (p = src; *p;) { - uint32_t code; + endp = srcp + strlen(src); + for (p = srcp; *p;) { + int32_t code; int invalid = 0; const uint8_t *p0 = p; if (av_utf8_decode(&code, &p, endp, tctx->string_validation_utf8_flags) < 0) { - AVBPrint bp; - av_bprint_init(&bp, 0, AV_BPRINT_SIZE_AUTOMATIC); - bprint_bytes(&bp, p0, p-p0); - av_log(tctx, AV_LOG_DEBUG, - "Invalid UTF-8 sequence %s found in string '%s'\n", bp.str, src); + av_bprint_clear(&bp); + bprint_bytes(&bp, p0, p - p0); + av_log(tctx, AV_LOG_DEBUG, "Invalid UTF-8 sequence %s found in string '%s'\n", bp.str, src); invalid = 1; } @@ -345,7 +346,7 @@ static inline int validate_string(AVTextFormatContext *tctx, char **dstp, const } if (!invalid || tctx->string_validation == AV_TEXTFORMAT_STRING_VALIDATION_IGNORE) - av_bprint_append_data(&dstbuf, p0, p-p0); + av_bprint_append_data(&dstbuf, (const char *)p0, p - p0); } if (invalid_chars_nb && tctx->string_validation == AV_TEXTFORMAT_STRING_VALIDATION_REPLACE) @@ -355,6 +356,7 @@ static inline int validate_string(AVTextFormatContext *tctx, char **dstp, const end: av_bprint_finalize(&dstbuf, dstp); + av_bprint_finalize(&bp, NULL); return ret; } -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".